mbox series

[0/2] soundwire: configure block packing mode with new

Message ID 20210323050701.23760-1-yung-chuan.liao@linux.intel.com
Headers show
Series soundwire: configure block packing mode with new | expand

Message

Liao, Bard March 23, 2021, 5:06 a.m. UTC 
The existing code multiply a channel number by zero (SDW_BLK_GRP_CNT_1),
and the result is used to configure the block packing mode. Sampling
grouping and channel packing are two separate concepts in SoundWire.

In addition, the bandwidth allocation allocates a vertical slice for
each stream, which makes the use of the PER_CHANNEL packing mode
irrelevant.

Let's use the proper definition for block packing mode (PER_PORT).

This change has no functional impact though since the net result is
the same configuration of the DPN_BlockCtrl3 register, when implemented.

Pierre-Louis Bossart (2):
  soundwire: add definition for DPn BlockPackingMode
  soundwire: generic_allocation: fix confusion between group and packing

 drivers/soundwire/generic_bandwidth_allocation.c | 7 +++----
 include/linux/soundwire/sdw.h                    | 6 ++++++
 2 files changed, 9 insertions(+), 4 deletions(-)

Comments

Vinod Koul March 30, 2021, 9:06 a.m. UTC | #1 
On 23-03-21, 13:06, Bard Liao wrote:
> The existing code multiply a channel number by zero (SDW_BLK_GRP_CNT_1),
> and the result is used to configure the block packing mode. Sampling
> grouping and channel packing are two separate concepts in SoundWire.
> 
> In addition, the bandwidth allocation allocates a vertical slice for
> each stream, which makes the use of the PER_CHANNEL packing mode
> irrelevant.
> 
> Let's use the proper definition for block packing mode (PER_PORT).
> 
> This change has no functional impact though since the net result is
> the same configuration of the DPN_BlockCtrl3 register, when implemented.

Applied, thanks