| Message ID | 20200818140656.29014-1-yung-chuan.liao@linux.intel.com |
|---|---|
| Headers | show |
| Series | soundwire: filter out invalid PARITY errors | expand |
Dne 28. 08. 20 v 8:51 Vinod Koul napsal(a): > Hi Mark, > > On 18-08-20, 22:06, Bard Liao wrote: >> From: Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com> >> >> Add a slave-level property and program the SCP_INT1_MASK as desired by >> the codec driver. Since there is no DisCo property this has to be an >> implementation-specific firmware property or hard-coded in the driver. >> >> The only functionality change is that implementation-defined >> interrupts are no longer set for amplifiers - those interrupts are >> typically for jack detection or acoustic event detection/hotwording. >> >> Tested-by: Srinivas Kandagatla <srinivas.kandagatla@linaro.org> >> Signed-off-by: Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com> >> Reviewed-by: Kai Vehmanen <kai.vehmanen@linux.intel.com> >> Reviewed-by: Guennadi Liakhovetski <guennadi.liakhovetski@linux.intel.com> >> Signed-off-by: Bard Liao <yung-chuan.liao@linux.intel.com> >> --- >> drivers/soundwire/bus.c | 12 ++++++------ >> include/linux/soundwire/sdw.h | 2 ++ >> sound/soc/codecs/max98373-sdw.c | 3 +++ >> sound/soc/codecs/rt1308-sdw.c | 2 ++ >> sound/soc/codecs/rt5682-sdw.c | 4 ++++ >> sound/soc/codecs/rt700-sdw.c | 4 ++++ >> sound/soc/codecs/rt711-sdw.c | 4 ++++ >> sound/soc/codecs/rt715-sdw.c | 4 ++++ >> sound/soc/codecs/wsa881x.c | 1 + > > This touches codecs, can you Ack it please Mark, could you ack the ASoC change to accept this patch via the soundwire repo? > > Ideally this should have been split up to header, the codec updates and > finally the bus change! I don't think that the split is ideal in this case. I tested the code and it looks straight enough. Acked-by: Jaroslav Kysela <perex@perex.cz>
On Tue, Sep 08, 2020 at 02:05:11PM +0200, Jaroslav Kysela wrote: > Dne 28. 08. 20 v 8:51 Vinod Koul napsal(a): > >> sound/soc/codecs/rt700-sdw.c | 4 ++++ > >> sound/soc/codecs/rt711-sdw.c | 4 ++++ > >> sound/soc/codecs/rt715-sdw.c | 4 ++++ > >> sound/soc/codecs/wsa881x.c | 1 + > > This touches codecs, can you Ack it please > Mark, could you ack the ASoC change to accept this patch via the soundwire repo? I don't have this patch and since I seem to get copied on quite a lot of soundwire only serieses I just delete them unread mostly.
Dne 08. 09. 20 v 14:11 Mark Brown napsal(a): > On Tue, Sep 08, 2020 at 02:05:11PM +0200, Jaroslav Kysela wrote: >> Dne 28. 08. 20 v 8:51 Vinod Koul napsal(a): > >>>> sound/soc/codecs/rt700-sdw.c | 4 ++++ >>>> sound/soc/codecs/rt711-sdw.c | 4 ++++ >>>> sound/soc/codecs/rt715-sdw.c | 4 ++++ >>>> sound/soc/codecs/wsa881x.c | 1 + > >>> This touches codecs, can you Ack it please > >> Mark, could you ack the ASoC change to accept this patch via the soundwire repo? > > I don't have this patch and since I seem to get copied on quite a lot of > soundwire only serieses I just delete them unread mostly. > It can be fetched from lore (mbox format): https://lore.kernel.org/alsa-devel/20200818140656.29014-2-yung-chuan.liao@linux.intel.com/raw Thanks, Jaroslav
Dne 08. 09. 20 v 16:33 Mark Brown napsal(a): > On Tue, Sep 08, 2020 at 02:28:48PM +0200, Jaroslav Kysela wrote: >> Dne 08. 09. 20 v 14:11 Mark Brown napsal(a): > >>> I don't have this patch and since I seem to get copied on quite a lot of >>> soundwire only serieses I just delete them unread mostly. > >> It can be fetched from lore (mbox format): > >> https://lore.kernel.org/alsa-devel/20200818140656.29014-2-yung-chuan.liao@linux.intel.com/raw > > Sure, I can go get stuff from the list archives but my list of things to > go through is in my inbox. > Okay, please, Bard resend this patchset as v2 (with already agreed Acked-by:) otherwise it won't be applied. I believe that an ack on my follow-up with the check of the original message should be sufficient, but apparently it isn't. Thanks, Jaroslav
On 9/8/20 9:33 AM, Mark Brown wrote: > On Tue, Sep 08, 2020 at 02:28:48PM +0200, Jaroslav Kysela wrote: >> Dne 08. 09. 20 v 14:11 Mark Brown napsal(a): > >>> I don't have this patch and since I seem to get copied on quite a lot of >>> soundwire only serieses I just delete them unread mostly. We now try to use the ASoC/SoundWire prefix for cover letters to highlight that a patchset changes things across two trees, does this help or do we need a different way of flagging these patches? >> It can be fetched from lore (mbox format): > >> https://lore.kernel.org/alsa-devel/20200818140656.29014-2-yung-chuan.liao@linux.intel.com/raw > > Sure, I can go get stuff from the list archives but my list of things to > go through is in my inbox. >
On Tue, Sep 08, 2020 at 09:47:13AM -0500, Pierre-Louis Bossart wrote: > On 9/8/20 9:33 AM, Mark Brown wrote: > > On Tue, Sep 08, 2020 at 02:28:48PM +0200, Jaroslav Kysela wrote: > > > Dne 08. 09. 20 v 14:11 Mark Brown napsal(a): > > > > I don't have this patch and since I seem to get copied on quite a lot of > > > > soundwire only serieses I just delete them unread mostly. > We now try to use the ASoC/SoundWire prefix for cover letters to highlight > that a patchset changes things across two trees, does this help or do we > need a different way of flagging these patches? I think the issue is mainly where the patch itself touches both, if some of the patches mention ASoC I'll generally notice them but Soundwire is one of these things I get so many random CCs for I just zone it out so highlighting the individual patches would help.
> -----Original Message----- > From: Jaroslav Kysela <perex@perex.cz> > Sent: Tuesday, September 8, 2020 10:43 PM > To: Mark Brown <broonie@kernel.org> > Cc: Vinod Koul <vkoul@kernel.org>; Bard Liao <yung- > chuan.liao@linux.intel.com>; pierre-louis.bossart@linux.intel.com; alsa- > devel@alsa-project.org; tiwai@suse.de; gregkh@linuxfoundation.org; linux- > kernel@vger.kernel.org; ranjani.sridharan@linux.intel.com; > hui.wang@canonical.com; srinivas.kandagatla@linaro.org; > jank@cadence.com; Lin, Mengdong <mengdong.lin@intel.com>; Kale, Sanyog > R <sanyog.r.kale@intel.com>; rander.wang@linux.intel.com; Liao, Bard > <bard.liao@intel.com> > Subject: Re: [PATCH 1/7] soundwire: bus: use property to set interrupt masks > > Dne 08. 09. 20 v 16:33 Mark Brown napsal(a): > > On Tue, Sep 08, 2020 at 02:28:48PM +0200, Jaroslav Kysela wrote: > >> Dne 08. 09. 20 v 14:11 Mark Brown napsal(a): > > > >>> I don't have this patch and since I seem to get copied on quite a lot of > >>> soundwire only serieses I just delete them unread mostly. > > > >> It can be fetched from lore (mbox format): > > > >> https://lore.kernel.org/alsa-devel/20200818140656.29014-2-yung- > chuan.liao@linux.intel.com/raw > > > > Sure, I can go get stuff from the list archives but my list of things to > > go through is in my inbox. > > > > Okay, please, Bard resend this patchset as v2 (with already agreed Acked-by:) > otherwise it won't be applied. I believe that an ack on my follow-up with the > check of the original message should be sufficient, but apparently it isn't. Done. I forgot to mention that the patches themselves are not changed in the cover letter. The only changes in v2 is editing the title with "ASoC/ soundwire:" prefix. > > Thanks, > Jaroslav > > -- > Jaroslav Kysela <perex@perex.cz> > Linux Sound Maintainer; ALSA Project; Red Hat, Inc.