| Message ID | 1638179932-3353-1-git-send-email-srivasam@codeaurora.org |
|---|---|
| Headers | show |
| Series | Add pin control support for lpass sc7280 | expand |
On 12/1/2021 8:37 PM, Srinivas Kandagatla wrote: Thanks for clarification Srini!! > > On 01/12/2021 14:33, Srinivasa Rao Mandadapu wrote: >>> >>> >>>> +enum lpass_lpi_functions { >>>> + LPI_MUX_dmic1_clk, >>>> + LPI_MUX_dmic1_data, >>>> + LPI_MUX_dmic2_clk, >>>> + LPI_MUX_dmic2_data, >>>> + LPI_MUX_dmic3_clk, >>>> + LPI_MUX_dmic3_data, >>>> + LPI_MUX_i2s1_clk, >>>> + LPI_MUX_i2s1_data, >>>> + LPI_MUX_i2s1_ws, >>>> + LPI_MUX_i2s2_clk, >>>> + LPI_MUX_i2s2_data, >>>> + LPI_MUX_i2s2_ws, >>>> + LPI_MUX_qua_mi2s_data, >>>> + LPI_MUX_qua_mi2s_sclk, >>>> + LPI_MUX_qua_mi2s_ws, >>>> + LPI_MUX_swr_rx_clk, >>>> + LPI_MUX_swr_rx_data, >>>> + LPI_MUX_swr_tx_clk, >>>> + LPI_MUX_swr_tx_data, >>>> + LPI_MUX_wsa_swr_clk, >>>> + LPI_MUX_wsa_swr_data, >>>> + LPI_MUX_gpio, >>>> + LPI_MUX__, >>>> +}; >>>> + >>>> +static const unsigned int gpio0_pins[] = { 0 }; >>>> +static const unsigned int gpio1_pins[] = { 1 }; >>>> +static const unsigned int gpio2_pins[] = { 2 }; >>>> +static const unsigned int gpio3_pins[] = { 3 }; >>>> +static const unsigned int gpio4_pins[] = { 4 }; >>>> +static const unsigned int gpio5_pins[] = { 5 }; >>>> +static const unsigned int gpio6_pins[] = { 6 }; >>>> +static const unsigned int gpio7_pins[] = { 7 }; >>>> +static const unsigned int gpio8_pins[] = { 8 }; >>>> +static const unsigned int gpio9_pins[] = { 9 }; >>>> +static const unsigned int gpio10_pins[] = { 10 }; >>>> +static const unsigned int gpio11_pins[] = { 11 }; >>>> +static const unsigned int gpio12_pins[] = { 12 }; >>>> +static const unsigned int gpio13_pins[] = { 13 }; >>> >>> >>> to here are specific to sm8250, so it should not be in header file >>> to start with. >> >> As these are common to all lpass variants.. I feel it's better to >> keep in Header file. > > You realize that every include of this file will add these static > variables to file, in this case to pinctrl-lpass-lpi.c, > pinctrl-sm8250-lpass-lpi.c and pinctrl-sc7280-lpass-lpi.c > so in first file(pinctrl-lpass-lpi.c) you never use those variables in > second file (pinctrl-sm8250-lpass-lpi.c)you only use up to gpio13 and > in third file pinctrl-sc7280-lpass-lpi.c you could use them. > > so its really bad idea to add static variables in header files. > Okay. Understood. will move it SoC specific files. > --srini > >> >> And if new pins comes in later variants, we can add them >> incrementally, and they will not impact existing pin numbers. >> >> I think in upcoming variants number of pins will not decrease. >>
This patch series is to split lpass variant common pin control functions and SoC specific functions and to add lpass sc7280 pincontrol support. It also Adds dt-bindings for lpass sc7280 lpass lpi pincontrol. Changes Since V2: -- Add new dt-bindings for sc7280 lpi driver. -- Make clock voting change as separate patch. -- Split existing pincontrol driver and make common functions as part of separate file. -- Rename lpass pincontrol lpi dt-bindings to sm8250 specific dt-bindings Changes Since V1: -- Make lpi pinctrl variant data structure as constant -- Add appropriate commit message -- Change signedoff by sequence. Srinivasa Rao Mandadapu (5): dt-bindings: pinctrl: qcom: Update lpass lpi file name to SoC specific dt-bindings: pinctrl: qcom: Add sc7280 lpass lpi pinctrl bindings pinctrl: qcom: Move chip specific functions to right files pinctrl: qcom: Update clock voting as optional pinctrl: qcom: Add SC7280 lpass pin configuration .../bindings/pinctrl/qcom,lpass-lpi-pinctrl.yaml | 130 ----------- .../pinctrl/qcom,sc7280-lpass-lpi-pinctrl.yaml | 115 ++++++++++ .../pinctrl/qcom,sm8250-lpass-lpi-pinctrl.yaml | 130 +++++++++++ drivers/pinctrl/qcom/Makefile | 2 + drivers/pinctrl/qcom/pinctrl-lpass-lpi.c | 253 +-------------------- drivers/pinctrl/qcom/pinctrl-lpass-lpi.h | 140 ++++++++++++ drivers/pinctrl/qcom/pinctrl-sc7280-lpass-lpi.c | 127 +++++++++++ drivers/pinctrl/qcom/pinctrl-sm8250-lpass-lpi.c | 125 ++++++++++ 8 files changed, 646 insertions(+), 376 deletions(-) delete mode 100644 Documentation/devicetree/bindings/pinctrl/qcom,lpass-lpi-pinctrl.yaml create mode 100644 Documentation/devicetree/bindings/pinctrl/qcom,sc7280-lpass-lpi-pinctrl.yaml create mode 100644 Documentation/devicetree/bindings/pinctrl/qcom,sm8250-lpass-lpi-pinctrl.yaml create mode 100644 drivers/pinctrl/qcom/pinctrl-lpass-lpi.h create mode 100644 drivers/pinctrl/qcom/pinctrl-sc7280-lpass-lpi.c create mode 100644 drivers/pinctrl/qcom/pinctrl-sm8250-lpass-lpi.c