| Message ID | 1601447977-18115-1-git-send-email-srivasam@codeaurora.org |
|---|---|
| Headers | show |
| Series | Qualcomm's lpass-hdmi ASoC driver to support audio over dp port | expand |
On 30/09/2020 07:39, Srinivasa Rao Mandadapu wrote: > +} > + > +static bool lpass_hdmi_regmap_volatile(struct device *dev, unsigned int reg) > +{ > + return true; > +} I did ask this question in multiple reviews, but never got an answer! Are all the dp/hdmi port register range really volatile!? --srini > + > +struct regmap_config lpass_hdmi_regmap_config = { > + .reg_bits = 32, > + .reg_stride = 4, > + .val_bits = 32, > + .writeable_reg = lpass_hdmi_regmap_writeable, > + .readable_reg = lpass_hdmi_regmap_readable, > + .volatile_reg = lpass_hdmi_regmap_volatile,
Thanks for bringing up this point Srinivas!!! On 9/30/2020 8:57 PM, Srinivas Kandagatla wrote: > > > On 30/09/2020 07:39, Srinivasa Rao Mandadapu wrote: >> +} >> + >> +static bool lpass_hdmi_regmap_volatile(struct device *dev, unsigned >> int reg) >> +{ >> + return true; >> +} > > I did ask this question in multiple reviews, but never got an answer! > Are all the dp/hdmi port register range really volatile!? Sorry for incomplete response in last review comment reply. With making only specific DMA registers and interrupts registers true, aplay was stuck. Now we identified issue causing register and made it volatile. With that change it seems working fine. After doing all the tests we will share v9 series patch. > > > > --srini >> + >> +struct regmap_config lpass_hdmi_regmap_config = { >> + .reg_bits = 32, >> + .reg_stride = 4, >> + .val_bits = 32, >> + .writeable_reg = lpass_hdmi_regmap_writeable, >> + .readable_reg = lpass_hdmi_regmap_readable, >> + .volatile_reg = lpass_hdmi_regmap_volatile,
On Sat, Oct 03, 2020 at 05:06:06PM +0530, Srinivasa Rao Mandadapu wrote: > On 9/30/2020 8:57 PM, Srinivas Kandagatla wrote: > > I did ask this question in multiple reviews, but never got an answer! > > Are all the dp/hdmi port register range really volatile!? > Sorry for incomplete response in last review comment reply. > With making only specific DMA registers and interrupts registers true, aplay > was stuck. > Now we identified issue causing register and made it volatile. > With that change it seems working fine. After doing all the tests we will > share v9 series patch. That sounds like the problem hasn't fully been understood yet and there might be more going on?
These patches are to support audio over DP port on Qualcomm's SC7180 LPASS Asoc. It includes machine driver, cpu driver, platform driver updates for HDMI path support, device tree documention, lpass variant structure optimization and configuration changes. These patches depends on the DP patch series https://patchwork.kernel.org/project/dri-devel/list/?series=332029 https://lore.kernel.org/patchwork/project/lkml/list/?series=464856 changes since V7: -- Fixed typo errors -- Separated buffer size change patche changes since V6: -- Removed compile time define flag, which used for enabling HDMI code, based on corresponding config param is included. -- Updated reg map alloc API with reg map bulk API. -- Removed unnecessary line splits changes since V5: -- Removed unused struct regmap *map in lpass_platform_alloc_hdmidmactl_fields. -- DMA alloc and free API signature change in lpass-apq8016.c, lpass-ipq806x.c -- Keeping API "irqreturn_t lpass_platform_hdmiif_irq" under ifdef macro Changes Since v4: -- Updated with single compatible node for both I2S and HDMI. Changes Since v3: -- Removed id in lpass variant structure and used snd_soc_dai_driver id. Changes Since v2: -- Audio buffer size(i.e. LPASS_PLATFORM_BUFFER_SIZE) in lpass-platform.c increased. Changes Since v1: -- Commit messages are updated -- Addressed Rob Herring review comments V Sujith Kumar Reddy (8): ASoC: Add sc7180-lpass binding header hdmi define ASoC: dt-bindings: Add dt binding for lpass hdmi Asoc:qcom:lpass-cpu:Update dts property read API Asoc: qcom: lpass:Update lpaif_dmactl members order ASoC: qcom: Add support for lpass hdmi driver Asoc: qcom: lpass-platform : Increase buffer size ASoC: qcom: sc7180: Add support for audio over DP .../devicetree/bindings/sound/qcom,lpass-cpu.yaml | 74 +++- include/dt-bindings/sound/sc7180-lpass.h | 1 + sound/soc/qcom/Kconfig | 5 + sound/soc/qcom/Makefile | 2 + sound/soc/qcom/lpass-apq8016.c | 4 +- sound/soc/qcom/lpass-cpu.c | 53 ++- sound/soc/qcom/lpass-hdmi.c | 470 +++++++++++++++++++++ sound/soc/qcom/lpass-hdmi.h | 122 ++++++ sound/soc/qcom/lpass-ipq806x.c | 4 +- sound/soc/qcom/lpass-lpaif-reg.h | 52 ++- sound/soc/qcom/lpass-platform.c | 403 ++++++++++++++---- sound/soc/qcom/lpass-sc7180.c | 116 ++++- sound/soc/qcom/lpass.h | 119 +++++- 13 files changed, 1280 insertions(+), 145 deletions(-) create mode 100644 sound/soc/qcom/lpass-hdmi.c create mode 100644 sound/soc/qcom/lpass-hdmi.h