From patchwork Fri Mar 14 15:42:56 2014 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Julien Grall X-Patchwork-Id: 26269 Return-Path: X-Original-To: linaro@patches.linaro.org Delivered-To: linaro@patches.linaro.org Received: from mail-pd0-f197.google.com (mail-pd0-f197.google.com [209.85.192.197]) by ip-10-151-82-157.ec2.internal (Postfix) with ESMTPS id 47E35202DD for ; Fri, 14 Mar 2014 15:45:28 +0000 (UTC) Received: by mail-pd0-f197.google.com with SMTP id fp1sf5978402pdb.8 for ; Fri, 14 Mar 2014 08:45:27 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:delivered-to:message-id:date:from:user-agent :mime-version:to:references:in-reply-to:cc:subject:precedence :list-id:list-unsubscribe:list-post:list-help:list-subscribe:sender :errors-to:x-original-sender:x-original-authentication-results :mailing-list:list-archive:content-type:content-transfer-encoding; bh=Z0G9/rCGOG31sv3/KjqF5cHXAfCNGS8x2EtkoQCIfaA=; b=ghdrx3XdDQuH4pGNPtw/mMvErKlyMWhS4ukTww5IIaGgC9vcQbzoVaLRsc04sRqSqk 9l+lIX3xH+/QLbhT/U2ysscdtJhkpFWXqLlV/+aYFR60hdhzrtNmlMMqsf4WG7OFlmKY MFUkh5sj7iZgBxW5riSXZ/aWXNmjTYAr70cskAZfxBLr7TM3hJQ5Ae6yy4FBo2/ht0iH J/YqPTShkEHZ99PYK+FyEB9phe6m1PNTMQmYH6nXP9t4dzo1U9W2G4kak/9IYcBS7bad YC+Zu4oFYx+As4KRXyIfeDidIDc5WtC1nIE5dzpscpr+Ti9Rux99gJG+wfPNuk0MK4wE 89YA== X-Gm-Message-State: ALoCoQkRt32+VRWKiPz3r284TppjjvByfdPT2mQ8vsoeH/r/AhEWmLMA+PM8JHm6OhOvEhYVdtJF X-Received: by 10.68.230.193 with SMTP id ta1mr3436433pbc.6.1394811927523; Fri, 14 Mar 2014 08:45:27 -0700 (PDT) X-BeenThere: patchwork-forward@linaro.org Received: by 10.140.47.50 with SMTP id l47ls716009qga.49.gmail; Fri, 14 Mar 2014 08:45:27 -0700 (PDT) X-Received: by 10.58.188.78 with SMTP id fy14mr1621569vec.23.1394811927379; Fri, 14 Mar 2014 08:45:27 -0700 (PDT) Received: from mail-vc0-f169.google.com (mail-vc0-f169.google.com [209.85.220.169]) by mx.google.com with ESMTPS id i3si2211706vcp.127.2014.03.14.08.45.27 for (version=TLSv1 cipher=ECDHE-RSA-RC4-SHA bits=128/128); Fri, 14 Mar 2014 08:45:27 -0700 (PDT) Received-SPF: neutral (google.com: 209.85.220.169 is neither permitted nor denied by best guess record for domain of patch+caf_=patchwork-forward=linaro.org@linaro.org) client-ip=209.85.220.169; Received: by mail-vc0-f169.google.com with SMTP id ik5so3006586vcb.28 for ; Fri, 14 Mar 2014 08:45:27 -0700 (PDT) X-Received: by 10.58.123.70 with SMTP id ly6mr1465603veb.26.1394811927267; Fri, 14 Mar 2014 08:45:27 -0700 (PDT) X-Forwarded-To: patchwork-forward@linaro.org X-Forwarded-For: patch@linaro.org patchwork-forward@linaro.org Delivered-To: patch@linaro.org Received: by 10.220.78.9 with SMTP id i9csp28608vck; Fri, 14 Mar 2014 08:45:24 -0700 (PDT) X-Received: by 10.224.99.3 with SMTP id s3mr10693610qan.84.1394811924332; Fri, 14 Mar 2014 08:45:24 -0700 (PDT) Received: from lists.xen.org (lists.xen.org. [50.57.142.19]) by mx.google.com with ESMTPS id gq5si1791527qab.147.2014.03.14.08.45.16 for (version=TLSv1 cipher=RC4-SHA bits=128/128); Fri, 14 Mar 2014 08:45:23 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of xen-devel-bounces@lists.xen.org designates 50.57.142.19 as permitted sender) client-ip=50.57.142.19; Received: from localhost ([127.0.0.1] helo=lists.xen.org) by lists.xen.org with esmtp (Exim 4.72) (envelope-from ) id 1WOUGD-0004ff-Oi; Fri, 14 Mar 2014 15:43:01 +0000 Received: from mail6.bemta5.messagelabs.com ([195.245.231.135]) by lists.xen.org with esmtp (Exim 4.72) (envelope-from ) id 1WOUGC-0004fD-Bz for xen-devel@lists.xenproject.org; Fri, 14 Mar 2014 15:43:00 +0000 Received: from [85.158.139.211:10601] by server-1.bemta-5.messagelabs.com id 86/28-10259-38323235; Fri, 14 Mar 2014 15:42:59 +0000 X-Env-Sender: julien.grall@linaro.org X-Msg-Ref: server-16.tower-206.messagelabs.com!1394811778!1095531!1 X-Originating-IP: [209.85.212.169] X-SpamReason: No, hits=0.0 required=7.0 tests= X-StarScan-Received: X-StarScan-Version: 6.11.1; banners=-,-,- X-VirusChecked: Checked Received: (qmail 6872 invoked from network); 14 Mar 2014 15:42:58 -0000 Received: from mail-wi0-f169.google.com (HELO mail-wi0-f169.google.com) (209.85.212.169) by server-16.tower-206.messagelabs.com with RC4-SHA encrypted SMTP; 14 Mar 2014 15:42:58 -0000 Received: by mail-wi0-f169.google.com with SMTP id bs8so641185wib.2 for ; Fri, 14 Mar 2014 08:42:58 -0700 (PDT) X-Received: by 10.180.99.225 with SMTP id et1mr6772435wib.13.1394811778172; Fri, 14 Mar 2014 08:42:58 -0700 (PDT) Received: from [10.80.2.139] ([185.25.64.249]) by mx.google.com with ESMTPSA id lz3sm17851542wic.1.2014.03.14.08.42.57 for (version=TLSv1 cipher=ECDHE-RSA-RC4-SHA bits=128/128); Fri, 14 Mar 2014 08:42:57 -0700 (PDT) Message-ID: <53232380.2010503@linaro.org> Date: Fri, 14 Mar 2014 15:42:56 +0000 From: Julien Grall User-Agent: Mozilla/5.0 (X11; Linux i686; rv:17.0) Gecko/20131104 Icedove/17.0.10 MIME-Version: 1.0 To: Ian Campbell References: <1394634891-27906-1-git-send-email-julien.grall@linaro.org> <1394808176.6442.96.camel@kazak.uk.xensource.com> In-Reply-To: <1394808176.6442.96.camel@kazak.uk.xensource.com> Cc: xen-devel@lists.xenproject.org, tim@xen.org, stefano.stabellini@citrix.com Subject: Re: [Xen-devel] [PATCH v3 0/5] xen/arm: Merge early_printk function in console code X-BeenThere: xen-devel@lists.xen.org X-Mailman-Version: 2.1.13 Precedence: list List-Id: List-Unsubscribe: , List-Post: , List-Help: , List-Subscribe: , Sender: xen-devel-bounces@lists.xen.org Errors-To: xen-devel-bounces@lists.xen.org X-Removed-Original-Auth: Dkim didn't pass. X-Original-Sender: julien.grall@linaro.org X-Original-Authentication-Results: mx.google.com; spf=neutral (google.com: 209.85.220.169 is neither permitted nor denied by best guess record for domain of patch+caf_=patchwork-forward=linaro.org@linaro.org) smtp.mail=patch+caf_=patchwork-forward=linaro.org@linaro.org Mailing-list: list patchwork-forward@linaro.org; contact patchwork-forward+owners@linaro.org X-Google-Group-Id: 836684582541 List-Archive: Hi Ian, On 03/14/2014 02:42 PM, Ian Campbell wrote: > On Wed, 2014-03-12 at 14:34 +0000, Julien Grall wrote: >> Hello all, >> >> This patch series aims to merge early printk in the console code. This will >> avoid the developper to care whether the message is printed before or after >> the console is initialized. >> >> Sincerely yours, >> >> Julien Grall (5): >> xen/arm: earlyprintk: move early_flush in early_puts >> xen/arm: earlyprintk: export early_puts >> xen/arm: Rename EARLY_PRINTK compile option to CONFIG_EARLY_PRINTK > > Something in these three (I think) causes: > In file included from device_tree.c:26:0: > /local/scratch/ianc/devel/committer.git/xen/include/asm/early_printk.h: In function ‘early_puts’: > /local/scratch/ianc/devel/committer.git/xen/include/asm/early_printk.h:35:1: error: parameter name omitted > make[4]: *** [device_tree.o] Error 1 > make[4]: *** Waiting for unfinished jobs.... Patch #2 is wrong, I forgot to give a name for the paremater of early_puts. The patch should be: diff --git a/xen/arch/arm/early_printk.c b/xen/arch/arm/early_printk.c index b59ea2e..6b90998 100644 --- a/xen/arch/arm/early_printk.c +++ b/xen/arch/arm/early_printk.c @@ -21,7 +21,7 @@ void early_flush(void); /* Early printk buffer */ static char __initdata buf[512]; -static void __init early_puts(const char *s) +void early_puts(const char *s) { while (*s != '\0') { if (*s == '\n') diff --git a/xen/include/asm-arm/early_printk.h b/xen/include/asm-arm/early_printk.h index 8047141..1b0fbdf 100644 --- a/xen/include/asm-arm/early_printk.h +++ b/xen/include/asm-arm/early_printk.h @@ -24,6 +24,7 @@ #ifdef EARLY_PRINTK +void early_puts(const char *s); void early_printk(const char *fmt, ...) __attribute__((format (printf, 1, 2))); void noreturn early_panic(const char *fmt, ...) @@ -31,6 +32,8 @@ void noreturn early_panic(const char *fmt, ...) #else +static inline void early_puts(const char *s) {} + static inline __attribute__((format (printf, 1, 2))) void early_printk(const char *fmt, ...) {}