From patchwork Fri Feb 23 18:57:26 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Julien Grall X-Patchwork-Id: 129479 Delivered-To: patch@linaro.org Received: by 10.80.172.228 with SMTP id x91csp984485edc; Fri, 23 Feb 2018 10:59:35 -0800 (PST) X-Google-Smtp-Source: AG47ELs6czOcWPqgfD5S+FLskqmPZcRvDCA1qrEYtI10qyYlMtUV30VbK3Tr5M8vIG0Rny11QlHt X-Received: by 10.36.46.23 with SMTP id i23mr3599282ita.55.1519412374911; Fri, 23 Feb 2018 10:59:34 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1519412374; cv=none; d=google.com; s=arc-20160816; b=XWDR+og95Qlf0B0dmBpRRXZnSH3RsnwdltcOXfZz2GS6TgHWoaLZwMGZNCCtO0B2Ts zuSiRfVMARtroNfhjwMMKvn49l7qH9d9rdaJW2VXZ4K9tiy9Co0cna5C7pKVFjICAA0D QKu0Olw+9bb/ihwfI3RYTV8EBBUVIO37IwXwaTixV0xImnEIKBqhnYowERiT/QMb3hP0 AuhxVxLg1aAk4tClL0LAkx+9n2n2+qzJQ1L3PGkph0E8rIGxOlZZ5zD1lnPyDcaisPY7 64J853dijtIQXF52iwKo6mm4XpLe0CMq+acTBEjpR10QSt9WfUfpKEqNwmh/F4jEP513 RVtg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=sender:errors-to:content-transfer-encoding:mime-version :list-subscribe:list-help:list-post:list-unsubscribe:list-id :precedence:subject:cc:references:in-reply-to:message-id:date:to :from:arc-authentication-results; bh=ZsbEhlhant75qlby0uTebfG3IW9pTKqfMcrD0lxixYQ=; b=xUHK3ESTtCIR7vSHDHJVre1kXnLCG0uAUknbB3NpKFeh0g9Adup4ktHK+yezNd62qV EwePMonqTfZqtejp9smUg9pYK2bqblFcSuaTcF/NJeSYeeRcjYjvCIiDnrwsYuPYn/bh jahltMrxqjrrPYcwyW776UDyKA2knu6cRf4li3lNc8XHnvc2wRRrU8sAAnRuu89BHoDx cxIGt/g8lHLTZKqWYiJ8vdV41i0nZreTSNCEH2Zp4nwlyLLL5qUsJ1mx36k4d/orM5FA ASN/ZxkZv5VXbHhgAhoc29G7uYvESxbo/a++CSFwHMd6USMttyPx+Cmjctrz7iUfPO9K FxYg== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of xen-devel-bounces@lists.xenproject.org designates 192.237.175.120 as permitted sender) smtp.mailfrom=xen-devel-bounces@lists.xenproject.org Return-Path: Received: from lists.xenproject.org (lists.xenproject.org. [192.237.175.120]) by mx.google.com with ESMTPS id z190si2012916ioz.133.2018.02.23.10.59.34 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Fri, 23 Feb 2018 10:59:34 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of xen-devel-bounces@lists.xenproject.org designates 192.237.175.120 as permitted sender) client-ip=192.237.175.120; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of xen-devel-bounces@lists.xenproject.org designates 192.237.175.120 as permitted sender) smtp.mailfrom=xen-devel-bounces@lists.xenproject.org Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.84_2) (envelope-from ) id 1epIXl-0003Gw-JN; Fri, 23 Feb 2018 18:58:05 +0000 Received: from all-amaz-eas1.inumbo.com ([34.197.232.57]) by lists.xenproject.org with esmtp (Exim 4.84_2) (envelope-from ) id 1epIXk-000376-Da for xen-devel@lists.xen.org; Fri, 23 Feb 2018 18:58:04 +0000 X-Inumbo-ID: b4042ee4-18cb-11e8-b9b1-635ca7ef6cff Received: from foss.arm.com (unknown [217.140.101.70]) by us1-amaz-eas1.inumbo.com (Halon) with ESMTP id b4042ee4-18cb-11e8-b9b1-635ca7ef6cff; Fri, 23 Feb 2018 18:59:41 +0000 (UTC) Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.72.51.249]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id CAAF715BE; Fri, 23 Feb 2018 10:57:57 -0800 (PST) Received: from e108454-lin.cambridge.arm.com (e108454-lin.cambridge.arm.com [10.1.206.53]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id BB7DA3F25C; Fri, 23 Feb 2018 10:57:56 -0800 (PST) From: Julien Grall To: xen-devel@lists.xen.org Date: Fri, 23 Feb 2018 18:57:26 +0000 Message-Id: <20180223185729.8780-16-julien.grall@arm.com> X-Mailer: git-send-email 2.11.0 In-Reply-To: <20180223185729.8780-1-julien.grall@arm.com> References: <20180223185729.8780-1-julien.grall@arm.com> Cc: Julien Grall , sstabellini@kernel.org, volodymyr_babchuk@epam.com, andre.przywara@linaro.org Subject: [Xen-devel] [PATCH v5 15/18] xen/arm: psci: Prefix with static any functions not exported X-BeenThere: xen-devel@lists.xenproject.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , MIME-Version: 1.0 Errors-To: xen-devel-bounces@lists.xenproject.org Sender: "Xen-devel" A bunch of PSCI functions are not prefixed with static despite no one is using them outside the file and the prototype is not available in psci.h. Signed-off-by: Julien Grall Reviewed-by: Volodymyr Babchuk Acked-by: Stefano Stabellini --- Changes in v4: - Add Stefano's acked-by Changes in v2: - Patch added --- xen/arch/arm/psci.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/xen/arch/arm/psci.c b/xen/arch/arm/psci.c index 6e6980bfe2..94b616df9b 100644 --- a/xen/arch/arm/psci.c +++ b/xen/arch/arm/psci.c @@ -66,7 +66,7 @@ static int __init psci_features(uint32_t psci_func_id) return call_smc(PSCI_1_0_FN32_PSCI_FEATURES, psci_func_id, 0, 0); } -int __init psci_is_smc_method(const struct dt_device_node *psci) +static int __init psci_is_smc_method(const struct dt_device_node *psci) { int ret; const char *prop_str; @@ -109,7 +109,7 @@ static void __init psci_init_smccc(void) SMCCC_VERSION_MAJOR(smccc_ver), SMCCC_VERSION_MINOR(smccc_ver)); } -int __init psci_init_0_1(void) +static int __init psci_init_0_1(void) { int ret; const struct dt_device_node *psci; @@ -139,7 +139,7 @@ int __init psci_init_0_1(void) return 0; } -int __init psci_init_0_2(void) +static int __init psci_init_0_2(void) { static const struct dt_device_match psci_ids[] __initconst = {