From patchwork Fri Feb 23 16:47:50 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Julien Grall X-Patchwork-Id: 129468 Delivered-To: patch@linaro.org Received: by 10.46.66.2 with SMTP id p2csp814136lja; Fri, 23 Feb 2018 08:50:20 -0800 (PST) X-Google-Smtp-Source: AG47ELvcyqKapjnxT75epVvFNJkFGAYL2+tC4m+/SJCrRwaov5U+R5CbX10JwfQI+/hMdjVVkx8U X-Received: by 10.107.202.67 with SMTP id a64mr2563693iog.194.1519404620700; Fri, 23 Feb 2018 08:50:20 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1519404620; cv=none; d=google.com; s=arc-20160816; b=YlipOHYv0mViWHNdZOwA49Dc9/Y8mp/HalOGXwkccFFp4vDukqI66pDHYd6BTIW37x w8SDa2tqdrJmih4mh/ZfG05DWQkI7UQDx1zloOrr7aEgZbPGD+NVHoX+Sp2Pi56ZOtSS YZTKxSeqlBFHBJeAsiwtpOLvggTO2MlHofwiDDSl5qRLr9y6Fb8dad9McleqWk4nuqKr GMoLSu2c7RVCseMrg5g+ix3p9mW9kpdhXhYHL8GRNVN30e3Okppx7azzV3gcuUUu0nmZ 97+7/SVqT5YKB0+YDwS7aza95ru6/mlzpPLPqy00iSQlAYlHdld5706SV+lIyXMJiENX mMFg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=sender:errors-to:content-transfer-encoding:mime-version :list-subscribe:list-help:list-post:list-unsubscribe:list-id :precedence:subject:cc:references:in-reply-to:message-id:date:to :from:arc-authentication-results; bh=ZsbEhlhant75qlby0uTebfG3IW9pTKqfMcrD0lxixYQ=; b=mxBTTt6sqdMbIJ31+XYdxzpa+5szIeK4VAQt+Km73UJ+Yij+YtQW2iBYCxC84t7X4i 1NHAYktMXCsgL49YbvGr3QGqKr2cLXxMr+evCla7LZgsv17PeyxIgZ3XPANvZNpYaeeC C2oFhDwIlSM8OHcrYyQX8JD4+K/7oFg6nmwTKM0RqpgQi+9ALJkbh8V5UzYo6os3+30j W42jD7MlStw0JkzfF7/Yr4CJADI8dZ5+AaIGS80YKM8Z9L1OTxEz2S4NyaC9EpTPL7fg YAZ2ldUMz91JmUuk2NYESNEEPSAp4UJRpGvhPV04MbUXpLejjnL66nFNYzmrvVRjebhI CmVg== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of xen-devel-bounces@lists.xenproject.org designates 192.237.175.120 as permitted sender) smtp.mailfrom=xen-devel-bounces@lists.xenproject.org Return-Path: Received: from lists.xenproject.org (lists.xenproject.org. [192.237.175.120]) by mx.google.com with ESMTPS id o194si1384264ita.124.2018.02.23.08.50.20 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Fri, 23 Feb 2018 08:50:20 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of xen-devel-bounces@lists.xenproject.org designates 192.237.175.120 as permitted sender) client-ip=192.237.175.120; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of xen-devel-bounces@lists.xenproject.org designates 192.237.175.120 as permitted sender) smtp.mailfrom=xen-devel-bounces@lists.xenproject.org Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.84_2) (envelope-from ) id 1epGWQ-0003nM-Cd; Fri, 23 Feb 2018 16:48:34 +0000 Received: from all-amaz-eas1.inumbo.com ([34.197.232.57]) by lists.xenproject.org with esmtp (Exim 4.84_2) (envelope-from ) id 1epGWP-0003gz-Ry for xen-devel@lists.xen.org; Fri, 23 Feb 2018 16:48:33 +0000 X-Inumbo-ID: 9c685f92-18b9-11e8-b9b1-635ca7ef6cff Received: from foss.arm.com (unknown [217.140.101.70]) by us1-amaz-eas1.inumbo.com (Halon) with ESMTP id 9c685f92-18b9-11e8-b9b1-635ca7ef6cff; Fri, 23 Feb 2018 16:50:10 +0000 (UTC) Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.72.51.249]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 8A48015BE; Fri, 23 Feb 2018 08:48:27 -0800 (PST) Received: from e108454-lin.cambridge.arm.com (e108454-lin.cambridge.arm.com [10.1.206.53]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 7AA153F25C; Fri, 23 Feb 2018 08:48:26 -0800 (PST) From: Julien Grall To: xen-devel@lists.xen.org Date: Fri, 23 Feb 2018 16:47:50 +0000 Message-Id: <20180223164753.27311-17-julien.grall@arm.com> X-Mailer: git-send-email 2.11.0 In-Reply-To: <20180223164753.27311-1-julien.grall@arm.com> References: <20180223164753.27311-1-julien.grall@arm.com> Cc: Julien Grall , sstabellini@kernel.org, volodymyr_babchuk@epam.com, andre.przywara@linaro.org Subject: [Xen-devel] [PATCH v4 16/19] xen/arm: psci: Prefix with static any functions not exported X-BeenThere: xen-devel@lists.xenproject.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , MIME-Version: 1.0 Errors-To: xen-devel-bounces@lists.xenproject.org Sender: "Xen-devel" A bunch of PSCI functions are not prefixed with static despite no one is using them outside the file and the prototype is not available in psci.h. Signed-off-by: Julien Grall Reviewed-by: Volodymyr Babchuk Acked-by: Stefano Stabellini --- Changes in v4: - Add Stefano's acked-by Changes in v2: - Patch added --- xen/arch/arm/psci.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/xen/arch/arm/psci.c b/xen/arch/arm/psci.c index 6e6980bfe2..94b616df9b 100644 --- a/xen/arch/arm/psci.c +++ b/xen/arch/arm/psci.c @@ -66,7 +66,7 @@ static int __init psci_features(uint32_t psci_func_id) return call_smc(PSCI_1_0_FN32_PSCI_FEATURES, psci_func_id, 0, 0); } -int __init psci_is_smc_method(const struct dt_device_node *psci) +static int __init psci_is_smc_method(const struct dt_device_node *psci) { int ret; const char *prop_str; @@ -109,7 +109,7 @@ static void __init psci_init_smccc(void) SMCCC_VERSION_MAJOR(smccc_ver), SMCCC_VERSION_MINOR(smccc_ver)); } -int __init psci_init_0_1(void) +static int __init psci_init_0_1(void) { int ret; const struct dt_device_node *psci; @@ -139,7 +139,7 @@ int __init psci_init_0_1(void) return 0; } -int __init psci_init_0_2(void) +static int __init psci_init_0_2(void) { static const struct dt_device_match psci_ids[] __initconst = {