From patchwork Wed Jul 26 17:17:06 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Julien Grall X-Patchwork-Id: 108783 Delivered-To: patch@linaro.org Received: by 10.140.101.44 with SMTP id t41csp1051481qge; Wed, 26 Jul 2017 10:19:10 -0700 (PDT) X-Received: by 10.107.13.130 with SMTP id 124mr1811218ion.40.1501089550134; Wed, 26 Jul 2017 10:19:10 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1501089550; cv=none; d=google.com; s=arc-20160816; b=AaYkCd47lKSjSjxywGYWn+vLT7cCPSoEKyLDzLVD16otG7mleZ3WWUZ9CJxDpZVyTB Aag80NHRAJqqw+zpcP9XLroDQzCm2v1ys3jPnAmZySLMk4rl6vM/OZ1ZteZZV+vHD9GU OKlJxDMb+zNtn1EvEgCubolaFL39hLspdJY7bc1Dt25bCCB9Ihfm8IcQUum/FfPgv51f 1XeSWiPtELtkcEfWkKK9TgQRf+8KKO+DAtHQtPKUXlZ0gCk1+cBnf/zqSqF/ZA38aQ7z zPhXl/i7nowDfaAjC88cl1IpBmJHJ/nrR0YwjK61bEF6BbVzrMqTWSLSDDKg5fnl1Fs+ b3aA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=sender:errors-to:content-transfer-encoding:mime-version :list-subscribe:list-help:list-post:list-unsubscribe:list-id :precedence:subject:cc:message-id:date:to:from :arc-authentication-results; bh=JR/B1Vx35W36nWaS2kR2Q4XjNUp2ZNXMklzfkh6L6bY=; b=q/gBZ3Y57l/3X/flvP2dLp/s4+vCHoX2P8CrJ/5oAQ4/+u61/GYxaW5o/vxQL8bTaY 4HPQgT2YwF36IfwI3S4Uzv26je+1RTyQInM/yJaRDUAVAlHmUs589GKvNv4o82Pp+w/E y41EiP+FQuY1sRPLF0o3H4Y+0HRdhZiYS9WdcBF08EZr+V4l5XtQixdyRPj0WZJl5vbx CeYA6ohf27pl6Spbhe7DzMZsvwh6UYN5348b+EMZwZxy9mDfM3IuFkKFiQTNkZrHMzOw ctDeMC/SlmOwb2XnrwAqqTn5cfTH4q2UK3LpeTxfFdUoYoAtyhCTU+A5UvVD1m2i/+6w MQkQ== ARC-Authentication-Results: i=1; mx.google.com; spf=neutral (google.com: 192.237.175.120 is neither permitted nor denied by best guess record for domain of xen-devel-bounces@lists.xen.org) smtp.mailfrom=xen-devel-bounces@lists.xen.org Return-Path: Received: from lists.xenproject.org (lists.xenproject.org. [192.237.175.120]) by mx.google.com with ESMTPS id b86si5011751ioj.93.2017.07.26.10.19.09 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Wed, 26 Jul 2017 10:19:10 -0700 (PDT) Received-SPF: neutral (google.com: 192.237.175.120 is neither permitted nor denied by best guess record for domain of xen-devel-bounces@lists.xen.org) client-ip=192.237.175.120; Authentication-Results: mx.google.com; spf=neutral (google.com: 192.237.175.120 is neither permitted nor denied by best guess record for domain of xen-devel-bounces@lists.xen.org) smtp.mailfrom=xen-devel-bounces@lists.xen.org Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.84_2) (envelope-from ) id 1daPvx-0005L3-TH; Wed, 26 Jul 2017 17:17:17 +0000 Received: from mail6.bemta3.messagelabs.com ([195.245.230.39]) by lists.xenproject.org with esmtp (Exim 4.84_2) (envelope-from ) id 1daPvx-0005Kx-Kz for xen-devel@lists.xen.org; Wed, 26 Jul 2017 17:17:17 +0000 Received: from [85.158.137.68] by server-11.bemta-3.messagelabs.com id 42/FE-01724-C9EC8795; Wed, 26 Jul 2017 17:17:16 +0000 X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFjrNLMWRWlGSWpSXmKPExsVysyfVTXfOuYp Ig19nOSyWfFzM4sDocXT3b6YAxijWzLyk/IoE1oz57auYCv4JV6x63cbewHifv4uRk0NIYCOj RM/J5C5GLiD7NKPEpalfWEESbAKaEnc+f2ICsUUEpCWufb7MCFLELPCcUWJSywywImGBSIkZ0 5czgtgsAqoS2x80s4PYvAIWEsdaXrCA2BIC8hK72i6yTmDkXMDIsIpRozi1qCy1SNfIQi+pKD M9oyQ3MTNH19DAWC83tbg4MT01JzGpWC85P3cTI9Bj9QwMjDsY20/4HWKU5GBSEuWdZFoRKcS XlJ9SmZFYnBFfVJqTWnyIUYaDQ0mCN+UsUE6wKDU9tSItMwcYOjBpCQ4eJRHex2eA0rzFBYm5 xZnpEKlTjLocryb8/8YkxJKXn5cqJc57BmSGAEhRRmke3AhYGF9ilJUS5mVkYGAQ4ilILcrNL EGVf8UozsGoJMx7HmQKT2ZeCdymV0BHMAEdMWdGKcgRJYkIKakGRv3XZ1R7atM/eDRMdjxmrF zT9LSiaFH2Kocfzunh92NqQi5sNHYzrS/TO5LcceSeYdXegP/ik6VEfzRzP9jL4/a6amtgzge lOhPpL+J3fz3pff3LwV7MSfaV9cvfjHadM/d+7FA82/f5YIMr0/oD+R8fOi5eUc3M8sFejuV/ ZjZTCkecoSufEktxRqKhFnNRcSIA0GhSSl4CAAA= X-Env-Sender: julien.grall@arm.com X-Msg-Ref: server-11.tower-31.messagelabs.com!1501089435!76376108!1 X-Originating-IP: [217.140.101.70] X-SpamReason: No, hits=0.0 required=7.0 tests= X-StarScan-Received: X-StarScan-Version: 9.4.25; banners=-,-,- X-VirusChecked: Checked Received: (qmail 57635 invoked from network); 26 Jul 2017 17:17:15 -0000 Received: from usa-sjc-mx-foss1.foss.arm.com (HELO foss.arm.com) (217.140.101.70) by server-11.tower-31.messagelabs.com with SMTP; 26 Jul 2017 17:17:15 -0000 Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.72.51.249]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 26D782B; Wed, 26 Jul 2017 10:17:15 -0700 (PDT) Received: from e108454-lin.cambridge.arm.com (e108454-lin.cambridge.arm.com [10.1.206.53]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 7DB323F540; Wed, 26 Jul 2017 10:17:13 -0700 (PDT) From: Julien Grall To: xen-devel@lists.xen.org Date: Wed, 26 Jul 2017 18:17:06 +0100 Message-Id: <20170726171706.6428-1-julien.grall@arm.com> X-Mailer: git-send-email 2.11.0 Cc: sstabellini@kernel.org, wei.liu2@citrix.com, George.Dunlap@eu.citrix.com, andrew.cooper3@citrix.com, ian.jackson@eu.citrix.com, tim@xen.org, Julien Grall , jbeulich@suse.com Subject: [Xen-devel] [PATCH v2] scripts/get_maintainers.pl: Don't blindly drop "THE REST" maintainers X-BeenThere: xen-devel@lists.xen.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , MIME-Version: 1.0 Errors-To: xen-devel-bounces@lists.xen.org Sender: "Xen-devel" "THE REST" maintainers should always be CCed for any modification that don't fall under the responsability of a specific component maintainer. However, the script get_maintainers.pl will remove "THE REST" maintainers as soon as one maintainer of a specific component will be present. Fix the script once for all. Signed-off-by: Julien Grall Acked-by: Wei Liu --- I am getting annoyed at requesting contributors to CC "THE REST" because the script didn't properly return the list of maintainers. This should now be fixed. I didn't keep the acked because of the inversion of the logic. Changes in v2: - inverse the logic of the new variable and rename it to suppress_the_rest --- scripts/get_maintainer.pl | 18 +++++++++++++++++- 1 file changed, 17 insertions(+), 1 deletion(-) diff --git a/scripts/get_maintainer.pl b/scripts/get_maintainer.pl index 2804a5b5df..0ce2d367fa 100755 --- a/scripts/get_maintainer.pl +++ b/scripts/get_maintainer.pl @@ -571,11 +571,15 @@ sub get_maintainers { # Find responsible parties my %exact_pattern_match_hash = (); + # By default "THE REST" will be suppressed. + my $suppress_the_rest = 1; foreach my $file (@files) { my %hash; my $tvi = find_first_section(); + # Unless stated otherwise, a file is maintained by "THE REST" + my $file_maintained_by_the_rest = 1; while ($tvi < @typevalue) { my $start = find_starting_index($tvi); my $end = find_ending_index($tvi); @@ -633,6 +637,14 @@ sub get_maintainers { foreach my $line (sort {$hash{$b} <=> $hash{$a}} keys %hash) { add_categories($line); + my $role = get_maintainer_role($line); + + # Check the role, if it is not "THE REST" then the file is not + # only maintained by "THE REST". + if ( get_maintainer_role($line) ne "supporter:THE REST" ) { + $file_maintained_by_the_rest = 0; + } + if ($sections) { my $i; my $start = find_starting_index($line); @@ -657,6 +669,9 @@ sub get_maintainers { print("\n"); } } + # If the file is only maintained by "THE REST", then CC all of them on + # the patch. + $suppress_the_rest = 0 if $file_maintained_by_the_rest; } if ($keywords) { @@ -666,7 +681,8 @@ sub get_maintainers { } } - if ($email_drop_the_rest_supporter_if_supporter_found && $#email_to > 0) { + if ($email_drop_the_rest_supporter_if_supporter_found && + $suppress_the_rest && $#email_to > 0) { my @email_new; my $do_replace = 0; foreach my $email (@email_to) {