From patchwork Tue Nov 10 07:55:50 2015 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Shannon Zhao X-Patchwork-Id: 56291 Delivered-To: patch@linaro.org Received: by 10.112.155.196 with SMTP id vy4csp622254lbb; Mon, 9 Nov 2015 23:58:14 -0800 (PST) X-Received: by 10.28.55.212 with SMTP id e203mr32257292wma.7.1447142294232; Mon, 09 Nov 2015 23:58:14 -0800 (PST) Return-Path: Received: from lists.xen.org ([50.57.142.19]) by mx.google.com with ESMTPS id n6si22087676wmg.50.2015.11.09.23.58.13 (version=TLSv1 cipher=RC4-SHA bits=128/128); Mon, 09 Nov 2015 23:58:14 -0800 (PST) Received-SPF: neutral (google.com: 50.57.142.19 is neither permitted nor denied by best guess record for domain of xen-devel-bounces@lists.xen.org) client-ip=50.57.142.19; Authentication-Results: mx.google.com; spf=neutral (google.com: 50.57.142.19 is neither permitted nor denied by best guess record for domain of xen-devel-bounces@lists.xen.org) smtp.mailfrom=xen-devel-bounces@lists.xen.org Received: from localhost ([127.0.0.1] helo=lists.xen.org) by lists.xen.org with esmtp (Exim 4.72) (envelope-from ) id 1Zw3n5-0006J9-GJ; Tue, 10 Nov 2015 07:56:31 +0000 Received: from mail6.bemta3.messagelabs.com ([195.245.230.39]) by lists.xen.org with esmtp (Exim 4.72) (envelope-from ) id 1Zw3n4-0006Iz-Oo for xen-devel@lists.xen.org; Tue, 10 Nov 2015 07:56:30 +0000 Received: from [85.158.137.68] by server-6.bemta-3.messagelabs.com id BA/C4-29649-D23A1465; Tue, 10 Nov 2015 07:56:29 +0000 X-Env-Sender: zhaoshenglong@huawei.com X-Msg-Ref: server-13.tower-31.messagelabs.com!1447142181!1733069!1 X-Originating-IP: [119.145.14.66] X-SpamReason: No, hits=0.0 required=7.0 tests=sa_preprocessor: VHJ1c3RlZCBJUDogMTE5LjE0NS4xNC42NiA9PiA4NTI3\n X-StarScan-Received: X-StarScan-Version: 7.19.2; banners=-,-,- X-VirusChecked: Checked Received: (qmail 25894 invoked from network); 10 Nov 2015 07:56:26 -0000 Received: from szxga03-in.huawei.com (HELO szxga03-in.huawei.com) (119.145.14.66) by server-13.tower-31.messagelabs.com with RC4-SHA encrypted SMTP; 10 Nov 2015 07:56:26 -0000 Received: from 172.24.1.50 (EHLO szxeml422-hub.china.huawei.com) ([172.24.1.50]) by szxrg03-dlp.huawei.com (MOS 4.4.3-GA FastPath queued) with ESMTP id BQT03337; Tue, 10 Nov 2015 15:56:10 +0800 (CST) Received: from HGHY1Z002260041.china.huawei.com (10.177.16.142) by szxeml422-hub.china.huawei.com (10.82.67.152) with Microsoft SMTP Server id 14.3.235.1; Tue, 10 Nov 2015 15:56:01 +0800 From: Shannon Zhao To: , Date: Tue, 10 Nov 2015 15:55:50 +0800 Message-ID: <1447142150-2376-1-git-send-email-zhaoshenglong@huawei.com> X-Mailer: git-send-email 1.9.0.msysgit.0 MIME-Version: 1.0 X-Originating-IP: [10.177.16.142] X-CFilter-Loop: Reflected X-Mirapoint-Virus-RAPID-Raw: score=unknown(0), refid=str=0001.0A0B0205.5641A31C.01C7, ss=1, re=0.000, recu=0.000, reip=0.000, cl=1, cld=1, fgs=0, ip=0.0.0.0, so=2013-05-26 15:14:31, dmn=2013-03-21 17:37:32 X-Mirapoint-Loop-Id: 8babed6aaea8f8394d27fc75711fc0f0 Cc: shannon.zhao@linaro.org Subject: [Xen-devel] [PATCH] efi: Fix booting failure with UEFI on ARM X-BeenThere: xen-devel@lists.xen.org X-Mailman-Version: 2.1.13 Precedence: list List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xen.org Errors-To: xen-devel-bounces@lists.xen.org From: Shannon Zhao Commit 9fd08b4 (efi: split out efi_get_gop()) splits out the codes getting the pointer to GOP as efi_get_gop(), but it doesn't initialize the variable handles and gop to NULL like what the original codes do. This will cause booting failure on ARM while printing below logs: Xen 4.7-unstable (c/s Tue Oct 13 14:40:28 2015 +0100 git:7a92036) EFI loader Synchronous Exception at 0x00000000FECB021C Signed-off-by: Shannon Zhao --- xen/common/efi/boot.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) -- 2.0.4 _______________________________________________ Xen-devel mailing list Xen-devel@lists.xen.org http://lists.xen.org/xen-devel diff --git a/xen/common/efi/boot.c b/xen/common/efi/boot.c index 29ce66a..d233cef 100644 --- a/xen/common/efi/boot.c +++ b/xen/common/efi/boot.c @@ -636,8 +636,8 @@ static void __init efi_console_set_mode(void) static EFI_GRAPHICS_OUTPUT_PROTOCOL __init *efi_get_gop(void) { EFI_GRAPHICS_OUTPUT_MODE_INFORMATION *mode_info; - EFI_GRAPHICS_OUTPUT_PROTOCOL *gop; - EFI_HANDLE *handles; + EFI_GRAPHICS_OUTPUT_PROTOCOL *gop = NULL; + EFI_HANDLE *handles = NULL; EFI_STATUS status; UINTN info_size, size = 0; static EFI_GUID __initdata gop_guid = EFI_GRAPHICS_OUTPUT_PROTOCOL_GUID;