From patchwork Mon Feb 16 14:50:55 2015 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Julien Grall X-Patchwork-Id: 44718 Return-Path: X-Original-To: linaro@patches.linaro.org Delivered-To: linaro@patches.linaro.org Received: from mail-ee0-f70.google.com (mail-ee0-f70.google.com [74.125.83.70]) by ip-10-151-82-157.ec2.internal (Postfix) with ESMTPS id 67ED321544 for ; Mon, 16 Feb 2015 14:54:00 +0000 (UTC) Received: by mail-ee0-f70.google.com with SMTP id c41sf11888527eek.1 for ; Mon, 16 Feb 2015 06:53:59 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:delivered-to:from:to:date:message-id:in-reply-to :references:cc:subject:precedence:list-id:list-unsubscribe:list-post :list-help:list-subscribe:mime-version:content-type :content-transfer-encoding:sender:errors-to:x-original-sender :x-original-authentication-results:mailing-list:list-archive; bh=7JfemXafE1CiJDF9GdfVpr0i4OjjWgkrJXaCnLsDXeM=; b=hNZb9QcXfFShooc19q0ARSuAkCsIycqOVE3urR7rSrTrEfyuyEqeJO7fdVvNcdePhc QEVyRi0SD3s4E2Xka6hmxi02H+SVpQPnNdtF25sNAs3AiXoobRs5ct1o0hfeKj3Oj4B+ UGrSRW3ZhRb+YfYJPVpjH3b0hC2XHSvVJE9xfi0iSzlUrOKDJaOny+XG69YnLHyb3vnM VVxohFyUK7CB4tDYJxxft0gO8LDYYiEGXYpj4h6B0xyCCgyNcHBzQ4DdAdZjTw1Bt48p pEHynFIB0E2BkHqV9a1s/E7tUWCBSPHx48/xL4/a2qUMRF+1Xt1b3K7BBPSiwSGawAVr Zxcw== X-Gm-Message-State: ALoCoQlhU0SPzUtLBvIUYjPYcOLDe02CK9irX6L5KnB7hCxCcbosKFUxnVMHxAe1BI6df/O6bepy X-Received: by 10.112.171.37 with SMTP id ar5mr3028726lbc.16.1424098439465; Mon, 16 Feb 2015 06:53:59 -0800 (PST) X-BeenThere: patchwork-forward@linaro.org Received: by 10.152.5.9 with SMTP id o9ls566251lao.83.gmail; Mon, 16 Feb 2015 06:53:59 -0800 (PST) X-Received: by 10.152.22.129 with SMTP id d1mr22631686laf.22.1424098439322; Mon, 16 Feb 2015 06:53:59 -0800 (PST) Received: from mail-la0-f44.google.com (mail-la0-f44.google.com. [209.85.215.44]) by mx.google.com with ESMTPS id w8si9802581laj.145.2015.02.16.06.53.59 for (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Mon, 16 Feb 2015 06:53:59 -0800 (PST) Received-SPF: pass (google.com: domain of patch+caf_=patchwork-forward=linaro.org@linaro.org designates 209.85.215.44 as permitted sender) client-ip=209.85.215.44; Received: by labgq15 with SMTP id gq15so29439150lab.3 for ; Mon, 16 Feb 2015 06:53:59 -0800 (PST) X-Received: by 10.152.8.33 with SMTP id o1mr23520097laa.56.1424098439236; Mon, 16 Feb 2015 06:53:59 -0800 (PST) X-Forwarded-To: patchwork-forward@linaro.org X-Forwarded-For: patch@linaro.org patchwork-forward@linaro.org Delivered-To: patch@linaro.org Received: by 10.112.35.133 with SMTP id h5csp1630090lbj; Mon, 16 Feb 2015 06:53:58 -0800 (PST) X-Received: by 10.140.236.84 with SMTP id h81mr1296928qhc.35.1424098437918; Mon, 16 Feb 2015 06:53:57 -0800 (PST) Received: from lists.xen.org (lists.xen.org. [50.57.142.19]) by mx.google.com with ESMTPS id q130si5985016qha.79.2015.02.16.06.53.56 (version=TLSv1 cipher=RC4-SHA bits=128/128); Mon, 16 Feb 2015 06:53:57 -0800 (PST) Received-SPF: none (google.com: xen-devel-bounces@lists.xen.org does not designate permitted sender hosts) client-ip=50.57.142.19; Received: from localhost ([127.0.0.1] helo=lists.xen.org) by lists.xen.org with esmtp (Exim 4.72) (envelope-from ) id 1YNN1b-0001vw-I6; Mon, 16 Feb 2015 14:51:51 +0000 Received: from mail6.bemta5.messagelabs.com ([195.245.231.135]) by lists.xen.org with esmtp (Exim 4.72) (envelope-from ) id 1YNN1Z-0001sX-JN for xen-devel@lists.xenproject.org; Mon, 16 Feb 2015 14:51:49 +0000 Received: from [85.158.139.211] by server-17.bemta-5.messagelabs.com id EE/3C-03132-40402E45; Mon, 16 Feb 2015 14:51:48 +0000 X-Env-Sender: julien.grall@linaro.org X-Msg-Ref: server-8.tower-206.messagelabs.com!1424098308!12175208!1 X-Originating-IP: [209.85.212.169] X-SpamReason: No, hits=0.0 required=7.0 tests= X-StarScan-Received: X-StarScan-Version: 6.13.4; banners=-,-,- X-VirusChecked: Checked Received: (qmail 12340 invoked from network); 16 Feb 2015 14:51:48 -0000 Received: from mail-wi0-f169.google.com (HELO mail-wi0-f169.google.com) (209.85.212.169) by server-8.tower-206.messagelabs.com with RC4-SHA encrypted SMTP; 16 Feb 2015 14:51:48 -0000 Received: by mail-wi0-f169.google.com with SMTP id em10so25720365wid.0 for ; Mon, 16 Feb 2015 06:51:48 -0800 (PST) X-Received: by 10.194.243.1 with SMTP id wu1mr52011329wjc.69.1424098306603; Mon, 16 Feb 2015 06:51:46 -0800 (PST) Received: from chilopoda.uk.xensource.com. ([185.25.64.249]) by mx.google.com with ESMTPSA id dj5sm23172398wjb.28.2015.02.16.06.51.45 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-SHA bits=128/128); Mon, 16 Feb 2015 06:51:45 -0800 (PST) From: Julien Grall To: xen-devel@lists.xenproject.org Date: Mon, 16 Feb 2015 14:50:55 +0000 Message-Id: <1424098255-22490-16-git-send-email-julien.grall@linaro.org> X-Mailer: git-send-email 2.1.4 In-Reply-To: <1424098255-22490-1-git-send-email-julien.grall@linaro.org> References: <1424098255-22490-1-git-send-email-julien.grall@linaro.org> Cc: stefano.stabellini@citrix.com, Vijaya.Kumar@caviumnetworks.com, Julien Grall , tim@xen.org, ian.campbell@citrix.com Subject: [Xen-devel] [PATCH v3 15/15] xen/arm: gic-v3: Update some comments in the code X-BeenThere: xen-devel@lists.xen.org X-Mailman-Version: 2.1.13 Precedence: list List-Id: List-Unsubscribe: , List-Post: , List-Help: , List-Subscribe: , MIME-Version: 1.0 Sender: xen-devel-bounces@lists.xen.org Errors-To: xen-devel-bounces@lists.xen.org X-Removed-Original-Auth: Dkim didn't pass. X-Original-Sender: julien.grall@linaro.org X-Original-Authentication-Results: mx.google.com; spf=pass (google.com: domain of patch+caf_=patchwork-forward=linaro.org@linaro.org designates 209.85.215.44 as permitted sender) smtp.mail=patch+caf_=patchwork-forward=linaro.org@linaro.org Mailing-list: list patchwork-forward@linaro.org; contact patchwork-forward+owners@linaro.org X-Google-Group-Id: 836684582541 List-Archive: - Drop wrong comment about the default stride. It's not always 2 * SZ_64K. When the re-distributor support VLPIs (from GICv4), the default stride is 4 * SZ_64K - Explain why SZ_64K * 2 Signed-off-by: Julien Grall --- Changes in v3: - Update commit message Changes in v2: - Patch added --- xen/arch/arm/gic-v3.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/xen/arch/arm/gic-v3.c b/xen/arch/arm/gic-v3.c index e7a7789..41042ab 100644 --- a/xen/arch/arm/gic-v3.c +++ b/xen/arch/arm/gic-v3.c @@ -639,7 +639,7 @@ static int __init gicv3_populate_rdist(void) ptr += gicv3.rdist_stride; else { - ptr += SZ_64K * 2; + ptr += SZ_64K * 2; /* Skip RD_base + SGI_base */ if ( typer & GICR_TYPER_VLPIS ) ptr += SZ_64K * 2; /* Skip VLPI_base + reserved page */ } @@ -1250,7 +1250,6 @@ static int __init gicv3_init(struct dt_device_node *node, const void *data) /* The vGIC code requires the region to be sorted */ sort(rdist_regs, gicv3.rdist_count, sizeof(*rdist_regs), cmp_rdist, NULL); - /* If stride is not set in dt. Set default to 2 * SZ_64K */ if ( !dt_property_read_u32(node, "redistributor-stride", &gicv3.rdist_stride) ) gicv3.rdist_stride = 0;