From patchwork Thu Jan 29 18:25:50 2015 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Julien Grall X-Patchwork-Id: 43961 Return-Path: X-Original-To: linaro@patches.linaro.org Delivered-To: linaro@patches.linaro.org Received: from mail-wi0-f199.google.com (mail-wi0-f199.google.com [209.85.212.199]) by ip-10-151-82-157.ec2.internal (Postfix) with ESMTPS id C8DC924128 for ; Thu, 29 Jan 2015 18:28:12 +0000 (UTC) Received: by mail-wi0-f199.google.com with SMTP id r20sf15023174wiv.2 for ; Thu, 29 Jan 2015 10:28:12 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:delivered-to:from:to:date:message-id:in-reply-to :references:cc:subject:precedence:list-id:list-unsubscribe:list-post :list-help:list-subscribe:mime-version:content-type :content-transfer-encoding:sender:errors-to:x-original-sender :x-original-authentication-results:mailing-list:list-archive; bh=BNljUIVfA9OiBLLq2hq99YNtCXNATFLiIqmvg/1u1CY=; b=DDjTBdarNSSXz1uGK3cWdBn/Jg2tvAlZs0Y9PRvO18vB3WyGq3NBVWbP2Gx+amruJi A/1CdChTz+icJHSKgPNH7+jTZomruIA5anM39VjCiFv5/Pg482tmqboT/bQCwL47oMlK UmDa/Cbpa01VM8aUBHBeMUib9D2WspaDvJ7Lx90NB5Pjwx3RSG225pHSXPebKB/y1xdY 0RZXNcbZ2jjBR8svOPhSVWoygz5OJ4qDolVX/jt4W0uZNdoRZX0Jk/OQr9ZHS385/anB TJnHmY6Q8I7jiZtarDfZpkbqe7VMq4WdD4UIC739RvxKE7hG+wG2LVYP6Q8O2b3GFAMz Bwag== X-Gm-Message-State: ALoCoQkL2CiuczISXeqr9MD80vRK/Wr4FoGvIMa6Lo6hMRVeyqkrsdA89t26xZcjQHNPUOr9W8qn X-Received: by 10.180.105.97 with SMTP id gl1mr226690wib.7.1422556092048; Thu, 29 Jan 2015 10:28:12 -0800 (PST) X-BeenThere: patchwork-forward@linaro.org Received: by 10.152.23.71 with SMTP id k7ls347023laf.9.gmail; Thu, 29 Jan 2015 10:28:11 -0800 (PST) X-Received: by 10.112.236.41 with SMTP id ur9mr2629888lbc.44.1422556091824; Thu, 29 Jan 2015 10:28:11 -0800 (PST) Received: from mail-lb0-f178.google.com (mail-lb0-f178.google.com. [209.85.217.178]) by mx.google.com with ESMTPS id xq4si8224481lbb.20.2015.01.29.10.28.11 for (version=TLSv1 cipher=ECDHE-RSA-RC4-SHA bits=128/128); Thu, 29 Jan 2015 10:28:11 -0800 (PST) Received-SPF: pass (google.com: domain of patch+caf_=patchwork-forward=linaro.org@linaro.org designates 209.85.217.178 as permitted sender) client-ip=209.85.217.178; Received: by mail-lb0-f178.google.com with SMTP id u10so31205435lbd.9 for ; Thu, 29 Jan 2015 10:28:11 -0800 (PST) X-Received: by 10.112.173.202 with SMTP id bm10mr2648389lbc.24.1422556091693; Thu, 29 Jan 2015 10:28:11 -0800 (PST) X-Forwarded-To: patchwork-forward@linaro.org X-Forwarded-For: patch@linaro.org patchwork-forward@linaro.org Delivered-To: patch@linaro.org Received: by 10.112.35.133 with SMTP id h5csp34221lbj; Thu, 29 Jan 2015 10:28:11 -0800 (PST) X-Received: by 10.180.38.66 with SMTP id e2mr3638113wik.62.1422556085621; Thu, 29 Jan 2015 10:28:05 -0800 (PST) Received: from lists.xen.org (lists.xen.org. [50.57.142.19]) by mx.google.com with ESMTPS id ls7si2429201wic.106.2015.01.29.10.28.03 (version=TLSv1 cipher=RC4-SHA bits=128/128); Thu, 29 Jan 2015 10:28:05 -0800 (PST) Received-SPF: none (google.com: xen-devel-bounces@lists.xen.org does not designate permitted sender hosts) client-ip=50.57.142.19; Received: from localhost ([127.0.0.1] helo=lists.xen.org) by lists.xen.org with esmtp (Exim 4.72) (envelope-from ) id 1YGto0-0004wA-0s; Thu, 29 Jan 2015 18:27:04 +0000 Received: from mail6.bemta4.messagelabs.com ([85.158.143.247]) by lists.xen.org with esmtp (Exim 4.72) (envelope-from ) id 1YGtnw-0004rI-5p for xen-devel@lists.xenproject.org; Thu, 29 Jan 2015 18:27:00 +0000 Received: from [85.158.143.35] by server-1.bemta-4.messagelabs.com id F3/E2-03000-37B7AC45; Thu, 29 Jan 2015 18:26:59 +0000 X-Env-Sender: julien.grall@linaro.org X-Msg-Ref: server-5.tower-21.messagelabs.com!1422556018!13315968!1 X-Originating-IP: [209.85.212.172] X-SpamReason: No, hits=0.0 required=7.0 tests= X-StarScan-Received: X-StarScan-Version: 6.12.5; banners=-,-,- X-VirusChecked: Checked Received: (qmail 7122 invoked from network); 29 Jan 2015 18:26:58 -0000 Received: from mail-wi0-f172.google.com (HELO mail-wi0-f172.google.com) (209.85.212.172) by server-5.tower-21.messagelabs.com with RC4-SHA encrypted SMTP; 29 Jan 2015 18:26:58 -0000 Received: by mail-wi0-f172.google.com with SMTP id h11so30033453wiw.5 for ; Thu, 29 Jan 2015 10:26:58 -0800 (PST) X-Received: by 10.180.74.141 with SMTP id t13mr2529569wiv.45.1422556018433; Thu, 29 Jan 2015 10:26:58 -0800 (PST) Received: from chilopoda.uk.xensource.com. ([185.25.64.249]) by mx.google.com with ESMTPSA id x18sm3518503wia.12.2015.01.29.10.26.56 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-SHA bits=128/128); Thu, 29 Jan 2015 10:26:57 -0800 (PST) From: Julien Grall To: xen-devel@lists.xenproject.org Date: Thu, 29 Jan 2015 18:25:50 +0000 Message-Id: <1422555950-31821-16-git-send-email-julien.grall@linaro.org> X-Mailer: git-send-email 2.1.4 In-Reply-To: <1422555950-31821-1-git-send-email-julien.grall@linaro.org> References: <1422555950-31821-1-git-send-email-julien.grall@linaro.org> Cc: stefano.stabellini@citrix.com, Vijaya.Kumar@caviumnetworks.com, Julien Grall , tim@xen.org, ian.campbell@citrix.com Subject: [Xen-devel] [PATCH v2 15/15] xen/arm: gic-v3: Update some comments in the code X-BeenThere: xen-devel@lists.xen.org X-Mailman-Version: 2.1.13 Precedence: list List-Id: List-Unsubscribe: , List-Post: , List-Help: , List-Subscribe: , MIME-Version: 1.0 Sender: xen-devel-bounces@lists.xen.org Errors-To: xen-devel-bounces@lists.xen.org X-Removed-Original-Auth: Dkim didn't pass. X-Original-Sender: julien.grall@linaro.org X-Original-Authentication-Results: mx.google.com; spf=pass (google.com: domain of patch+caf_=patchwork-forward=linaro.org@linaro.org designates 209.85.217.178 as permitted sender) smtp.mail=patch+caf_=patchwork-forward=linaro.org@linaro.org Mailing-list: list patchwork-forward@linaro.org; contact patchwork-forward+owners@linaro.org X-Google-Group-Id: 836684582541 List-Archive: - Drop wrong comment about the default stride. It's not always 2 * SZ_64K - Explain why SZ_64K * 2 Signed-off-by: Julien Grall --- Changes in v2: - Patch added --- xen/arch/arm/gic-v3.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/xen/arch/arm/gic-v3.c b/xen/arch/arm/gic-v3.c index 1b7ddb3..9035e3b 100644 --- a/xen/arch/arm/gic-v3.c +++ b/xen/arch/arm/gic-v3.c @@ -638,7 +638,7 @@ static int __init gicv3_populate_rdist(void) ptr += gicv3.rdist_stride; else { - ptr += SZ_64K * 2; + ptr += SZ_64K * 2; /* Skip RD_base + SGI_base */ if ( typer & GICR_TYPER_VLPIS ) ptr += SZ_64K * 2; /* Skip VLPI_base + reserved page */ } @@ -1238,7 +1238,6 @@ static int __init gicv3_init(struct dt_device_node *node, const void *data) rdist_regs[i].size = rdist_size; } - /* If stride is not set in dt. Set default to 2 * SZ_64K */ if ( !dt_property_read_u32(node, "redistributor-stride", &gicv3.rdist_stride) ) gicv3.rdist_stride = 0;