From patchwork Fri Jul 18 12:43:37 2014 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Ian Campbell X-Patchwork-Id: 33836 Return-Path: X-Original-To: linaro@patches.linaro.org Delivered-To: linaro@patches.linaro.org Received: from mail-pa0-f71.google.com (mail-pa0-f71.google.com [209.85.220.71]) by ip-10-151-82-157.ec2.internal (Postfix) with ESMTPS id 3174121309 for ; Fri, 18 Jul 2014 12:47:41 +0000 (UTC) Received: by mail-pa0-f71.google.com with SMTP id et14sf27227309pad.2 for ; Fri, 18 Jul 2014 05:47:40 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:delivered-to:message-id:from:to:date:in-reply-to :references:organization:mime-version:cc:subject:precedence:list-id :list-unsubscribe:list-post:list-help:list-subscribe:sender :errors-to:x-original-sender:x-original-authentication-results :mailing-list:list-archive:content-type:content-transfer-encoding; bh=ApYyTI5As19CwpOkCl0r9LHMShIn2lvzOWwmaMCGs34=; b=dKanWdsKcZXu5VUIfIUU8tJjclgg3cC4/w+16lktMvhO1A8vrle7/vY+mKBQzRphfR 29o1MJra+0xnWoFL7kEe/loruycyQn0Ztx/+cHNX9RyZDOpsjOnzt+jkF8Yk2fK3Qp/8 VcnU9s9yPUROwUJatONFTJe1sn/wUJkAjBVSc3Op9TedGzf4k7OYH9MArKvmcWQ8FCib 66p36PEoC5DgCEBAS8F9WXcVyiRPI8aBAUztdDOqUSQSuRz8rt+dg4ug1s9ItmomN5uI 3v9gLgnFp5GrLgVG1CUOb8GYbBBdjLpjac/12Bii0hYzbZoFOdMI8JurPBhD+mdL0Nbk JXng== X-Gm-Message-State: ALoCoQlztV74biItS1nQC4LQEM5qT5DTWx8Smr9fdvYiBO2E949HKAgU3ji2VCR6RBZLxDtKxaDV X-Received: by 10.68.242.74 with SMTP id wo10mr2296930pbc.0.1405687660221; Fri, 18 Jul 2014 05:47:40 -0700 (PDT) X-BeenThere: patchwork-forward@linaro.org Received: by 10.140.27.171 with SMTP id 40ls963079qgx.9.gmail; Fri, 18 Jul 2014 05:47:40 -0700 (PDT) X-Received: by 10.220.160.67 with SMTP id m3mr5463000vcx.56.1405687660091; Fri, 18 Jul 2014 05:47:40 -0700 (PDT) Received: from mail-vc0-f182.google.com (mail-vc0-f182.google.com [209.85.220.182]) by mx.google.com with ESMTPS id qe9si5503758vcb.79.2014.07.18.05.47.40 for (version=TLSv1 cipher=ECDHE-RSA-RC4-SHA bits=128/128); Fri, 18 Jul 2014 05:47:40 -0700 (PDT) Received-SPF: pass (google.com: domain of patch+caf_=patchwork-forward=linaro.org@linaro.org designates 209.85.220.182 as permitted sender) client-ip=209.85.220.182; Received: by mail-vc0-f182.google.com with SMTP id hy4so7194510vcb.41 for ; Fri, 18 Jul 2014 05:47:40 -0700 (PDT) X-Received: by 10.221.47.9 with SMTP id uq9mr5506040vcb.48.1405687659933; Fri, 18 Jul 2014 05:47:39 -0700 (PDT) X-Forwarded-To: patchwork-forward@linaro.org X-Forwarded-For: patch@linaro.org patchwork-forward@linaro.org Delivered-To: patch@linaro.org Received: by 10.221.37.5 with SMTP id tc5csp8128vcb; Fri, 18 Jul 2014 05:47:39 -0700 (PDT) X-Received: by 10.220.68.140 with SMTP id v12mr5360464vci.13.1405687658870; Fri, 18 Jul 2014 05:47:38 -0700 (PDT) Received: from lists.xen.org (lists.xen.org. [50.57.142.19]) by mx.google.com with ESMTPS id s63si10344067qga.18.2014.07.18.05.47.33 for (version=TLSv1 cipher=RC4-SHA bits=128/128); Fri, 18 Jul 2014 05:47:36 -0700 (PDT) Received-SPF: none (google.com: xen-devel-bounces@lists.xen.org does not designate permitted sender hosts) client-ip=50.57.142.19; Received: from localhost ([127.0.0.1] helo=lists.xen.org) by lists.xen.org with esmtp (Exim 4.72) (envelope-from ) id 1X87W9-0002hM-7g; Fri, 18 Jul 2014 12:44:05 +0000 Received: from mail6.bemta5.messagelabs.com ([195.245.231.135]) by lists.xen.org with esmtp (Exim 4.72) (envelope-from ) id 1X87W7-0002gP-5w for xen-devel@lists.xen.org; Fri, 18 Jul 2014 12:44:04 +0000 Received: from [85.158.139.211:42273] by server-17.bemta-5.messagelabs.com id 7D/DB-08085-29619C35; Fri, 18 Jul 2014 12:44:02 +0000 X-Env-Sender: Ian.Campbell@citrix.com X-Msg-Ref: server-2.tower-206.messagelabs.com!1405687440!16291601!1 X-Originating-IP: [66.165.176.89] X-SpamReason: No, hits=0.0 required=7.0 tests=sa_preprocessor: VHJ1c3RlZCBJUDogNjYuMTY1LjE3Ni44OSA9PiAyMDMwMDc=\n X-StarScan-Received: X-StarScan-Version: 6.11.3; banners=-,-,- X-VirusChecked: Checked Received: (qmail 3261 invoked from network); 18 Jul 2014 12:44:01 -0000 Received: from smtp.citrix.com (HELO SMTP.CITRIX.COM) (66.165.176.89) by server-2.tower-206.messagelabs.com with RC4-SHA encrypted SMTP; 18 Jul 2014 12:44:01 -0000 X-IronPort-AV: E=Sophos;i="5.01,684,1400025600"; d="scan'208";a="153657089" Received: from accessns.citrite.net (HELO FTLPEX01CL02.citrite.net) ([10.9.154.239]) by FTLPIPO01.CITRIX.COM with ESMTP; 18 Jul 2014 12:43:40 +0000 Received: from kazak.uk.xensource.com (10.80.2.80) by FTLPEX01CL02.citrite.net (10.13.107.79) with Microsoft SMTP Server id 14.3.181.6; Fri, 18 Jul 2014 08:43:39 -0400 Message-ID: <1405687417.27855.9.camel@kazak.uk.xensource.com> From: Ian Campbell To: Arianna Avanzini Date: Fri, 18 Jul 2014 13:43:37 +0100 In-Reply-To: <1405601872.31127.18.camel@kazak.uk.xensource.com> References: <53BFEBFB.1090602@linaro.org> <1405299035-2988-1-git-send-email-avanzini.arianna@gmail.com> <1405299035-2988-3-git-send-email-avanzini.arianna@gmail.com> <1405601872.31127.18.camel@kazak.uk.xensource.com> Organization: Citrix Systems, Inc. X-Mailer: Evolution 3.12.2-1 MIME-Version: 1.0 X-Originating-IP: [10.80.2.80] X-DLP: MIA1 Cc: paolo.valente@unimore.it, keir@xen.org, stefano.stabellini@eu.citrix.com, tim@xen.org, dario.faggioli@citrix.com, Ian.Jackson@eu.citrix.com, xen-devel@lists.xen.org, julien.grall@citrix.com, etrudeau@broadcom.com, JBeulich@suse.com, andrew.cooper3@citrix.com, viktor.kleinik@globallogic.com Subject: Re: [Xen-devel] [PATCH RESEND v9 02/14] arch/arm: let map_mmio_regions() take pfn as parameters X-BeenThere: xen-devel@lists.xen.org X-Mailman-Version: 2.1.13 Precedence: list List-Id: List-Unsubscribe: , List-Post: , List-Help: , List-Subscribe: , Sender: xen-devel-bounces@lists.xen.org Errors-To: xen-devel-bounces@lists.xen.org X-Removed-Original-Auth: Dkim didn't pass. X-Original-Sender: ian.campbell@citrix.com X-Original-Authentication-Results: mx.google.com; spf=pass (google.com: domain of patch+caf_=patchwork-forward=linaro.org@linaro.org designates 209.85.220.182 as permitted sender) smtp.mail=patch+caf_=patchwork-forward=linaro.org@linaro.org Mailing-list: list patchwork-forward@linaro.org; contact patchwork-forward+owners@linaro.org X-Google-Group-Id: 836684582541 List-Archive: On Thu, 2014-07-17 at 13:57 +0100, Ian Campbell wrote: > On Mon, 2014-07-14 at 02:50 +0200, Arianna Avanzini wrote: > > Currently, the map_mmio_regions() function, defined for the ARM > > architecture, has parameters with paddr_t type. This interface, > > however, needs caller functions to correctly page-align addresses > > given as parameters to map_mmio_regions(). This commit changes the > > function's interface to accept page frame numbers as parameters. > > This commit also modifies caller functions in an attempt to adapt > > them to the new interface. > > This commit is meant to produce the minimum indispensable needed > > changes; these are also instrumental to making the interface of > > map_mmio_regions() symmetric with the unmap_mmio_regions() function, > > that will be introduced in one of the next commits of the series > > and will feature a pfn-based interface. > > > > NOTE: platform-specific code has not been tested, save for the > > sunxi and the Arndale Exynos 5 platforms (see the Tested-by > > below for the latter). > > > > Signed-off-by: Arianna Avanzini > > Tested-by: Julien Grall > > Cc: Dario Faggioli > > Cc: Paolo Valente > > Cc: Stefano Stabellini > > Acked-by: Ian Campbell Since they represent an interface change which clashes with other upcoming series I've applied this patch and the next one (arch/arm: let map_mmio_regions() use start and count). I had to apply a simple fixlet to the second patch: Ian. diff --git a/xen/arch/arm/platforms/xgene-storm.c b/xen/arch/arm/platforms/xgene-storm.c index 2980c0d..29c4752 100644 --- a/xen/arch/arm/platforms/xgene-storm.c +++ b/xen/arch/arm/platforms/xgene-storm.c @@ -47,7 +47,7 @@ static int map_one_mmio(struct domain *d, const char *what, printk("Additional MMIO %"PRIpaddr"-%"PRIpaddr" (%s)\n", start, end, what); - ret = map_mmio_regions(d, start, end, end - start + 1, start); + ret = map_mmio_regions(d, start, end - start + 1, start); if ( ret ) printk("Failed to map %s @ %"PRIpaddr" to dom%d\n", what, start, d->domain_id);