From patchwork Thu Apr 24 22:45:53 2014 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Julien Grall X-Patchwork-Id: 29021 Return-Path: X-Original-To: linaro@patches.linaro.org Delivered-To: linaro@patches.linaro.org Received: from mail-qg0-f71.google.com (mail-qg0-f71.google.com [209.85.192.71]) by ip-10-151-82-157.ec2.internal (Postfix) with ESMTPS id 8D6262036A for ; Thu, 24 Apr 2014 22:47:28 +0000 (UTC) Received: by mail-qg0-f71.google.com with SMTP id f51sf6963794qge.6 for ; Thu, 24 Apr 2014 15:47:28 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:delivered-to:from:to:date:message-id:in-reply-to :references:cc:subject:precedence:list-id:list-unsubscribe:list-post :list-help:list-subscribe:mime-version:sender:errors-to :x-original-sender:x-original-authentication-results:mailing-list :list-archive:content-type:content-transfer-encoding; bh=VpYUIuIGiRGdS4LU1qa3099jRBB/kryN9DFugK/sjTg=; b=OWnP8hEShP9fX+l4r0fbTjDkX7QOU6HAualSZUU+fMpA/kOAMuXngk6TusD2r1zVbe QL/It3UCAA1BExGWQeqOtTtqjcJglfjkdgO4ZrEyW5ReA0pyGbY9KlCnyYYDo/VXHvyS sKDdKiwHe3Vt9i7ffJ3w8sHC3xlqJWy2km49vqyii2P7lI1Lczm0QuGTbkSfiuRktaW6 SPBm4ryI2+KzdEM/go228oJiR1+snrVJYpvLMiOLSUl3kutDxzGDvh/Z2SRUh2ExhMP1 l/EIq4N3z/CvtzE+6YQ5Je1uZlu451FOZVX8C7YAJsVUUL1fMIUZ9YCmakK+nX6sHq6O bYcw== X-Gm-Message-State: ALoCoQldwYi+2OvN4UptGs5VooFfAO1XUBMkl5dPh6A9uP9g9h7lvsWaOcTPXgXsP7QAyN4+08GH X-Received: by 10.236.142.101 with SMTP id h65mr2210324yhj.1.1398379648246; Thu, 24 Apr 2014 15:47:28 -0700 (PDT) X-BeenThere: patchwork-forward@linaro.org Received: by 10.140.102.180 with SMTP id w49ls1375258qge.3.gmail; Thu, 24 Apr 2014 15:47:28 -0700 (PDT) X-Received: by 10.221.62.131 with SMTP id xa3mr3268225vcb.13.1398379648153; Thu, 24 Apr 2014 15:47:28 -0700 (PDT) Received: from mail-ve0-f175.google.com (mail-ve0-f175.google.com [209.85.128.175]) by mx.google.com with ESMTPS id cx1si1282186vdb.110.2014.04.24.15.47.28 for (version=TLSv1 cipher=ECDHE-RSA-RC4-SHA bits=128/128); Thu, 24 Apr 2014 15:47:28 -0700 (PDT) Received-SPF: none (google.com: patch+caf_=patchwork-forward=linaro.org@linaro.org does not designate permitted sender hosts) client-ip=209.85.128.175; Received: by mail-ve0-f175.google.com with SMTP id oz11so3720709veb.34 for ; Thu, 24 Apr 2014 15:47:28 -0700 (PDT) X-Received: by 10.221.27.8 with SMTP id ro8mr2823591vcb.30.1398379648083; Thu, 24 Apr 2014 15:47:28 -0700 (PDT) X-Forwarded-To: patchwork-forward@linaro.org X-Forwarded-For: patch@linaro.org patchwork-forward@linaro.org Delivered-To: patch@linaro.org Received: by 10.220.221.72 with SMTP id ib8csp51835vcb; Thu, 24 Apr 2014 15:47:27 -0700 (PDT) X-Received: by 10.52.249.105 with SMTP id yt9mr2753535vdc.34.1398379647707; Thu, 24 Apr 2014 15:47:27 -0700 (PDT) Received: from lists.xen.org (lists.xen.org. [50.57.142.19]) by mx.google.com with ESMTPS id dh4si1286828veb.49.2014.04.24.15.47.27 for (version=TLSv1 cipher=RC4-SHA bits=128/128); Thu, 24 Apr 2014 15:47:27 -0700 (PDT) Received-SPF: none (google.com: xen-devel-bounces@lists.xen.org does not designate permitted sender hosts) client-ip=50.57.142.19; Received: from localhost ([127.0.0.1] helo=lists.xen.org) by lists.xen.org with esmtp (Exim 4.72) (envelope-from ) id 1WdSPB-0003LK-4E; Thu, 24 Apr 2014 22:46:09 +0000 Received: from mail6.bemta5.messagelabs.com ([195.245.231.135]) by lists.xen.org with esmtp (Exim 4.72) (envelope-from ) id 1WdSP8-0003LC-T1 for xen-devel@lists.xenproject.org; Thu, 24 Apr 2014 22:46:07 +0000 Received: from [85.158.139.211:41785] by server-9.bemta-5.messagelabs.com id 27/8B-04350-D2499535; Thu, 24 Apr 2014 22:46:05 +0000 X-Env-Sender: julien.grall@linaro.org X-Msg-Ref: server-5.tower-206.messagelabs.com!1398379564!490660!1 X-Originating-IP: [74.125.83.54] X-SpamReason: No, hits=0.5 required=7.0 tests=BODY_RANDOM_LONG X-StarScan-Received: X-StarScan-Version: 6.11.3; banners=-,-,- X-VirusChecked: Checked Received: (qmail 21768 invoked from network); 24 Apr 2014 22:46:04 -0000 Received: from mail-ee0-f54.google.com (HELO mail-ee0-f54.google.com) (74.125.83.54) by server-5.tower-206.messagelabs.com with RC4-SHA encrypted SMTP; 24 Apr 2014 22:46:04 -0000 Received: by mail-ee0-f54.google.com with SMTP id d49so2288659eek.41 for ; Thu, 24 Apr 2014 15:46:04 -0700 (PDT) X-Received: by 10.14.110.199 with SMTP id u47mr236132eeg.74.1398379564807; Thu, 24 Apr 2014 15:46:04 -0700 (PDT) Received: from belegaer.uk.xensource.com ([185.25.64.249]) by mx.google.com with ESMTPSA id t44sm19683823eeo.6.2014.04.24.15.46.01 for (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Thu, 24 Apr 2014 15:46:02 -0700 (PDT) From: Julien Grall To: xen-devel@lists.xenproject.org Date: Thu, 24 Apr 2014 23:45:53 +0100 Message-Id: <1398379556-1132-2-git-send-email-julien.grall@linaro.org> X-Mailer: git-send-email 1.7.10.4 In-Reply-To: <1398379556-1132-1-git-send-email-julien.grall@linaro.org> References: <1398379556-1132-1-git-send-email-julien.grall@linaro.org> Cc: stefano.stabellini@citrix.com, Julien Grall , tim@xen.org, ian.campbell@citrix.com Subject: [Xen-devel] [PATCH 1/4] xen/arm: Add missing newline after commit 60f7376 X-BeenThere: xen-devel@lists.xen.org X-Mailman-Version: 2.1.13 Precedence: list List-Id: List-Unsubscribe: , List-Post: , List-Help: , List-Subscribe: , MIME-Version: 1.0 Sender: xen-devel-bounces@lists.xen.org Errors-To: xen-devel-bounces@lists.xen.org X-Removed-Original-Auth: Dkim didn't pass. X-Original-Sender: julien.grall@linaro.org X-Original-Authentication-Results: mx.google.com; spf=neutral (google.com: patch+caf_=patchwork-forward=linaro.org@linaro.org does not designate permitted sender hosts) smtp.mail=patch+caf_=patchwork-forward=linaro.org@linaro.org Mailing-list: list patchwork-forward@linaro.org; contact patchwork-forward+owners@linaro.org X-Google-Group-Id: 836684582541 List-Archive: Commit 60f7376 "xen/arm: Inject an undefined instruction when the coproc/sysreg is not handled" replaced panic by gdprintk. Unfortunately panic message string doesn't need newline, rather than gdprintk will request one. Signed-off-by: Julien Grall --- xen/arch/arm/traps.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/xen/arch/arm/traps.c b/xen/arch/arm/traps.c index d674a15..700665c 100644 --- a/xen/arch/arm/traps.c +++ b/xen/arch/arm/traps.c @@ -1393,7 +1393,7 @@ static void do_cp15_32(struct cpu_user_regs *regs, "%s p15, %d, r%d, cr%d, cr%d, %d @ 0x%"PRIregister"\n", cp32.read ? "mrc" : "mcr", cp32.op1, cp32.reg, cp32.crn, cp32.crm, cp32.op2, regs->pc); - gdprintk(XENLOG_ERR, "unhandled 32-bit CP15 access %#x", + gdprintk(XENLOG_ERR, "unhandled 32-bit CP15 access %#x\n", hsr.bits & HSR_CP32_REGS_MASK); #endif inject_undef32_exception(regs); @@ -1430,7 +1430,7 @@ static void do_cp15_64(struct cpu_user_regs *regs, "%s p15, %d, r%d, r%d, cr%d @ 0x%"PRIregister"\n", cp64.read ? "mrrc" : "mcrr", cp64.op1, cp64.reg1, cp64.reg2, cp64.crm, regs->pc); - gdprintk(XENLOG_ERR, "unhandled 64-bit CP15 access %#x", + gdprintk(XENLOG_ERR, "unhandled 64-bit CP15 access %#x\n", hsr.bits & HSR_CP64_REGS_MASK); #endif inject_undef32_exception(regs); @@ -1529,7 +1529,7 @@ static void do_sysreg(struct cpu_user_regs *regs, sysreg.op2, sysreg.read ? "=>" : "<=", sysreg.reg, regs->pc); - gdprintk(XENLOG_ERR, "unhandled 64-bit sysreg access %#x", + gdprintk(XENLOG_ERR, "unhandled 64-bit sysreg access %#x\n", hsr.bits & HSR_SYSREG_REGS_MASK); #endif inject_undef64_exception(regs, sysreg.len);