From patchwork Tue Apr 22 12:58:34 2014 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Julien Grall X-Patchwork-Id: 28779 Return-Path: X-Original-To: linaro@patches.linaro.org Delivered-To: linaro@patches.linaro.org Received: from mail-qg0-f72.google.com (mail-qg0-f72.google.com [209.85.192.72]) by ip-10-151-82-157.ec2.internal (Postfix) with ESMTPS id F405A203AC for ; Tue, 22 Apr 2014 13:02:52 +0000 (UTC) Received: by mail-qg0-f72.google.com with SMTP id q108sf541552qgd.11 for ; Tue, 22 Apr 2014 06:02:52 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:delivered-to:from:to:date:message-id:in-reply-to :references:cc:subject:precedence:list-id:list-unsubscribe:list-post :list-help:list-subscribe:mime-version:sender:errors-to :x-original-sender:x-original-authentication-results:mailing-list :list-archive:content-type:content-transfer-encoding; bh=bru/3U7BA14xWApPXz2um7EQk8myW+baKtlTtC3qmKw=; b=glDPcoArdJb25NNatzU9SR+q9Zk4d/4l82doaOFReajx2JKvenOQByIJWwaftpKqXP D/KbA+tm38ZV72YM85J77qcPi6txWhUrdQsbeU+n9EZpct2+YoSrrwOBDm6s7nxO4X8J 5bLoV3/t7wDU4U3ygNeexSlRHCufv+DRkNPpyrJljkQGFNlJVe9RoHBusLwCINn/ufiL NffzE9tXl30odmsK1TPT9bfOwIZkp6O0K+4BjP2sPqIwUowzJHP+dtkg00AZRNDYJawi 9psLIg9upZpCIl/taKemvxH5Pul1cy+6aSOuxyyEaQgx1ARwlhPW/sALv+8M7glC931f HeZQ== X-Gm-Message-State: ALoCoQkl1hfj+wnXMXVZAgbaJAdnLphzf+QYgF0acKoZ9h0awe9ET8jay1OIeKl6B65hYgsl8YYH X-Received: by 10.58.161.175 with SMTP id xt15mr22712742veb.19.1398171772693; Tue, 22 Apr 2014 06:02:52 -0700 (PDT) X-BeenThere: patchwork-forward@linaro.org Received: by 10.140.85.241 with SMTP id n104ls96713qgd.36.gmail; Tue, 22 Apr 2014 06:02:52 -0700 (PDT) X-Received: by 10.52.142.10 with SMTP id rs10mr31307410vdb.3.1398171772598; Tue, 22 Apr 2014 06:02:52 -0700 (PDT) Received: from mail-ve0-f173.google.com (mail-ve0-f173.google.com [209.85.128.173]) by mx.google.com with ESMTPS id tq2si6862628vdc.21.2014.04.22.06.02.52 for (version=TLSv1 cipher=ECDHE-RSA-RC4-SHA bits=128/128); Tue, 22 Apr 2014 06:02:52 -0700 (PDT) Received-SPF: neutral (google.com: 209.85.128.173 is neither permitted nor denied by best guess record for domain of patch+caf_=patchwork-forward=linaro.org@linaro.org) client-ip=209.85.128.173; Received: by mail-ve0-f173.google.com with SMTP id oy12so9395896veb.18 for ; Tue, 22 Apr 2014 06:02:52 -0700 (PDT) X-Received: by 10.220.162.6 with SMTP id t6mr37673273vcx.12.1398171772517; Tue, 22 Apr 2014 06:02:52 -0700 (PDT) X-Forwarded-To: patchwork-forward@linaro.org X-Forwarded-For: patch@linaro.org patchwork-forward@linaro.org Delivered-To: patch@linaro.org Received: by 10.220.221.72 with SMTP id ib8csp22738vcb; Tue, 22 Apr 2014 06:02:52 -0700 (PDT) X-Received: by 10.140.19.68 with SMTP id 62mr52441848qgg.55.1398171770287; Tue, 22 Apr 2014 06:02:50 -0700 (PDT) Received: from lists.xen.org (lists.xen.org. [50.57.142.19]) by mx.google.com with ESMTPS id q105si16980164qgq.70.2014.04.22.06.02.49 for (version=TLSv1 cipher=RC4-SHA bits=128/128); Tue, 22 Apr 2014 06:02:50 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of xen-devel-bounces@lists.xen.org designates 50.57.142.19 as permitted sender) client-ip=50.57.142.19; Received: from localhost ([127.0.0.1] helo=lists.xen.org) by lists.xen.org with esmtp (Exim 4.72) (envelope-from ) id 1WcaIf-0001kp-I3; Tue, 22 Apr 2014 12:59:49 +0000 Received: from mail6.bemta4.messagelabs.com ([85.158.143.247]) by lists.xen.org with esmtp (Exim 4.72) (envelope-from ) id 1WcaHr-0001gE-LC for xen-devel@lists.xenproject.org; Tue, 22 Apr 2014 12:59:00 +0000 Received: from [85.158.143.35:14699] by server-1.bemta-4.messagelabs.com id 98/7E-09853-39766535; Tue, 22 Apr 2014 12:58:59 +0000 X-Env-Sender: julien.grall@linaro.org X-Msg-Ref: server-5.tower-21.messagelabs.com!1398171538!253207!1 X-Originating-IP: [74.125.83.45] X-SpamReason: No, hits=0.0 required=7.0 tests= X-StarScan-Received: X-StarScan-Version: 6.11.3; banners=-,-,- X-VirusChecked: Checked Received: (qmail 17421 invoked from network); 22 Apr 2014 12:58:58 -0000 Received: from mail-ee0-f45.google.com (HELO mail-ee0-f45.google.com) (74.125.83.45) by server-5.tower-21.messagelabs.com with RC4-SHA encrypted SMTP; 22 Apr 2014 12:58:58 -0000 Received: by mail-ee0-f45.google.com with SMTP id d17so4550941eek.18 for ; Tue, 22 Apr 2014 05:58:58 -0700 (PDT) X-Received: by 10.14.95.8 with SMTP id o8mr55457173eef.15.1398171537974; Tue, 22 Apr 2014 05:58:57 -0700 (PDT) Received: from belegaer.uk.xensource.com ([185.25.64.249]) by mx.google.com with ESMTPSA id x45sm112862825eef.15.2014.04.22.05.58.56 for (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Tue, 22 Apr 2014 05:58:57 -0700 (PDT) From: Julien Grall To: xen-devel@lists.xenproject.org Date: Tue, 22 Apr 2014 13:58:34 +0100 Message-Id: <1398171530-27391-3-git-send-email-julien.grall@linaro.org> X-Mailer: git-send-email 1.7.10.4 In-Reply-To: <1398171530-27391-1-git-send-email-julien.grall@linaro.org> References: <1398171530-27391-1-git-send-email-julien.grall@linaro.org> Cc: stefano.stabellini@citrix.com, Julien Grall , tim@xen.org, ian.campbell@citrix.com Subject: [Xen-devel] [PATCH v4 02/18] xen/arm: IRQ: Use default irq callback from common code for no_irq_type X-BeenThere: xen-devel@lists.xen.org X-Mailman-Version: 2.1.13 Precedence: list List-Id: List-Unsubscribe: , List-Post: , List-Help: , List-Subscribe: , MIME-Version: 1.0 Sender: xen-devel-bounces@lists.xen.org Errors-To: xen-devel-bounces@lists.xen.org X-Removed-Original-Auth: Dkim didn't pass. X-Original-Sender: julien.grall@linaro.org X-Original-Authentication-Results: mx.google.com; spf=neutral (google.com: 209.85.128.173 is neither permitted nor denied by best guess record for domain of patch+caf_=patchwork-forward=linaro.org@linaro.org) smtp.mail=patch+caf_=patchwork-forward=linaro.org@linaro.org Mailing-list: list patchwork-forward@linaro.org; contact patchwork-forward+owners@linaro.org X-Google-Group-Id: 836684582541 List-Archive: Most of no_irq_type callback are already defined in common/irq.c. We don't need to recreate our own callbacks. Signed-off-by: Julien Grall Acked-by: Ian Campbell --- Changes in v2: - Patch added --- xen/arch/arm/irq.c | 14 +++++--------- 1 file changed, 5 insertions(+), 9 deletions(-) diff --git a/xen/arch/arm/irq.c b/xen/arch/arm/irq.c index 3e326b0..5d1ed7f 100644 --- a/xen/arch/arm/irq.c +++ b/xen/arch/arm/irq.c @@ -27,23 +27,19 @@ #include -static void enable_none(struct irq_desc *irq) { } -static unsigned int startup_none(struct irq_desc *irq) { return 0; } -static void disable_none(struct irq_desc *irq) { } static void ack_none(struct irq_desc *irq) { printk("unexpected IRQ trap at irq %02x\n", irq->irq); } -#define shutdown_none disable_none -#define end_none enable_none +static void end_none(struct irq_desc *irq) { } hw_irq_controller no_irq_type = { .typename = "none", - .startup = startup_none, - .shutdown = shutdown_none, - .enable = enable_none, - .disable = disable_none, + .startup = irq_startup_none, + .shutdown = irq_shutdown_none, + .enable = irq_enable_none, + .disable = irq_disable_none, .ack = ack_none, .end = end_none };