From patchwork Tue Apr 8 14:43:51 2014 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Julien Grall X-Patchwork-Id: 27990 Return-Path: X-Original-To: linaro@patches.linaro.org Delivered-To: linaro@patches.linaro.org Received: from mail-vc0-f199.google.com (mail-vc0-f199.google.com [209.85.220.199]) by ip-10-151-82-157.ec2.internal (Postfix) with ESMTPS id 82CA520447 for ; Tue, 8 Apr 2014 14:45:57 +0000 (UTC) Received: by mail-vc0-f199.google.com with SMTP id lh14sf2883652vcb.2 for ; Tue, 08 Apr 2014 07:45:57 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:delivered-to:from:to:date:message-id:in-reply-to :references:cc:subject:precedence:list-id:list-unsubscribe:list-post :list-help:list-subscribe:mime-version:sender:errors-to :x-original-sender:x-original-authentication-results:mailing-list :list-archive:content-type:content-transfer-encoding; bh=WkQ7WNY7TX9MDgjxToE7ImX+0ZAkyDVaM1hyZQegHf0=; b=YWIbTvfTKCCb9EyBfbeQWKue4DZQz/iOMHfUTzcHhqofLTGQM99xYEFhwlnc7gcs1D FjN2jMu4kFNv01AvWiRXzSy/8Jgv0XrNuygQQFrw7Zfr/WLj8oxtj1TwBUa3fIuktCst 29avwn2XqcvBOg4xjd1FM24sz6Tx1H4mYNTO1fpssDrI92exySxBBM7g4ZdeVTSQe9VL lJvSSBeTa82gOF97r/vV4Svv66TA6IoZQ9kC0g2po2gQwFqn8T+o5wRLldb2YqGo9KB8 DO6v+KirNcMr+2qaBMR0Nk/25whgPXW90xlwAIozaYz75rwa0WMcKBcAq5cVBeiPwjZ/ AfEA== X-Gm-Message-State: ALoCoQkksP8VhfFTfyDM/L195bEZ/jXKDFUHk6rEJXSycZ44KnRjMmaz7/oV2h0PpnxcDDvE9CQ4 X-Received: by 10.58.30.78 with SMTP id q14mr1900085veh.10.1396968357048; Tue, 08 Apr 2014 07:45:57 -0700 (PDT) X-BeenThere: patchwork-forward@linaro.org Received: by 10.140.31.244 with SMTP id f107ls229101qgf.65.gmail; Tue, 08 Apr 2014 07:45:56 -0700 (PDT) X-Received: by 10.52.104.7 with SMTP id ga7mr1619029vdb.29.1396968356874; Tue, 08 Apr 2014 07:45:56 -0700 (PDT) Received: from mail-vc0-f179.google.com (mail-vc0-f179.google.com [209.85.220.179]) by mx.google.com with ESMTPS id kp12si439100veb.12.2014.04.08.07.45.56 for (version=TLSv1 cipher=ECDHE-RSA-RC4-SHA bits=128/128); Tue, 08 Apr 2014 07:45:56 -0700 (PDT) Received-SPF: neutral (google.com: 209.85.220.179 is neither permitted nor denied by best guess record for domain of patch+caf_=patchwork-forward=linaro.org@linaro.org) client-ip=209.85.220.179; Received: by mail-vc0-f179.google.com with SMTP id ij19so838581vcb.38 for ; Tue, 08 Apr 2014 07:45:56 -0700 (PDT) X-Received: by 10.58.96.36 with SMTP id dp4mr3294644veb.21.1396968356793; Tue, 08 Apr 2014 07:45:56 -0700 (PDT) X-Forwarded-To: patchwork-forward@linaro.org X-Forwarded-For: patch@linaro.org patchwork-forward@linaro.org Delivered-To: patch@linaro.org Received: by 10.220.12.8 with SMTP id v8csp251660vcv; Tue, 8 Apr 2014 07:45:56 -0700 (PDT) X-Received: by 10.224.50.211 with SMTP id a19mr4955309qag.49.1396968355704; Tue, 08 Apr 2014 07:45:55 -0700 (PDT) Received: from lists.xen.org (lists.xen.org. [50.57.142.19]) by mx.google.com with ESMTPS id 68si163027qgn.14.2014.04.08.07.45.55 for (version=TLSv1 cipher=RC4-SHA bits=128/128); Tue, 08 Apr 2014 07:45:55 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of xen-devel-bounces@lists.xen.org designates 50.57.142.19 as permitted sender) client-ip=50.57.142.19; Received: from localhost ([127.0.0.1] helo=lists.xen.org) by lists.xen.org with esmtp (Exim 4.72) (envelope-from ) id 1WXXG4-00008k-R8; Tue, 08 Apr 2014 14:44:16 +0000 Received: from mail6.bemta14.messagelabs.com ([193.109.254.103]) by lists.xen.org with esmtp (Exim 4.72) (envelope-from ) id 1WXXG3-00008B-Jf for xen-devel@lists.xenproject.org; Tue, 08 Apr 2014 14:44:15 +0000 Received: from [193.109.254.147:65194] by server-4.bemta-14.messagelabs.com id A7/33-02781-E3B04435; Tue, 08 Apr 2014 14:44:14 +0000 X-Env-Sender: julien.grall@linaro.org X-Msg-Ref: server-2.tower-27.messagelabs.com!1396968254!7016401!1 X-Originating-IP: [74.125.83.51] X-SpamReason: No, hits=0.0 required=7.0 tests= X-StarScan-Received: X-StarScan-Version: 6.11.1; banners=-,-,- X-VirusChecked: Checked Received: (qmail 19270 invoked from network); 8 Apr 2014 14:44:14 -0000 Received: from mail-ee0-f51.google.com (HELO mail-ee0-f51.google.com) (74.125.83.51) by server-2.tower-27.messagelabs.com with RC4-SHA encrypted SMTP; 8 Apr 2014 14:44:14 -0000 Received: by mail-ee0-f51.google.com with SMTP id c13so787644eek.10 for ; Tue, 08 Apr 2014 07:44:14 -0700 (PDT) X-Received: by 10.14.223.136 with SMTP id v8mr2463669eep.91.1396968254097; Tue, 08 Apr 2014 07:44:14 -0700 (PDT) Received: from belegaer.uk.xensource.com ([185.25.64.249]) by mx.google.com with ESMTPSA id m42sm5031709eex.21.2014.04.08.07.44.12 for (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Tue, 08 Apr 2014 07:44:12 -0700 (PDT) From: Julien Grall To: xen-devel@lists.xenproject.org Date: Tue, 8 Apr 2014 15:43:51 +0100 Message-Id: <1396968247-8768-3-git-send-email-julien.grall@linaro.org> X-Mailer: git-send-email 1.7.10.4 In-Reply-To: <1396968247-8768-1-git-send-email-julien.grall@linaro.org> References: <1396968247-8768-1-git-send-email-julien.grall@linaro.org> Cc: stefano.stabellini@citrix.com, Julien Grall , tim@xen.org, ian.campbell@citrix.com Subject: [Xen-devel] [PATCH v3 02/18] xen/arm: IRQ: Use default irq callback from common code for no_irq_type X-BeenThere: xen-devel@lists.xen.org X-Mailman-Version: 2.1.13 Precedence: list List-Id: List-Unsubscribe: , List-Post: , List-Help: , List-Subscribe: , MIME-Version: 1.0 Sender: xen-devel-bounces@lists.xen.org Errors-To: xen-devel-bounces@lists.xen.org X-Removed-Original-Auth: Dkim didn't pass. X-Original-Sender: julien.grall@linaro.org X-Original-Authentication-Results: mx.google.com; spf=neutral (google.com: 209.85.220.179 is neither permitted nor denied by best guess record for domain of patch+caf_=patchwork-forward=linaro.org@linaro.org) smtp.mail=patch+caf_=patchwork-forward=linaro.org@linaro.org Mailing-list: list patchwork-forward@linaro.org; contact patchwork-forward+owners@linaro.org X-Google-Group-Id: 836684582541 List-Archive: Most of no_irq_type callback are already defined in common/irq.c. We don't need to recreate our own callbacks. Signed-off-by: Julien Grall Acked-by: Ian Campbell --- Changes in v2: - Patch added --- xen/arch/arm/irq.c | 14 +++++--------- 1 file changed, 5 insertions(+), 9 deletions(-) diff --git a/xen/arch/arm/irq.c b/xen/arch/arm/irq.c index 5daa269..b287bce 100644 --- a/xen/arch/arm/irq.c +++ b/xen/arch/arm/irq.c @@ -27,23 +27,19 @@ #include -static void enable_none(struct irq_desc *irq) { } -static unsigned int startup_none(struct irq_desc *irq) { return 0; } -static void disable_none(struct irq_desc *irq) { } static void ack_none(struct irq_desc *irq) { printk("unexpected IRQ trap at irq %02x\n", irq->irq); } -#define shutdown_none disable_none -#define end_none enable_none +static void end_none(struct irq_desc *irq) { } hw_irq_controller no_irq_type = { .typename = "none", - .startup = startup_none, - .shutdown = shutdown_none, - .enable = enable_none, - .disable = disable_none, + .startup = irq_startup_none, + .shutdown = irq_shutdown_none, + .enable = irq_enable_none, + .disable = irq_disable_none, .ack = ack_none, .end = end_none };