From patchwork Thu Apr 3 20:41:53 2014 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Julien Grall X-Patchwork-Id: 27714 Return-Path: X-Original-To: linaro@patches.linaro.org Delivered-To: linaro@patches.linaro.org Received: from mail-ee0-f70.google.com (mail-ee0-f70.google.com [74.125.83.70]) by ip-10-151-82-157.ec2.internal (Postfix) with ESMTPS id C75CA20490 for ; Thu, 3 Apr 2014 20:44:40 +0000 (UTC) Received: by mail-ee0-f70.google.com with SMTP id t10sf2567856eei.5 for ; Thu, 03 Apr 2014 13:44:39 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:delivered-to:from:to:date:message-id:in-reply-to :references:cc:subject:precedence:list-id:list-unsubscribe:list-post :list-help:list-subscribe:mime-version:sender:errors-to :x-original-sender:x-original-authentication-results:mailing-list :list-archive:content-type:content-transfer-encoding; bh=NmKHgynhA3mld18NYQQpUs1WLHZhU9XQdWT2V4qgdbQ=; b=GlnK01eLFDMtRRmlEQotXbC9HaoyGNhFZJF1MM9/S8hE9rzzYETXQNwoOT7YfkTI+p Zt3xTNB+/HuIvJNDbf/c4z24M6gadYE94GdrkaDYqg1dDQbgBl9uKEaP+pynzA0y2AoZ jVZKKkbBi4cN5WrjAfWFV/q9b2MurXZayY63QL1HfRSXaiLSiKdq6jqAnqrgbW1DTz4S tj+ch8etc8fqukdrlRnFmJ2Dgqmkr9aW89B0asD5ISiP7gAuQVJBrPgZsR07V3Bg6Xeq 65tKyLzh8bLo2zJ2g7BWQD6V66lJn8xhGPal+Pk6/u0X/84KB4Kz8wwkQKit6eceH3ta i8/w== X-Gm-Message-State: ALoCoQnsucFQXndsLHcm+YsIGcndq9GzHsbvJTQhONKnkLgeWhxHZcn+72LvcgUaaEONvoUE3uUx X-Received: by 10.180.10.129 with SMTP id i1mr2689517wib.5.1396557879710; Thu, 03 Apr 2014 13:44:39 -0700 (PDT) X-BeenThere: patchwork-forward@linaro.org Received: by 10.140.104.116 with SMTP id z107ls665955qge.37.gmail; Thu, 03 Apr 2014 13:44:39 -0700 (PDT) X-Received: by 10.58.161.101 with SMTP id xr5mr493099veb.36.1396557879614; Thu, 03 Apr 2014 13:44:39 -0700 (PDT) Received: from mail-ve0-f174.google.com (mail-ve0-f174.google.com [209.85.128.174]) by mx.google.com with ESMTPS id u5si1420975vdo.40.2014.04.03.13.44.39 for (version=TLSv1 cipher=ECDHE-RSA-RC4-SHA bits=128/128); Thu, 03 Apr 2014 13:44:39 -0700 (PDT) Received-SPF: neutral (google.com: 209.85.128.174 is neither permitted nor denied by best guess record for domain of patch+caf_=patchwork-forward=linaro.org@linaro.org) client-ip=209.85.128.174; Received: by mail-ve0-f174.google.com with SMTP id oz11so706066veb.5 for ; Thu, 03 Apr 2014 13:44:39 -0700 (PDT) X-Received: by 10.59.7.102 with SMTP id db6mr1406836ved.17.1396557879530; Thu, 03 Apr 2014 13:44:39 -0700 (PDT) X-Forwarded-To: patchwork-forward@linaro.org X-Forwarded-For: patch@linaro.org patchwork-forward@linaro.org Delivered-To: patch@linaro.org Received: by 10.220.12.8 with SMTP id v8csp59822vcv; Thu, 3 Apr 2014 13:44:38 -0700 (PDT) X-Received: by 10.58.31.136 with SMTP id a8mr1411799vei.20.1396557878762; Thu, 03 Apr 2014 13:44:38 -0700 (PDT) Received: from lists.xen.org (lists.xen.org. [50.57.142.19]) by mx.google.com with ESMTPS id la9si406935veb.38.2014.04.03.13.44.38 for (version=TLSv1 cipher=RC4-SHA bits=128/128); Thu, 03 Apr 2014 13:44:38 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of xen-devel-bounces@lists.xen.org designates 50.57.142.19 as permitted sender) client-ip=50.57.142.19; Received: from localhost ([127.0.0.1] helo=lists.xen.org) by lists.xen.org with esmtp (Exim 4.72) (envelope-from ) id 1WVoSz-0008BE-SM; Thu, 03 Apr 2014 20:42:29 +0000 Received: from mail6.bemta3.messagelabs.com ([195.245.230.39]) by lists.xen.org with esmtp (Exim 4.72) (envelope-from ) id 1WVoSy-0008As-F0 for xen-devel@lists.xenproject.org; Thu, 03 Apr 2014 20:42:28 +0000 Received: from [85.158.137.68:48286] by server-9.bemta-3.messagelabs.com id 0D/31-30063-3B7CD335; Thu, 03 Apr 2014 20:42:27 +0000 X-Env-Sender: julien.grall@linaro.org X-Msg-Ref: server-11.tower-31.messagelabs.com!1396557746!4877244!1 X-Originating-IP: [74.125.82.45] X-SpamReason: No, hits=0.0 required=7.0 tests= X-StarScan-Received: X-StarScan-Version: 6.11.1; banners=-,-,- X-VirusChecked: Checked Received: (qmail 13607 invoked from network); 3 Apr 2014 20:42:27 -0000 Received: from mail-wg0-f45.google.com (HELO mail-wg0-f45.google.com) (74.125.82.45) by server-11.tower-31.messagelabs.com with RC4-SHA encrypted SMTP; 3 Apr 2014 20:42:27 -0000 Received: by mail-wg0-f45.google.com with SMTP id l18so2454551wgh.28 for ; Thu, 03 Apr 2014 13:42:26 -0700 (PDT) X-Received: by 10.194.84.144 with SMTP id z16mr13898483wjy.23.1396557746603; Thu, 03 Apr 2014 13:42:26 -0700 (PDT) Received: from belegaer.uk.xensource.com ([185.25.64.249]) by mx.google.com with ESMTPSA id t50sm14510572eev.28.2014.04.03.13.42.25 for (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Thu, 03 Apr 2014 13:42:26 -0700 (PDT) From: Julien Grall To: xen-devel@lists.xenproject.org Date: Thu, 3 Apr 2014 21:41:53 +0100 Message-Id: <1396557727-19102-3-git-send-email-julien.grall@linaro.org> X-Mailer: git-send-email 1.7.10.4 In-Reply-To: <1396557727-19102-1-git-send-email-julien.grall@linaro.org> References: <1396557727-19102-1-git-send-email-julien.grall@linaro.org> Cc: stefano.stabellini@citrix.com, Julien Grall , tim@xen.org, ian.campbell@citrix.com Subject: [Xen-devel] [PATCH v2 02/16] xen/arm: IRQ: Use default irq callback from common code for no_irq_type X-BeenThere: xen-devel@lists.xen.org X-Mailman-Version: 2.1.13 Precedence: list List-Id: List-Unsubscribe: , List-Post: , List-Help: , List-Subscribe: , MIME-Version: 1.0 Sender: xen-devel-bounces@lists.xen.org Errors-To: xen-devel-bounces@lists.xen.org X-Removed-Original-Auth: Dkim didn't pass. X-Original-Sender: julien.grall@linaro.org X-Original-Authentication-Results: mx.google.com; spf=neutral (google.com: 209.85.128.174 is neither permitted nor denied by best guess record for domain of patch+caf_=patchwork-forward=linaro.org@linaro.org) smtp.mail=patch+caf_=patchwork-forward=linaro.org@linaro.org Mailing-list: list patchwork-forward@linaro.org; contact patchwork-forward+owners@linaro.org X-Google-Group-Id: 836684582541 List-Archive: Most of no_irq_type callback are already defined in common/irq.c. We don't need to recreate our own callbacks. Signed-off-by: Julien Grall Acked-by: Ian Campbell --- Changes in v2: - Patch added --- xen/arch/arm/irq.c | 14 +++++--------- 1 file changed, 5 insertions(+), 9 deletions(-) diff --git a/xen/arch/arm/irq.c b/xen/arch/arm/irq.c index 3e326b0..5d1ed7f 100644 --- a/xen/arch/arm/irq.c +++ b/xen/arch/arm/irq.c @@ -27,23 +27,19 @@ #include -static void enable_none(struct irq_desc *irq) { } -static unsigned int startup_none(struct irq_desc *irq) { return 0; } -static void disable_none(struct irq_desc *irq) { } static void ack_none(struct irq_desc *irq) { printk("unexpected IRQ trap at irq %02x\n", irq->irq); } -#define shutdown_none disable_none -#define end_none enable_none +static void end_none(struct irq_desc *irq) { } hw_irq_controller no_irq_type = { .typename = "none", - .startup = startup_none, - .shutdown = shutdown_none, - .enable = enable_none, - .disable = disable_none, + .startup = irq_startup_none, + .shutdown = irq_shutdown_none, + .enable = irq_enable_none, + .disable = irq_disable_none, .ack = ack_none, .end = end_none };