From patchwork Thu Apr 3 17:09:10 2014 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Julien Grall X-Patchwork-Id: 27698 Return-Path: X-Original-To: linaro@patches.linaro.org Delivered-To: linaro@patches.linaro.org Received: from mail-pd0-f198.google.com (mail-pd0-f198.google.com [209.85.192.198]) by ip-10-151-82-157.ec2.internal (Postfix) with ESMTPS id 503B520490 for ; Thu, 3 Apr 2014 17:11:52 +0000 (UTC) Received: by mail-pd0-f198.google.com with SMTP id fp1sf6890228pdb.5 for ; Thu, 03 Apr 2014 10:11:51 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:delivered-to:from:to:date:message-id:cc:subject :precedence:list-id:list-unsubscribe:list-post:list-help :list-subscribe:mime-version:sender:errors-to:x-original-sender :x-original-authentication-results:mailing-list:list-archive :content-type:content-transfer-encoding; bh=yozUNkfhU4I5r0rKf2n/ODwuo+kX4wlCynbcnHpp1z0=; b=CadBXyUlZ7Gp8xXnc/SeOb+Aceo4ZbC9VLhL8L8+H7znFrARUGoIG9Fbg7HNEZs/Vh A/b+AkPQZd186gVjOVO+xNYzjEyHOJt6BppeQneNBvcJyMNrTMW5vbCN2Ks+Foz0Qr26 JqCwf5CHEJOWDOQ/5UoeAww35Dvrf9gYenba1QTi7nOyW+vEYBrOPU9MIcQSliVYI8QW 910CPz6fjoKLE0lKpXb0NgdWQyQ8MmuTJhLaCqoZAWG6LLwrwVGDb9VXsZSnqtI3a0pM wu+kLlLAwIchD8FRS8PFxF/gjR0JRWeL9WnY6SMoGlXK6jDiybBw0HfRC7D2FpO1RxfV V73A== X-Gm-Message-State: ALoCoQn76Z1pa7WchraQjMaYe+Ayxqsjr6ykpIl3LGV6bF+62Mj5li/z/k/514nlebiOnh0lJu7Z X-Received: by 10.67.4.202 with SMTP id cg10mr1586841pad.42.1396545111539; Thu, 03 Apr 2014 10:11:51 -0700 (PDT) X-BeenThere: patchwork-forward@linaro.org Received: by 10.140.21.213 with SMTP id 79ls698710qgl.35.gmail; Thu, 03 Apr 2014 10:11:51 -0700 (PDT) X-Received: by 10.220.98.196 with SMTP id r4mr1189376vcn.9.1396545111441; Thu, 03 Apr 2014 10:11:51 -0700 (PDT) Received: from mail-ve0-f182.google.com (mail-ve0-f182.google.com [209.85.128.182]) by mx.google.com with ESMTPS id tv3si1341128vdc.54.2014.04.03.10.11.51 for (version=TLSv1 cipher=ECDHE-RSA-RC4-SHA bits=128/128); Thu, 03 Apr 2014 10:11:51 -0700 (PDT) Received-SPF: neutral (google.com: 209.85.128.182 is neither permitted nor denied by best guess record for domain of patch+caf_=patchwork-forward=linaro.org@linaro.org) client-ip=209.85.128.182; Received: by mail-ve0-f182.google.com with SMTP id jw12so492044veb.41 for ; Thu, 03 Apr 2014 10:11:51 -0700 (PDT) X-Received: by 10.220.103.141 with SMTP id k13mr3785737vco.25.1396545111366; Thu, 03 Apr 2014 10:11:51 -0700 (PDT) X-Forwarded-To: patchwork-forward@linaro.org X-Forwarded-For: patch@linaro.org patchwork-forward@linaro.org Delivered-To: patch@linaro.org Received: by 10.220.12.8 with SMTP id v8csp45571vcv; Thu, 3 Apr 2014 10:11:50 -0700 (PDT) X-Received: by 10.50.28.84 with SMTP id z20mr16747729igg.0.1396545109837; Thu, 03 Apr 2014 10:11:49 -0700 (PDT) Received: from lists.xen.org (lists.xen.org. [50.57.142.19]) by mx.google.com with ESMTPS id 5si5469022igr.0.2014.04.03.10.11.49 for (version=TLSv1 cipher=RC4-SHA bits=128/128); Thu, 03 Apr 2014 10:11:49 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of xen-devel-bounces@lists.xen.org designates 50.57.142.19 as permitted sender) client-ip=50.57.142.19; Received: from localhost ([127.0.0.1] helo=lists.xen.org) by lists.xen.org with esmtp (Exim 4.72) (envelope-from ) id 1WVl8f-0002be-Uy; Thu, 03 Apr 2014 17:09:17 +0000 Received: from mail6.bemta14.messagelabs.com ([193.109.254.103]) by lists.xen.org with esmtp (Exim 4.72) (envelope-from ) id 1WVl8d-0002bZ-VA for xen-devel@lists.xenproject.org; Thu, 03 Apr 2014 17:09:16 +0000 Received: from [193.109.254.147:47914] by server-1.bemta-14.messagelabs.com id 17/A1-00839-BB59D335; Thu, 03 Apr 2014 17:09:15 +0000 X-Env-Sender: julien.grall@linaro.org X-Msg-Ref: server-6.tower-27.messagelabs.com!1396544954!6128212!1 X-Originating-IP: [74.125.82.45] X-SpamReason: No, hits=0.0 required=7.0 tests= X-StarScan-Received: X-StarScan-Version: 6.11.1; banners=-,-,- X-VirusChecked: Checked Received: (qmail 27869 invoked from network); 3 Apr 2014 17:09:14 -0000 Received: from mail-wg0-f45.google.com (HELO mail-wg0-f45.google.com) (74.125.82.45) by server-6.tower-27.messagelabs.com with RC4-SHA encrypted SMTP; 3 Apr 2014 17:09:14 -0000 Received: by mail-wg0-f45.google.com with SMTP id l18so2191200wgh.4 for ; Thu, 03 Apr 2014 10:09:14 -0700 (PDT) X-Received: by 10.180.189.169 with SMTP id gj9mr39768806wic.17.1396544953962; Thu, 03 Apr 2014 10:09:13 -0700 (PDT) Received: from belegaer.uk.xensource.com ([185.25.64.249]) by mx.google.com with ESMTPSA id m44sm13323834eep.14.2014.04.03.10.09.12 for (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Thu, 03 Apr 2014 10:09:13 -0700 (PDT) From: Julien Grall To: xen-devel@lists.xenproject.org Date: Thu, 3 Apr 2014 18:09:10 +0100 Message-Id: <1396544950-21909-1-git-send-email-julien.grall@linaro.org> X-Mailer: git-send-email 1.7.10.4 Cc: stefano.stabellini@citrix.com, Julien Grall , tim@xen.org, ian.campbell@citrix.com Subject: [Xen-devel] [PATCH] xen/arm32: __cmpxchg_mb should be marked always_inline X-BeenThere: xen-devel@lists.xen.org X-Mailman-Version: 2.1.13 Precedence: list List-Id: List-Unsubscribe: , List-Post: , List-Help: , List-Subscribe: , MIME-Version: 1.0 Sender: xen-devel-bounces@lists.xen.org Errors-To: xen-devel-bounces@lists.xen.org X-Removed-Original-Auth: Dkim didn't pass. X-Original-Sender: julien.grall@linaro.org X-Original-Authentication-Results: mx.google.com; spf=neutral (google.com: 209.85.128.182 is neither permitted nor denied by best guess record for domain of patch+caf_=patchwork-forward=linaro.org@linaro.org) smtp.mail=patch+caf_=patchwork-forward=linaro.org@linaro.org Mailing-list: list patchwork-forward@linaro.org; contact patchwork-forward+owners@linaro.org X-Google-Group-Id: 836684582541 List-Archive: Currently __cmpxchg_mb is only marked inline. The compiler can decide to not inline this function. In this case, the call to __cmpxchg will be inlined but not optimised. This will result linking failure because of __bad_cmpxchg. Catched by clang 3.5. Acked-by: Ian Campbell Signed-off-by: Julien Grall --- xen/include/asm-arm/arm32/cmpxchg.h | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/xen/include/asm-arm/arm32/cmpxchg.h b/xen/include/asm-arm/arm32/cmpxchg.h index 70c6090..3f4e7a1 100644 --- a/xen/include/asm-arm/arm32/cmpxchg.h +++ b/xen/include/asm-arm/arm32/cmpxchg.h @@ -112,8 +112,9 @@ static always_inline unsigned long __cmpxchg( return oldval; } -static inline unsigned long __cmpxchg_mb(volatile void *ptr, unsigned long old, - unsigned long new, int size) +static always_inline unsigned long __cmpxchg_mb(volatile void *ptr, + unsigned long old, + unsigned long new, int size) { unsigned long ret;