From patchwork Thu Mar 20 17:04:59 2014 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Ian Campbell X-Patchwork-Id: 26741 Return-Path: X-Original-To: linaro@patches.linaro.org Delivered-To: linaro@patches.linaro.org Received: from mail-pa0-f71.google.com (mail-pa0-f71.google.com [209.85.220.71]) by ip-10-151-82-157.ec2.internal (Postfix) with ESMTPS id F127F202E0 for ; Thu, 20 Mar 2014 17:07:08 +0000 (UTC) Received: by mail-pa0-f71.google.com with SMTP id kq14sf2870303pab.10 for ; Thu, 20 Mar 2014 10:07:08 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:delivered-to:message-id:from:to:date:in-reply-to :references:organization:mime-version:cc:subject:precedence:list-id :list-unsubscribe:list-post:list-help:list-subscribe:sender :errors-to:x-original-sender:x-original-authentication-results :mailing-list:list-archive:content-type:content-transfer-encoding; bh=K1V71uhkXTrMdHTFlLWMMMGowGlFnFUr1LYD+oGSFNk=; b=HdCkNwNvVtaXQJ09FsEHPcFejFok+x0cCO+JYP83IFx4IMdqs8ybipQ84wtdR9LPAk 9dUNTIO2L9GR/qyiwMObueUU2po6nLoSwJVhLhJw+hXFgbtijTDQleFxEKakrUJM+1E6 osy9+d2x2azSBME/Sl270uF+GlBlo+HAtbz9nWykdBoLOqGLE1R4qBvttu1xQGSahpsM qTGY/PGw32plJZur/yAV+U2j9Ns9pUYkRJtuMukbPOrAkDIyLDxQFNLXGntAMw6O0xx9 p43kFiUcjP00nwS61IBPK6WLx3U4sl8v3xTlYZi8Do6kVmnB3DJtM8ax9KtVG9k3l6P+ JWXA== X-Gm-Message-State: ALoCoQn6SFjcTvCXPZJIC1x13I2uuboamaDJ8a/uIW7pTnKAPQ/AKcHGnE8EDkicH9jZ8KErX7Cj X-Received: by 10.66.221.137 with SMTP id qe9mr18258047pac.4.1395335228066; Thu, 20 Mar 2014 10:07:08 -0700 (PDT) X-BeenThere: patchwork-forward@linaro.org Received: by 10.140.100.137 with SMTP id s9ls302879qge.57.gmail; Thu, 20 Mar 2014 10:07:07 -0700 (PDT) X-Received: by 10.58.74.201 with SMTP id w9mr726652vev.56.1395335227905; Thu, 20 Mar 2014 10:07:07 -0700 (PDT) Received: from mail-vc0-f174.google.com (mail-vc0-f174.google.com [209.85.220.174]) by mx.google.com with ESMTPS id tr5si571310vdc.90.2014.03.20.10.07.07 for (version=TLSv1 cipher=ECDHE-RSA-RC4-SHA bits=128/128); Thu, 20 Mar 2014 10:07:07 -0700 (PDT) Received-SPF: neutral (google.com: 209.85.220.174 is neither permitted nor denied by best guess record for domain of patch+caf_=patchwork-forward=linaro.org@linaro.org) client-ip=209.85.220.174; Received: by mail-vc0-f174.google.com with SMTP id ld13so1292750vcb.19 for ; Thu, 20 Mar 2014 10:07:07 -0700 (PDT) X-Received: by 10.52.108.164 with SMTP id hl4mr6834141vdb.25.1395335227715; Thu, 20 Mar 2014 10:07:07 -0700 (PDT) X-Forwarded-To: patchwork-forward@linaro.org X-Forwarded-For: patch@linaro.org patchwork-forward@linaro.org Delivered-To: patch@linaro.org Received: by 10.220.78.9 with SMTP id i9csp404586vck; Thu, 20 Mar 2014 10:07:07 -0700 (PDT) X-Received: by 10.52.123.97 with SMTP id lz1mr615272vdb.73.1395335227222; Thu, 20 Mar 2014 10:07:07 -0700 (PDT) Received: from lists.xen.org (lists.xen.org. [50.57.142.19]) by mx.google.com with ESMTPS id ku5si354535vec.136.2014.03.20.10.07.06 for (version=TLSv1 cipher=RC4-SHA bits=128/128); Thu, 20 Mar 2014 10:07:07 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of xen-devel-bounces@lists.xen.org designates 50.57.142.19 as permitted sender) client-ip=50.57.142.19; Received: from localhost ([127.0.0.1] helo=lists.xen.org) by lists.xen.org with esmtp (Exim 4.72) (envelope-from ) id 1WQgPF-00015S-Nf; Thu, 20 Mar 2014 17:05:25 +0000 Received: from mail6.bemta4.messagelabs.com ([85.158.143.247]) by lists.xen.org with esmtp (Exim 4.72) (envelope-from ) id 1WQgPD-000159-RO for xen-devel@lists.xen.org; Thu, 20 Mar 2014 17:05:24 +0000 Received: from [85.158.143.35:32321] by server-1.bemta-4.messagelabs.com id B3/70-09853-3DF1B235; Thu, 20 Mar 2014 17:05:23 +0000 X-Env-Sender: Ian.Campbell@citrix.com X-Msg-Ref: server-12.tower-21.messagelabs.com!1395335121!3576589!1 X-Originating-IP: [66.165.176.63] X-SpamReason: No, hits=0.0 required=7.0 tests=sa_preprocessor: VHJ1c3RlZCBJUDogNjYuMTY1LjE3Ni42MyA9PiAzMDYwNDg=\n X-StarScan-Received: X-StarScan-Version: 6.11.1; banners=-,-,- X-VirusChecked: Checked Received: (qmail 20087 invoked from network); 20 Mar 2014 17:05:22 -0000 Received: from smtp02.citrix.com (HELO SMTP02.CITRIX.COM) (66.165.176.63) by server-12.tower-21.messagelabs.com with RC4-SHA encrypted SMTP; 20 Mar 2014 17:05:22 -0000 X-IronPort-AV: E=Sophos;i="4.97,695,1389744000"; d="scan'208";a="111970256" Received: from accessns.citrite.net (HELO FTLPEX01CL02.citrite.net) ([10.9.154.239]) by FTLPIPO02.CITRIX.COM with ESMTP; 20 Mar 2014 17:05:03 +0000 Received: from [10.80.2.80] (10.80.2.80) by FTLPEX01CL02.citrite.net (10.13.107.79) with Microsoft SMTP Server id 14.2.342.4; Thu, 20 Mar 2014 13:05:01 -0400 Message-ID: <1395335099.3104.41.camel@kazak.uk.xensource.com> From: Ian Campbell To: Aravind Gopalakrishnan Date: Thu, 20 Mar 2014 17:04:59 +0000 In-Reply-To: <1395334073.3104.36.camel@kazak.uk.xensource.com> References: <1393362687-6530-1-git-send-email-Aravind.Gopalakrishnan@amd.com> <1395334073.3104.36.camel@kazak.uk.xensource.com> Organization: Citrix Systems, Inc. X-Mailer: Evolution 3.4.4-3 MIME-Version: 1.0 X-Originating-IP: [10.80.2.80] X-DLP: MIA2 Cc: Thomas Lendacky , keir@xen.org, Suravee Suthikulpanit , Anup Patel , andrew.cooper3@citrix.com, xen-devel@lists.xen.org, Julien Grall , Stefano Stabellini , jbeulich@suse.com, sherry.hurwitz@amd.com, shurd@broadcom.com, Pranavkumar Sawargaonkar Subject: [Xen-devel] [PATCH] ns16550: setup default lsr_mask for DT systems too (Was: Re: [PATCH V8 RESEND] ns16550: Add support for UART present in Broadcom TruManage capable NetXtreme chips) X-BeenThere: xen-devel@lists.xen.org X-Mailman-Version: 2.1.13 Precedence: list List-Id: List-Unsubscribe: , List-Post: , List-Help: , List-Subscribe: , Sender: xen-devel-bounces@lists.xen.org Errors-To: xen-devel-bounces@lists.xen.org X-Removed-Original-Auth: Dkim didn't pass. X-Original-Sender: ian.campbell@citrix.com X-Original-Authentication-Results: mx.google.com; spf=neutral (google.com: 209.85.220.174 is neither permitted nor denied by best guess record for domain of patch+caf_=patchwork-forward=linaro.org@linaro.org) smtp.mail=patch+caf_=patchwork-forward=linaro.org@linaro.org Mailing-list: list patchwork-forward@linaro.org; contact patchwork-forward+owners@linaro.org X-Google-Group-Id: 836684582541 List-Archive: On Thu, 2014-03-20 at 16:47 +0000, Ian Campbell wrote: > Unfortunately this patch breaks the console on the arm64 x-gene > platform, it drops a fairly large subset of the characters. > > I'm not sure why yet. The simple fix is below. I'm going to take a look at making ns16550_init and ns16550_uart_dt_init share a common function for setting up the defaults, but for now I'd appreciate getting this bandaid in. Ian. ------8<---------------- >From 4fc6d9c71ae6b40940040910e27ba0f5272a2f27 Mon Sep 17 00:00:00 2001 From: Ian Campbell Date: Thu, 20 Mar 2014 17:02:52 +0000 Subject: [PATCH] ns16550: setup default lsr_mask for DT systems too Signed-off-by: Ian Campbell Acked-by: Julien Grall Reviewed-by: Konrad Rzeszutek Wilk Tested-By: Pranavkumar Sawargaonkar Tested-By: Chen Baozi --- xen/drivers/char/ns16550.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/xen/drivers/char/ns16550.c b/xen/drivers/char/ns16550.c index 429d786..2dd32b2 100644 --- a/xen/drivers/char/ns16550.c +++ b/xen/drivers/char/ns16550.c @@ -1129,6 +1129,8 @@ static int __init ns16550_uart_dt_init(struct dt_device_node *dev, uart->stop_bits = 1; /* Default is no transmit FIFO. */ uart->fifo_size = 1; + /* Default lsr_mask = UART_LSR_THRE */ + uart->lsr_mask = UART_LSR_THRE; res = dt_device_get_address(dev, 0, &uart->io_base, &io_size); if ( res )