From patchwork Wed Mar 19 23:42:16 2014 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Julien Grall X-Patchwork-Id: 26615 Return-Path: X-Original-To: linaro@patches.linaro.org Delivered-To: linaro@patches.linaro.org Received: from mail-pb0-f70.google.com (mail-pb0-f70.google.com [209.85.160.70]) by ip-10-151-82-157.ec2.internal (Postfix) with ESMTPS id D85F0203C3 for ; Wed, 19 Mar 2014 23:45:02 +0000 (UTC) Received: by mail-pb0-f70.google.com with SMTP id rp16sf201572pbb.5 for ; Wed, 19 Mar 2014 16:45:01 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:delivered-to:from:to:date:message-id:cc:subject :precedence:list-id:list-unsubscribe:list-post:list-help :list-subscribe:mime-version:sender:errors-to:x-original-sender :x-original-authentication-results:mailing-list:list-archive :content-type:content-transfer-encoding; bh=kC0kKoUL/eCMUoRIrNHVN22Qlx/zL8k4PFY8hp708Lw=; b=lLXfynpdxannlZoYb4srHGGKFftvuD1KrjbcFBhUuQ6lcYJjYOZu2710jMJij/9JzD lftia143Sb/b+iBoea8UIOwzkBZ3MQP6ShoGIOs/5kkzKCtt1+RA/M5OdmekR1C7evyS O0yDtY/NxdU/wKnO9luuI14BW0L8G4AP9K9cJCKN073jpkZFy6Ztyi0PdwLxTZB/YNjc 4fe1QJukHKzYA2UKA+hoplV87Jv9irFD9SId7V22d9cBMThxYQok2HIAsHKf24qwdYmQ yOgUoC714ALNTTjLV4FQlH1mu/nSgfCgq9sGu5fgS4WmbnZYDKHWmIH7XKxWX+7j4Ott MgUw== X-Gm-Message-State: ALoCoQmC/+oPY225sZl2l0UFTBYB+OMHRf7YeqTUNk9MojG3ri39SY6+fQhXkw3hl/18K76wWZDq X-Received: by 10.66.144.228 with SMTP id sp4mr15858085pab.5.1395272701582; Wed, 19 Mar 2014 16:45:01 -0700 (PDT) X-BeenThere: patchwork-forward@linaro.org Received: by 10.140.95.230 with SMTP id i93ls24822qge.28.gmail; Wed, 19 Mar 2014 16:45:01 -0700 (PDT) X-Received: by 10.220.103.141 with SMTP id k13mr3538993vco.25.1395272701430; Wed, 19 Mar 2014 16:45:01 -0700 (PDT) Received: from mail-ve0-f170.google.com (mail-ve0-f170.google.com [209.85.128.170]) by mx.google.com with ESMTPS id sq9si29819vdc.53.2014.03.19.16.45.01 for (version=TLSv1 cipher=ECDHE-RSA-RC4-SHA bits=128/128); Wed, 19 Mar 2014 16:45:01 -0700 (PDT) Received-SPF: neutral (google.com: 209.85.128.170 is neither permitted nor denied by best guess record for domain of patch+caf_=patchwork-forward=linaro.org@linaro.org) client-ip=209.85.128.170; Received: by mail-ve0-f170.google.com with SMTP id pa12so75879veb.15 for ; Wed, 19 Mar 2014 16:45:01 -0700 (PDT) X-Received: by 10.220.159.4 with SMTP id h4mr21120100vcx.1.1395272701357; Wed, 19 Mar 2014 16:45:01 -0700 (PDT) X-Forwarded-To: patchwork-forward@linaro.org X-Forwarded-For: patch@linaro.org patchwork-forward@linaro.org Delivered-To: patch@linaro.org Received: by 10.220.78.9 with SMTP id i9csp343904vck; Wed, 19 Mar 2014 16:45:01 -0700 (PDT) X-Received: by 10.52.242.167 with SMTP id wr7mr2735147vdc.32.1395272700960; Wed, 19 Mar 2014 16:45:00 -0700 (PDT) Received: from lists.xen.org (lists.xen.org. [50.57.142.19]) by mx.google.com with ESMTPS id u5si20158vdo.166.2014.03.19.16.45.00 for (version=TLSv1 cipher=RC4-SHA bits=128/128); Wed, 19 Mar 2014 16:45:00 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of xen-devel-bounces@lists.xen.org designates 50.57.142.19 as permitted sender) client-ip=50.57.142.19; Received: from localhost ([127.0.0.1] helo=lists.xen.org) by lists.xen.org with esmtp (Exim 4.72) (envelope-from ) id 1WQQ7q-0005F9-HY; Wed, 19 Mar 2014 23:42:22 +0000 Received: from mail6.bemta5.messagelabs.com ([195.245.231.135]) by lists.xen.org with esmtp (Exim 4.72) (envelope-from ) id 1WQQ7p-0005Et-ER for xen-devel@lists.xenproject.org; Wed, 19 Mar 2014 23:42:21 +0000 Received: from [85.158.139.211:60760] by server-9.bemta-5.messagelabs.com id 12/68-04350-C5B2A235; Wed, 19 Mar 2014 23:42:20 +0000 X-Env-Sender: julien.grall@linaro.org X-Msg-Ref: server-13.tower-206.messagelabs.com!1395272539!2131999!1 X-Originating-IP: [74.125.83.53] X-SpamReason: No, hits=0.0 required=7.0 tests= X-StarScan-Received: X-StarScan-Version: 6.11.1; banners=-,-,- X-VirusChecked: Checked Received: (qmail 3337 invoked from network); 19 Mar 2014 23:42:19 -0000 Received: from mail-ee0-f53.google.com (HELO mail-ee0-f53.google.com) (74.125.83.53) by server-13.tower-206.messagelabs.com with RC4-SHA encrypted SMTP; 19 Mar 2014 23:42:19 -0000 Received: by mail-ee0-f53.google.com with SMTP id b57so39145eek.40 for ; Wed, 19 Mar 2014 16:42:19 -0700 (PDT) X-Received: by 10.15.10.135 with SMTP id g7mr23301431eet.72.1395272539192; Wed, 19 Mar 2014 16:42:19 -0700 (PDT) Received: from belegaer.uk.xensource.com. ([185.25.64.249]) by mx.google.com with ESMTPSA id cb5sm223092eeb.18.2014.03.19.16.42.17 for (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Wed, 19 Mar 2014 16:42:18 -0700 (PDT) From: Julien Grall To: xen-devel@lists.xenproject.org Date: Wed, 19 Mar 2014 23:42:16 +0000 Message-Id: <1395272536-5157-1-git-send-email-julien.grall@linaro.org> X-Mailer: git-send-email 1.7.10.4 Cc: stefano.stabellini@citrix.com, Julien Grall , ian.jackson@eu.citrix.com, ian.campbell@citrix.com Subject: [Xen-devel] [PATCH] tools/libxl: Correctly check if libxl_get_scheduler has failed X-BeenThere: xen-devel@lists.xen.org X-Mailman-Version: 2.1.13 Precedence: list List-Id: List-Unsubscribe: , List-Post: , List-Help: , List-Subscribe: , MIME-Version: 1.0 Sender: xen-devel-bounces@lists.xen.org Errors-To: xen-devel-bounces@lists.xen.org X-Removed-Original-Auth: Dkim didn't pass. X-Original-Sender: julien.grall@linaro.org X-Original-Authentication-Results: mx.google.com; spf=neutral (google.com: 209.85.128.170 is neither permitted nor denied by best guess record for domain of patch+caf_=patchwork-forward=linaro.org@linaro.org) smtp.mail=patch+caf_=patchwork-forward=linaro.org@linaro.org Mailing-list: list patchwork-forward@linaro.org; contact patchwork-forward+owners@linaro.org X-Google-Group-Id: 836684582541 List-Archive: libxl_get_scheduler will return an enum, therefore checking if the value is negative is wrong. Both GCC and clang will never go to the error case. Spotted by clang: xl_cmdimpl.c:6709:48: error: comparison of unsigned enum expression < 0 is always false [-Werror,-Wtautological-compare] if ((sched = libxl_get_scheduler(ctx)) < 0) { ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ ^ ~ Signed-off-by: Julien Grall --- I'm not sure this is the right way to test if libxl_get_scheduler has failed. This small program should print ERROR, but on both clang and gcc it will print OK. #include typedef enum libxl_error { ERROR_FAIL = -3, } libxl_error; typedef enum libxl_sched { SCHED_SCHED, } libxl_sched; libxl_sched f(void) { return ERROR_FAIL; } int main(void) { printf("f() = %d\n", f()); if ( f() < 0 ) printf("ERROR\n"); else printf("OK\n"); return 0; } --- tools/libxl/xl_cmdimpl.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/tools/libxl/xl_cmdimpl.c b/tools/libxl/xl_cmdimpl.c index 8990020..8f6c411 100644 --- a/tools/libxl/xl_cmdimpl.c +++ b/tools/libxl/xl_cmdimpl.c @@ -4826,7 +4826,7 @@ static void output_xeninfo(void) return; } - if ((sched = libxl_get_scheduler(ctx)) < 0) { + if ((int)(sched = libxl_get_scheduler(ctx)) < 0) { fprintf(stderr, "get_scheduler sysctl failed.\n"); return; } @@ -6706,7 +6706,7 @@ int main_cpupoolcreate(int argc, char **argv) goto out_cfg; } } else { - if ((sched = libxl_get_scheduler(ctx)) < 0) { + if ((int)(sched = libxl_get_scheduler(ctx)) < 0) { fprintf(stderr, "get_scheduler sysctl failed.\n"); goto out_cfg; }