From patchwork Wed Mar 12 16:16:07 2014 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Julien Grall X-Patchwork-Id: 26143 Return-Path: X-Original-To: linaro@patches.linaro.org Delivered-To: linaro@patches.linaro.org Received: from mail-ob0-f197.google.com (mail-ob0-f197.google.com [209.85.214.197]) by ip-10-151-82-157.ec2.internal (Postfix) with ESMTPS id 64B75203AB for ; Wed, 12 Mar 2014 16:17:42 +0000 (UTC) Received: by mail-ob0-f197.google.com with SMTP id wp18sf39580508obc.8 for ; Wed, 12 Mar 2014 09:17:41 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:delivered-to:from:to:date:message-id:in-reply-to :references:cc:subject:precedence:list-id:list-unsubscribe:list-post :list-help:list-subscribe:mime-version:sender:errors-to :x-original-sender:x-original-authentication-results:mailing-list :list-archive:content-type:content-transfer-encoding; bh=jwJqB7u9UpjuE4uFsPhrqeOS9nmTWhyxF8TVtJHl2wo=; b=ErcjUk8PExAwTA79kPnslYqv6yCXi+pfXQTDRMedotNTCP0KzJQZzX7SlZOMPeWMVr Jz6n3aCq7nG52tBx38WQW3DwL8iBNzNWlI+PPSAN/ZBza/3ShwAqDJXba3iwIjjSQMdU Lf/6hCuehR6o0sSHFPJI0GmR7FaUDnRfQ3vf+gRQwXq34mRZdrnGA2qgikqGdMP7B/Ax TVTrRwrIvhldGnPxg7F71IY1VrTC8ZwRYhk82QyecBj8XuOHekqh8wrTA79HT98k7m6q 6WDw2922gpVdB9SDeWqMOBefhZn99ZlR43u/+pyacAOQpJ+Wg/cbYH2j12tUWSnocjuV bHaA== X-Gm-Message-State: ALoCoQlUI8V+kz9sOXbeL9VbHiWVMfbasbKvU4nJxCORHZ2K9zLXMg1gPg5q/tiNhgbXjSxoW04m X-Received: by 10.50.2.39 with SMTP id 7mr6353331igr.1.1394641061956; Wed, 12 Mar 2014 09:17:41 -0700 (PDT) X-BeenThere: patchwork-forward@linaro.org Received: by 10.140.22.7 with SMTP id 7ls2853751qgm.46.gmail; Wed, 12 Mar 2014 09:17:41 -0700 (PDT) X-Received: by 10.58.161.101 with SMTP id xr5mr776584veb.36.1394641061813; Wed, 12 Mar 2014 09:17:41 -0700 (PDT) Received: from mail-ve0-f181.google.com (mail-ve0-f181.google.com [209.85.128.181]) by mx.google.com with ESMTPS id tg3si6964834vec.71.2014.03.12.09.17.41 for (version=TLSv1 cipher=ECDHE-RSA-RC4-SHA bits=128/128); Wed, 12 Mar 2014 09:17:41 -0700 (PDT) Received-SPF: neutral (google.com: 209.85.128.181 is neither permitted nor denied by best guess record for domain of patch+caf_=patchwork-forward=linaro.org@linaro.org) client-ip=209.85.128.181; Received: by mail-ve0-f181.google.com with SMTP id oy12so10522441veb.12 for ; Wed, 12 Mar 2014 09:17:41 -0700 (PDT) X-Received: by 10.220.188.70 with SMTP id cz6mr26471vcb.59.1394641061720; Wed, 12 Mar 2014 09:17:41 -0700 (PDT) X-Forwarded-To: patchwork-forward@linaro.org X-Forwarded-For: patch@linaro.org patchwork-forward@linaro.org Delivered-To: patch@linaro.org Received: by 10.220.78.9 with SMTP id i9csp301310vck; Wed, 12 Mar 2014 09:17:41 -0700 (PDT) X-Received: by 10.140.50.46 with SMTP id r43mr53367183qga.22.1394641061326; Wed, 12 Mar 2014 09:17:41 -0700 (PDT) Received: from lists.xen.org (lists.xen.org. [50.57.142.19]) by mx.google.com with ESMTPS id 32si1023928qgz.31.2014.03.12.09.17.40 for (version=TLSv1 cipher=RC4-SHA bits=128/128); Wed, 12 Mar 2014 09:17:41 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of xen-devel-bounces@lists.xen.org designates 50.57.142.19 as permitted sender) client-ip=50.57.142.19; Received: from localhost ([127.0.0.1] helo=lists.xen.org) by lists.xen.org with esmtp (Exim 4.72) (envelope-from ) id 1WNlpi-0007TW-JZ; Wed, 12 Mar 2014 16:16:42 +0000 Received: from mail6.bemta4.messagelabs.com ([85.158.143.247]) by lists.xen.org with esmtp (Exim 4.72) (envelope-from ) id 1WNlph-0007Ru-3n for xen-devel@lists.xenproject.org; Wed, 12 Mar 2014 16:16:41 +0000 Received: from [85.158.143.35:53972] by server-3.bemta-4.messagelabs.com id 3A/CC-13602-86880235; Wed, 12 Mar 2014 16:16:40 +0000 X-Env-Sender: julien.grall@linaro.org X-Msg-Ref: server-5.tower-21.messagelabs.com!1394640999!1620171!1 X-Originating-IP: [74.125.82.177] X-SpamReason: No, hits=0.0 required=7.0 tests= X-StarScan-Received: X-StarScan-Version: 6.11.1; banners=-,-,- X-VirusChecked: Checked Received: (qmail 8156 invoked from network); 12 Mar 2014 16:16:39 -0000 Received: from mail-we0-f177.google.com (HELO mail-we0-f177.google.com) (74.125.82.177) by server-5.tower-21.messagelabs.com with RC4-SHA encrypted SMTP; 12 Mar 2014 16:16:39 -0000 Received: by mail-we0-f177.google.com with SMTP id u57so11301155wes.22 for ; Wed, 12 Mar 2014 09:16:39 -0700 (PDT) X-Received: by 10.180.12.14 with SMTP id u14mr8552670wib.0.1394640999395; Wed, 12 Mar 2014 09:16:39 -0700 (PDT) Received: from belegaer.uk.xensource.com. ([185.25.64.249]) by mx.google.com with ESMTPSA id dk9sm70840335wjb.4.2014.03.12.09.16.37 for (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Wed, 12 Mar 2014 09:16:38 -0700 (PDT) From: Julien Grall To: xen-devel@lists.xenproject.org Date: Wed, 12 Mar 2014 16:16:07 +0000 Message-Id: <1394640969-25583-13-git-send-email-julien.grall@linaro.org> X-Mailer: git-send-email 1.7.10.4 In-Reply-To: <1394640969-25583-1-git-send-email-julien.grall@linaro.org> References: <1394640969-25583-1-git-send-email-julien.grall@linaro.org> Cc: Keir Fraser , ian.campbell@citrix.com, Julien Grall , tim@xen.org, stefano.stabellini@citrix.com, Jan Beulich , Daniel De Graaf Subject: [Xen-devel] [RFC 12/14] xen/xsm: Don't use multiboot by default to initialize XSM X-BeenThere: xen-devel@lists.xen.org X-Mailman-Version: 2.1.13 Precedence: list List-Id: List-Unsubscribe: , List-Post: , List-Help: , List-Subscribe: , MIME-Version: 1.0 Sender: xen-devel-bounces@lists.xen.org Errors-To: xen-devel-bounces@lists.xen.org X-Removed-Original-Auth: Dkim didn't pass. X-Original-Sender: julien.grall@linaro.org X-Original-Authentication-Results: mx.google.com; spf=neutral (google.com: 209.85.128.181 is neither permitted nor denied by best guess record for domain of patch+caf_=patchwork-forward=linaro.org@linaro.org) smtp.mail=patch+caf_=patchwork-forward=linaro.org@linaro.org Mailing-list: list patchwork-forward@linaro.org; contact patchwork-forward+owners@linaro.org X-Google-Group-Id: 836684582541 List-Archive: Multiboot protocol is only used by x86. When XSM support for ARM will be introduced, another way will be used to retrieve the policy blob. Introduce CONFIG_MULTIBOOT to compile XSM specific multiboot code and rename xsm_init into xsm_multiboot_init to avoid confusion. Signed-off-by: Julien Grall Cc: Keir Fraser Cc: Jan Beulich Cc: Daniel De Graaf Acked-by: Jan Beulich Acked-by: Daniel De Graaf --- xen/arch/x86/setup.c | 2 +- xen/include/asm-x86/config.h | 2 ++ xen/include/xsm/xsm.h | 23 +++++++++++++++-------- xen/xsm/xsm_core.c | 9 ++++++--- xen/xsm/xsm_policy.c | 10 +++++++--- 5 files changed, 31 insertions(+), 15 deletions(-) diff --git a/xen/arch/x86/setup.c b/xen/arch/x86/setup.c index 4dbf2b7..e9c2c51 100644 --- a/xen/arch/x86/setup.c +++ b/xen/arch/x86/setup.c @@ -1251,7 +1251,7 @@ void __init noreturn __start_xen(unsigned long mbi_p) bitmap_fill(module_map, mbi->mods_count); __clear_bit(0, module_map); /* Dom0 kernel is always first */ - xsm_init(module_map, mbi, bootstrap_map); + xsm_multiboot_init(module_map, mbi, bootstrap_map); microcode_grab_module(module_map, mbi, bootstrap_map); diff --git a/xen/include/asm-x86/config.h b/xen/include/asm-x86/config.h index 99d0e2c..24f95a3 100644 --- a/xen/include/asm-x86/config.h +++ b/xen/include/asm-x86/config.h @@ -52,6 +52,8 @@ #define CONFIG_KEXEC 1 #define CONFIG_WATCHDOG 1 +#define CONFIG_MULTIBOOT 1 + #define HZ 100 #define OPT_CONSOLE_STR "vga" diff --git a/xen/include/xsm/xsm.h b/xen/include/xsm/xsm.h index 15acb3b..4863e41 100644 --- a/xen/include/xsm/xsm.h +++ b/xen/include/xsm/xsm.h @@ -643,11 +643,15 @@ static inline int xsm_map_gmfn_foreign (xsm_default_t def, struct domain *d, str #endif /* XSM_NO_WRAPPERS */ -extern int xsm_init(unsigned long *module_map, const multiboot_info_t *mbi, - void *(*bootstrap_map)(const module_t *)); -extern int xsm_policy_init(unsigned long *module_map, - const multiboot_info_t *mbi, - void *(*bootstrap_map)(const module_t *)); +#ifdef CONFIG_MULTIBOOT +extern int xsm_multiboot_init(unsigned long *module_map, + const multiboot_info_t *mbi, + void *(*bootstrap_map)(const module_t *)); +extern int xsm_multiboot_policy_init(unsigned long *module_map, + const multiboot_info_t *mbi, + void *(*bootstrap_map)(const module_t *)); +#endif + extern int register_xsm(struct xsm_operations *ops); extern int unregister_xsm(struct xsm_operations *ops); @@ -658,12 +662,15 @@ extern void xsm_fixup_ops(struct xsm_operations *ops); #include -static inline int xsm_init (unsigned long *module_map, - const multiboot_info_t *mbi, - void *(*bootstrap_map)(const module_t *)) +#ifdef CONFIG_MULTIBOOT +static inline int xsm_multiboot_init (unsigned long *module_map, + const multiboot_info_t *mbi, + void *(*bootstrap_map)(const module_t *)) { return 0; } +#endif + #endif /* XSM_ENABLE */ #endif /* __XSM_H */ diff --git a/xen/xsm/xsm_core.c b/xen/xsm/xsm_core.c index b16c071..11a9ca7 100644 --- a/xen/xsm/xsm_core.c +++ b/xen/xsm/xsm_core.c @@ -43,8 +43,10 @@ static void __init do_xsm_initcalls(void) } } -int __init xsm_init(unsigned long *module_map, const multiboot_info_t *mbi, - void *(*bootstrap_map)(const module_t *)) +#ifdef CONFIG_MULTIBOOT +int __init xsm_multiboot_init(unsigned long *module_map, + const multiboot_info_t *mbi, + void *(*bootstrap_map)(const module_t *)) { int ret = 0; @@ -52,7 +54,7 @@ int __init xsm_init(unsigned long *module_map, const multiboot_info_t *mbi, if ( XSM_MAGIC ) { - ret = xsm_policy_init(module_map, mbi, bootstrap_map); + ret = xsm_multiboot_policy_init(module_map, mbi, bootstrap_map); if ( ret ) { bootstrap_map(NULL); @@ -75,6 +77,7 @@ int __init xsm_init(unsigned long *module_map, const multiboot_info_t *mbi, return 0; } +#endif int register_xsm(struct xsm_operations *ops) { diff --git a/xen/xsm/xsm_policy.c b/xen/xsm/xsm_policy.c index 0186f30..3d5f66a 100644 --- a/xen/xsm/xsm_policy.c +++ b/xen/xsm/xsm_policy.c @@ -19,15 +19,18 @@ */ #include +#ifdef CONFIG_MULTIBOOT #include +#endif #include char *__initdata policy_buffer = NULL; u32 __initdata policy_size = 0; -int __init xsm_policy_init(unsigned long *module_map, - const multiboot_info_t *mbi, - void *(*bootstrap_map)(const module_t *)) +#ifdef CONFIG_MULTIBOOT +int __init xsm_multiboot_policy_init(unsigned long *module_map, + const multiboot_info_t *mbi, + void *(*bootstrap_map)(const module_t *)) { int i; module_t *mod = (module_t *)__va(mbi->mods_addr); @@ -65,3 +68,4 @@ int __init xsm_policy_init(unsigned long *module_map, return rc; } +#endif