From patchwork Wed Mar 5 01:02:29 2014 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Ian Campbell X-Patchwork-Id: 25720 Return-Path: X-Original-To: linaro@patches.linaro.org Delivered-To: linaro@patches.linaro.org Received: from mail-pb0-f72.google.com (mail-pb0-f72.google.com [209.85.160.72]) by ip-10-151-82-157.ec2.internal (Postfix) with ESMTPS id AB15420540 for ; Wed, 5 Mar 2014 01:04:54 +0000 (UTC) Received: by mail-pb0-f72.google.com with SMTP id jt11sf829448pbb.7 for ; Tue, 04 Mar 2014 17:04:53 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:delivered-to:from:to:date:message-id:cc:subject :precedence:list-id:list-unsubscribe:list-post:list-help :list-subscribe:mime-version:sender:errors-to:x-original-sender :x-original-authentication-results:mailing-list:list-archive :content-type:content-transfer-encoding; bh=bnM31YG5/4a4JZn8nfXcfuc96/WoMl6VeBfJuILpvxw=; b=mccWSs28RPYeLaCkIZ+tc1U/STidLfVShBxNBjyltWNnU7C88t9j0Gr5/ZjPgAna/5 8kNfCOf9NSkWyb5WVmz9GFSwCygsdjfa02wxQRr8g/fkffp8HPJzPyMmaj0hDHOmRZXz BYY/4SJYv+s0lH5XaT6EALIrecHfRQ5xgKTOck+3kJZZAthzaVGE308peV9mC5Tmh7cT StNUmScHbZSWzflR1hRx+hGktJyYd4cxZEdOo+KnSrQ5BAm3wKMKPyehJBTxI938w8Q2 o5f69eeALi/6XbhOERgdIYUqHppdQ5dj86Vsx87QBXVk629hK7LPhHyF79gpYnC3y99M zBwQ== X-Gm-Message-State: ALoCoQmYoiRgXvgFXeFYi/gfv8/f0orKPsfXMmeER/xtxEw/2+EprXn0bm9062A7KNTsR/swC1sA X-Received: by 10.66.102.8 with SMTP id fk8mr1347018pab.24.1393981493506; Tue, 04 Mar 2014 17:04:53 -0800 (PST) X-BeenThere: patchwork-forward@linaro.org Received: by 10.140.106.165 with SMTP id e34ls107548qgf.29.gmail; Tue, 04 Mar 2014 17:04:53 -0800 (PST) X-Received: by 10.58.95.161 with SMTP id dl1mr2108186veb.21.1393981493304; Tue, 04 Mar 2014 17:04:53 -0800 (PST) Received: from mail-vc0-f180.google.com (mail-vc0-f180.google.com [209.85.220.180]) by mx.google.com with ESMTPS id xt2si224648vcb.33.2014.03.04.17.04.53 for (version=TLSv1 cipher=ECDHE-RSA-RC4-SHA bits=128/128); Tue, 04 Mar 2014 17:04:53 -0800 (PST) Received-SPF: neutral (google.com: 209.85.220.180 is neither permitted nor denied by best guess record for domain of patch+caf_=patchwork-forward=linaro.org@linaro.org) client-ip=209.85.220.180; Received: by mail-vc0-f180.google.com with SMTP id ks9so329538vcb.11 for ; Tue, 04 Mar 2014 17:04:53 -0800 (PST) X-Received: by 10.58.91.101 with SMTP id cd5mr2095557veb.5.1393981493193; Tue, 04 Mar 2014 17:04:53 -0800 (PST) X-Forwarded-To: patchwork-forward@linaro.org X-Forwarded-For: patch@linaro.org patchwork-forward@linaro.org Delivered-To: patch@linaro.org Received: by 10.220.130.193 with SMTP id u1csp166617vcs; Tue, 4 Mar 2014 17:04:52 -0800 (PST) X-Received: by 10.42.119.134 with SMTP id b6mr2216260icr.31.1393981492602; Tue, 04 Mar 2014 17:04:52 -0800 (PST) Received: from lists.xen.org (lists.xen.org. [50.57.142.19]) by mx.google.com with ESMTPS id q1si7276170igr.23.2014.03.04.17.04.51 for (version=TLSv1 cipher=RC4-SHA bits=128/128); Tue, 04 Mar 2014 17:04:52 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of xen-devel-bounces@lists.xen.org designates 50.57.142.19 as permitted sender) client-ip=50.57.142.19; Received: from localhost ([127.0.0.1] helo=lists.xen.org) by lists.xen.org with esmtp (Exim 4.72) (envelope-from ) id 1WL0EO-0004No-A9; Wed, 05 Mar 2014 01:02:44 +0000 Received: from mail6.bemta4.messagelabs.com ([85.158.143.247]) by lists.xen.org with esmtp (Exim 4.72) (envelope-from ) id 1WL0EM-00049i-Si for xen-devel@lists.xen.org; Wed, 05 Mar 2014 01:02:42 +0000 Received: from [85.158.143.35:13504] by server-2.bemta-4.messagelabs.com id 29/8A-06539-2B776135; Wed, 05 Mar 2014 01:02:42 +0000 X-Env-Sender: ian.campbell@citrix.com X-Msg-Ref: server-5.tower-21.messagelabs.com!1393981361!9975924!1 X-Originating-IP: [212.110.190.137] X-SpamReason: No, hits=0.5 required=7.0 tests=BODY_RANDOM_LONG, UPPERCASE_25_50 X-StarScan-Received: X-StarScan-Version: 6.9.16; banners=-,-,- X-VirusChecked: Checked Received: (qmail 28062 invoked from network); 5 Mar 2014 01:02:41 -0000 Received: from benson.vm.bytemark.co.uk (HELO benson.vm.bytemark.co.uk) (212.110.190.137) by server-5.tower-21.messagelabs.com with AES256-SHA encrypted SMTP; 5 Mar 2014 01:02:41 -0000 Received: from z88l218.static.ctm.net ([202.175.88.218] helo=hastur.hellion.org.uk) by benson.vm.bytemark.co.uk with esmtpsa (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.72) (envelope-from ) id 1WL0EI-0001ub-MN; Wed, 05 Mar 2014 01:02:40 +0000 Received: by hastur.hellion.org.uk (sSMTP sendmail emulation); Wed, 05 Mar 2014 01:02:29 +0000 From: Ian Campbell To: xen-devel@lists.xen.org Date: Wed, 5 Mar 2014 01:02:29 +0000 Message-Id: <1393981349-6811-1-git-send-email-ian.campbell@citrix.com> X-Mailer: git-send-email 1.8.5.3 Cc: Ian Campbell , julien.grall@linaro.org, tim@xen.org, Ian Campbell , stefano.stabellini@eu.citrix.com Subject: [Xen-devel] [PATCH] xen: arm: prevent building with CONFIG_EARLY_PRINTK if not a debug build X-BeenThere: xen-devel@lists.xen.org X-Mailman-Version: 2.1.13 Precedence: list List-Id: List-Unsubscribe: , List-Post: , List-Help: , List-Subscribe: , MIME-Version: 1.0 Sender: xen-devel-bounces@lists.xen.org Errors-To: xen-devel-bounces@lists.xen.org X-Removed-Original-Auth: Dkim didn't pass. X-Original-Sender: ian.campbell@citrix.com X-Original-Authentication-Results: mx.google.com; spf=neutral (google.com: 209.85.220.180 is neither permitted nor denied by best guess record for domain of patch+caf_=patchwork-forward=linaro.org@linaro.org) smtp.mail=patch+caf_=patchwork-forward=linaro.org@linaro.org Mailing-list: list patchwork-forward@linaro.org; contact patchwork-forward+owners@linaro.org X-Google-Group-Id: 836684582541 List-Archive: early printk on ARM is tied to debug being enabled, so error out instead of silently and unexpectedly building without early printk when asked. Signed-off-by: Ian Campbell Signed-off-by: Ian Campbell Acked-by: Julien Grall --- xen/arch/arm/Rules.mk | 8 ++++++++ 1 file changed, 8 insertions(+) diff --git a/xen/arch/arm/Rules.mk b/xen/arch/arm/Rules.mk index aaa203e..aa2e79f 100644 --- a/xen/arch/arm/Rules.mk +++ b/xen/arch/arm/Rules.mk @@ -99,4 +99,12 @@ CFLAGS-$(EARLY_PRINTK) += -DEARLY_PRINTK_INC=\"debug-$(EARLY_PRINTK_INC).inc\" CFLAGS-$(EARLY_PRINTK) += -DEARLY_PRINTK_BAUD=$(EARLY_PRINTK_BAUD) CFLAGS-$(EARLY_PRINTK) += -DEARLY_UART_BASE_ADDRESS=$(EARLY_UART_BASE_ADDRESS) CFLAGS-$(EARLY_PRINTK) += -DEARLY_UART_REG_SHIFT=$(EARLY_UART_REG_SHIFT) + +else # !debug + +ifneq ($(CONFIG_EARLY_PRINTK),) +# Early printk is dependant on a debug build. +$(error CONFIG_EARLY_PRINTK enabled for non-debug build) +endif + endif