From patchwork Tue Jan 14 16:55:04 2014 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Ian Campbell X-Patchwork-Id: 23199 Return-Path: X-Original-To: linaro@patches.linaro.org Delivered-To: linaro@patches.linaro.org Received: from mail-qa0-f69.google.com (mail-qa0-f69.google.com [209.85.216.69]) by ip-10-151-82-157.ec2.internal (Postfix) with ESMTPS id A86272066C for ; Tue, 14 Jan 2014 16:57:14 +0000 (UTC) Received: by mail-qa0-f69.google.com with SMTP id w8sf11824233qac.4 for ; Tue, 14 Jan 2014 08:57:13 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:delivered-to:from:to:date:message-id :mime-version:cc:subject:precedence:list-id:list-unsubscribe :list-post:list-help:list-subscribe:sender:errors-to :x-original-sender:x-original-authentication-results:mailing-list :list-archive:content-type:content-transfer-encoding; bh=DJoNThQP/EZZ5iElHCTdNZKJOjmWyC43SFWk2beIM+I=; b=awLs1IQ77tuxhrNydFsNTAALjbiVpvgpDJpOai9ALPaAk01w9n2eDfjLX28kTxTWfU mU7fsA98SuQUFkOxYs+fLYo394WoEC4VRu+wbyKSGjezUbjYz3tzAHGWNekxafb3jRQU vwp/zTbb6FCbznNVMaOWPDii68WNjj+Qb4eV+cOT4U8/xUmMRIDPfeR+N8nICDLHGM3S UtuxgDILtN1OvCchGV2A55Qi2GMwGCuNOsQ5wkde097apzToMCymk425gEU2L8m8IVef uYyss0ZmGxbtfcn5PmszFqptNae2H04+ffiSmGcjolJYy+VZm/4foqL7wdWn9qKHLini 9qTg== X-Gm-Message-State: ALoCoQlgnnOq60TmKxRjOcvN99JzbZool/Oxr6OhXhIziNImbEzaIi1dM4jFmcJufFqIgXnFjs0t X-Received: by 10.236.18.196 with SMTP id l44mr3092862yhl.52.1389718633574; Tue, 14 Jan 2014 08:57:13 -0800 (PST) X-BeenThere: patchwork-forward@linaro.org Received: by 10.49.82.234 with SMTP id l10ls200906qey.93.gmail; Tue, 14 Jan 2014 08:57:13 -0800 (PST) X-Received: by 10.221.3.70 with SMTP id nx6mr888216vcb.45.1389718633482; Tue, 14 Jan 2014 08:57:13 -0800 (PST) Received: from mail-vb0-f52.google.com (mail-vb0-f52.google.com [209.85.212.52]) by mx.google.com with ESMTPS id gx6si465076vdc.11.2014.01.14.08.57.13 for (version=TLSv1 cipher=ECDHE-RSA-RC4-SHA bits=128/128); Tue, 14 Jan 2014 08:57:13 -0800 (PST) Received-SPF: neutral (google.com: 209.85.212.52 is neither permitted nor denied by best guess record for domain of patch+caf_=patchwork-forward=linaro.org@linaro.org) client-ip=209.85.212.52; Received: by mail-vb0-f52.google.com with SMTP id p14so1285708vbm.25 for ; Tue, 14 Jan 2014 08:57:13 -0800 (PST) X-Received: by 10.220.161.132 with SMTP id r4mr1223095vcx.29.1389718633376; Tue, 14 Jan 2014 08:57:13 -0800 (PST) X-Forwarded-To: patchwork-forward@linaro.org X-Forwarded-For: patch@linaro.org patchwork-forward@linaro.org Delivered-To: patch@linaro.org Received: by 10.59.13.131 with SMTP id ey3csp215540ved; Tue, 14 Jan 2014 08:57:12 -0800 (PST) X-Received: by 10.224.10.196 with SMTP id q4mr4787773qaq.74.1389718627235; Tue, 14 Jan 2014 08:57:07 -0800 (PST) Received: from lists.xen.org (lists.xen.org. [50.57.142.19]) by mx.google.com with ESMTPS id ec10si1381914qeb.89.2014.01.14.08.57.06 for (version=TLSv1 cipher=RC4-SHA bits=128/128); Tue, 14 Jan 2014 08:57:07 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of xen-devel-bounces@lists.xen.org designates 50.57.142.19 as permitted sender) client-ip=50.57.142.19; Received: from localhost ([127.0.0.1] helo=lists.xen.org) by lists.xen.org with esmtp (Exim 4.72) (envelope-from ) id 1W37Gh-0005Ve-Uo; Tue, 14 Jan 2014 16:55:11 +0000 Received: from mail6.bemta4.messagelabs.com ([85.158.143.247]) by lists.xen.org with esmtp (Exim 4.72) (envelope-from ) id 1W37Gg-0005VY-LD for xen-devel@lists.xen.org; Tue, 14 Jan 2014 16:55:10 +0000 Received: from [85.158.143.35:48557] by server-2.bemta-4.messagelabs.com id 78/8A-11386-EEB65D25; Tue, 14 Jan 2014 16:55:10 +0000 X-Env-Sender: Ian.Campbell@citrix.com X-Msg-Ref: server-16.tower-21.messagelabs.com!1389718507!11646740!1 X-Originating-IP: [66.165.176.89] X-SpamReason: No, hits=0.0 required=7.0 tests=sa_preprocessor: VHJ1c3RlZCBJUDogNjYuMTY1LjE3Ni44OSA9PiAyMDMwMDc=\n X-StarScan-Received: X-StarScan-Version: 6.9.16; banners=-,-,- X-VirusChecked: Checked Received: (qmail 23938 invoked from network); 14 Jan 2014 16:55:09 -0000 Received: from smtp.citrix.com (HELO SMTP.CITRIX.COM) (66.165.176.89) by server-16.tower-21.messagelabs.com with RC4-SHA encrypted SMTP; 14 Jan 2014 16:55:09 -0000 X-IronPort-AV: E=Sophos;i="4.95,658,1384300800"; d="scan'208";a="92755539" Received: from accessns.citrite.net (HELO FTLPEX01CL02.citrite.net) ([10.9.154.239]) by FTLPIPO01.CITRIX.COM with ESMTP; 14 Jan 2014 16:55:05 +0000 Received: from norwich.cam.xci-test.com (10.80.248.129) by smtprelay.citrix.com (10.13.107.79) with Microsoft SMTP Server id 14.2.342.4; Tue, 14 Jan 2014 11:55:05 -0500 Received: from drall.uk.xensource.com ([10.80.16.71] helo=drall.uk.xensource.com.) by norwich.cam.xci-test.com with esmtp (Exim 4.72) (envelope-from ) id 1W37Ga-0008DS-HP; Tue, 14 Jan 2014 16:55:04 +0000 From: Ian Campbell To: Date: Tue, 14 Jan 2014 16:55:04 +0000 Message-ID: <1389718504-1514-1-git-send-email-ian.campbell@citrix.com> X-Mailer: git-send-email 1.7.10.4 MIME-Version: 1.0 X-DLP: MIA1 Cc: julien.grall@linaro.org, tim@xen.org, Ian Campbell , stefano.stabellini@eu.citrix.com Subject: [Xen-devel] [PATCH] xen: arm: correctly write release target in smp_spin_table_cpu_up X-BeenThere: xen-devel@lists.xen.org X-Mailman-Version: 2.1.13 Precedence: list List-Id: List-Unsubscribe: , List-Post: , List-Help: , List-Subscribe: , Sender: xen-devel-bounces@lists.xen.org Errors-To: xen-devel-bounces@lists.xen.org X-Removed-Original-Auth: Dkim didn't pass. X-Original-Sender: ian.campbell@citrix.com X-Original-Authentication-Results: mx.google.com; spf=neutral (google.com: 209.85.212.52 is neither permitted nor denied by best guess record for domain of patch+caf_=patchwork-forward=linaro.org@linaro.org) smtp.mail=patch+caf_=patchwork-forward=linaro.org@linaro.org Mailing-list: list patchwork-forward@linaro.org; contact patchwork-forward+owners@linaro.org X-Google-Group-Id: 836684582541 List-Archive: flush_xen_data_tlb_range_va() is clearly bogus since it flushes the tlb, not the data cache. Perhaps what was meant was flush_xen_dcache(), but the address was mapped with ioremap_nocache and hence isn't cached in the first place. Accesses should be via writeq though, so do that. Signed-off-by: Ian Campbell Acked-by: Julien Grall --- xen/arch/arm/arm64/smpboot.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/xen/arch/arm/arm64/smpboot.c b/xen/arch/arm/arm64/smpboot.c index 1287c72..9146476 100644 --- a/xen/arch/arm/arm64/smpboot.c +++ b/xen/arch/arm/arm64/smpboot.c @@ -32,8 +32,7 @@ static int __init smp_spin_table_cpu_up(int cpu) return -EFAULT; } - release[0] = __pa(init_secondary); - flush_xen_data_tlb_range_va((vaddr_t)release, sizeof(*release)); + writeq(__pa(init_secondary), release); iounmap(release);