From patchwork Fri Nov 15 15:27:37 2013 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Julien Grall X-Patchwork-Id: 21543 Return-Path: X-Original-To: linaro@patches.linaro.org Delivered-To: linaro@patches.linaro.org Received: from mail-ie0-f199.google.com (mail-ie0-f199.google.com [209.85.223.199]) by ip-10-151-82-157.ec2.internal (Postfix) with ESMTPS id 153CC23FBA for ; Fri, 15 Nov 2013 15:28:06 +0000 (UTC) Received: by mail-ie0-f199.google.com with SMTP id aq17sf7928756iec.2 for ; Fri, 15 Nov 2013 07:28:05 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:mime-version:delivered-to:from:to:cc:subject :date:message-id:in-reply-to:references:x-original-sender :x-original-authentication-results:precedence:mailing-list:list-id :list-post:list-help:list-archive:list-unsubscribe; bh=pIurGgmJVE1/L9oBeP3ipXm8UJCHEfUCUlk8hykqD7g=; b=H7B0VXh7nfizTWgkonJfkOciQY0gBVSnKvlggtFo9IGdMqHxpekMS8h+b9danXb6QW pqL7W851tZxwi9crIOBth9cT8LIbJj/UqcA3a9HV9JJ08KJefdoFhJTM1gJkjwbp6nvB cZhOxKj9bM5WRcf9umBVcLfAB/N8ESGGh9oIZmUa8y+TXOh7axQXaYtxNUi7JKXGwzDo XnWRapWWym+pIcIevEGTQaonw14dkDHWXO2gUelhBR0Ah9JWRdmGcFWgiqR+SdPCzxh5 oZBRvMbcvj26/8F+X38zg4KPI9y2yCik4GFL7lxen6/E76zkCGaDUk/0wunee5lYx0cb yRlQ== X-Gm-Message-State: ALoCoQle8/151M9pT3LD7Stq9Gz6wTVM0ZMoaRK2SxGCtJgSebJ9YrKJFEyZkWnBiLSR1vo1cpJd X-Received: by 10.50.85.109 with SMTP id g13mr3436031igz.1.1384529285446; Fri, 15 Nov 2013 07:28:05 -0800 (PST) MIME-Version: 1.0 X-BeenThere: patchwork-forward@linaro.org Received: by 10.49.74.198 with SMTP id w6ls1514756qev.9.gmail; Fri, 15 Nov 2013 07:28:05 -0800 (PST) X-Received: by 10.220.182.69 with SMTP id cb5mr140165vcb.41.1384529285320; Fri, 15 Nov 2013 07:28:05 -0800 (PST) Received: from mail-vc0-f178.google.com (mail-vc0-f178.google.com [209.85.220.178]) by mx.google.com with ESMTPS id ug9si1763177vcb.32.2013.11.15.07.28.05 for (version=TLSv1 cipher=ECDHE-RSA-RC4-SHA bits=128/128); Fri, 15 Nov 2013 07:28:05 -0800 (PST) Received-SPF: neutral (google.com: 209.85.220.178 is neither permitted nor denied by best guess record for domain of patch+caf_=patchwork-forward=linaro.org@linaro.org) client-ip=209.85.220.178; Received: by mail-vc0-f178.google.com with SMTP id ik5so1878789vcb.9 for ; Fri, 15 Nov 2013 07:28:05 -0800 (PST) X-Received: by 10.220.42.212 with SMTP id t20mr139055vce.45.1384529285193; Fri, 15 Nov 2013 07:28:05 -0800 (PST) X-Forwarded-To: patchwork-forward@linaro.org X-Forwarded-For: patch@linaro.org patchwork-forward@linaro.org Delivered-To: patches@linaro.org Received: by 10.220.174.196 with SMTP id u4csp36965vcz; Fri, 15 Nov 2013 07:28:04 -0800 (PST) X-Received: by 10.194.109.167 with SMTP id ht7mr7200941wjb.5.1384529284437; Fri, 15 Nov 2013 07:28:04 -0800 (PST) Received: from mail-we0-f176.google.com (mail-we0-f176.google.com [74.125.82.176]) by mx.google.com with ESMTPS id wa3si1423056wjc.149.2013.11.15.07.28.04 for (version=TLSv1 cipher=ECDHE-RSA-RC4-SHA bits=128/128); Fri, 15 Nov 2013 07:28:04 -0800 (PST) Received-SPF: neutral (google.com: 74.125.82.176 is neither permitted nor denied by best guess record for domain of julien.grall@linaro.org) client-ip=74.125.82.176; Received: by mail-we0-f176.google.com with SMTP id w62so3654647wes.35 for ; Fri, 15 Nov 2013 07:28:04 -0800 (PST) X-Received: by 10.180.12.75 with SMTP id w11mr7743125wib.15.1384529284005; Fri, 15 Nov 2013 07:28:04 -0800 (PST) Received: from localhost.localdomain ([80.215.132.217]) by mx.google.com with ESMTPSA id uc12sm6079087wib.3.2013.11.15.07.28.01 for (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Fri, 15 Nov 2013 07:28:03 -0800 (PST) From: Julien Grall To: xen-devel@lists.xenproject.org Cc: ian.campbell@citrix.com, tim@xen.org, patches@linaro.org, stefano.stabellini@eu.citrix.com, Julien Grall Subject: [PATCH] xen/arm: Panic if we are unable to initialize platform timer Date: Fri, 15 Nov 2013 15:27:37 +0000 Message-Id: <1384529257-7590-3-git-send-email-julien.grall@linaro.org> X-Mailer: git-send-email 1.8.3.1 In-Reply-To: <1384529257-7590-1-git-send-email-julien.grall@linaro.org> References: <1384529257-7590-1-git-send-email-julien.grall@linaro.org> X-Removed-Original-Auth: Dkim didn't pass. X-Original-Sender: julien.grall@linaro.org X-Original-Authentication-Results: mx.google.com; spf=neutral (google.com: 209.85.220.178 is neither permitted nor denied by best guess record for domain of patch+caf_=patchwork-forward=linaro.org@linaro.org) smtp.mail=patch+caf_=patchwork-forward=linaro.org@linaro.org Precedence: list Mailing-list: list patchwork-forward@linaro.org; contact patchwork-forward+owners@linaro.org List-ID: X-Google-Group-Id: 836684582541 List-Post: , List-Help: , List-Archive: List-Unsubscribe: , The caller of xen_init_time, start_xen, doesn't check the return value of the function. Xen will silently ignore the error and continue. Signed-off-by: Julien Grall Acked-by: Stefano Stabellini Acked-by: Ian Campbell --- xen/arch/arm/time.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/xen/arch/arm/time.c b/xen/arch/arm/time.c index a30d422..938995d 100644 --- a/xen/arch/arm/time.c +++ b/xen/arch/arm/time.c @@ -132,7 +132,7 @@ int __init init_xen_time(void) res = platform_init_time(); if ( res ) - return res; + panic("Timer: Cannot initialize platform timer\n"); /* Check that this CPU supports the Generic Timer interface */ if ( !cpu_has_gentimer )