| Message ID | 20170516112807.4107417-1-arnd@arndb.de |
|---|---|
| State | Accepted |
| Commit | 2432a3fb5cff026005aaad24e42226402f7fd0aa |
| Headers | show |
From: Arnd Bergmann <arnd@arndb.de> Date: Tue, 16 May 2017 13:27:49 +0200 > We now reference the arp_tbl, which requires IPv4 support to be > enabled in the kernel, otherwise we get a link error: > > drivers/net/built-in.o: In function `mlx5e_tc_update_neigh_used_value': > (.text+0x16afec): undefined reference to `arp_tbl' > drivers/net/built-in.o: In function `mlx5e_rep_neigh_init': > en_rep.c:(.text+0x16c16d): undefined reference to `arp_tbl' > drivers/net/built-in.o: In function `mlx5e_rep_netevent_event': > en_rep.c:(.text+0x16cbb5): undefined reference to `arp_tbl' > > This adds a Kconfig dependency for it. > > Fixes: 232c001398ae ("net/mlx5e: Add support to neighbour update flow") > Signed-off-by: Arnd Bergmann <arnd@arndb.de> Applied, thanks.
diff --git a/drivers/net/ethernet/mellanox/mlx5/core/Kconfig b/drivers/net/ethernet/mellanox/mlx5/core/Kconfig index fc52d742b7f7..27251a78075c 100644 --- a/drivers/net/ethernet/mellanox/mlx5/core/Kconfig +++ b/drivers/net/ethernet/mellanox/mlx5/core/Kconfig @@ -13,7 +13,7 @@ config MLX5_CORE config MLX5_CORE_EN bool "Mellanox Technologies ConnectX-4 Ethernet support" - depends on NETDEVICES && ETHERNET && PCI && MLX5_CORE + depends on NETDEVICES && ETHERNET && INET && PCI && MLX5_CORE depends on IPV6=y || IPV6=n || MLX5_CORE=m imply PTP_1588_CLOCK default n
We now reference the arp_tbl, which requires IPv4 support to be enabled in the kernel, otherwise we get a link error: drivers/net/built-in.o: In function `mlx5e_tc_update_neigh_used_value': (.text+0x16afec): undefined reference to `arp_tbl' drivers/net/built-in.o: In function `mlx5e_rep_neigh_init': en_rep.c:(.text+0x16c16d): undefined reference to `arp_tbl' drivers/net/built-in.o: In function `mlx5e_rep_netevent_event': en_rep.c:(.text+0x16cbb5): undefined reference to `arp_tbl' This adds a Kconfig dependency for it. Fixes: 232c001398ae ("net/mlx5e: Add support to neighbour update flow") Signed-off-by: Arnd Bergmann <arnd@arndb.de> --- Note: the mlxsw driver has referenced the same symbol for a while, but had an implicit dependency on CONFIG_INET since it also depends on SWITCHDEV. drivers/net/ethernet/mellanox/mlx5/core/Kconfig | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) -- 2.9.0