| Message ID | 1490191680-14481-21-git-send-email-yamada.masahiro@socionext.com |
|---|---|
| State | New |
| Headers | show |
| Series | [v2,01/53] mtd: nand: allow to set only one of ECC size and ECC strength from DT | expand |
On Wed, 22 Mar 2017 23:07:27 +0900 Masahiro Yamada <yamada.masahiro@socionext.com> wrote: > This will be filled by nand_scan_ident() later. > > Signed-off-by: Masahiro Yamada <yamada.masahiro@socionext.com> > --- > > Changes in v2: None > > drivers/mtd/nand/denali.c | 1 - > 1 file changed, 1 deletion(-) > > diff --git a/drivers/mtd/nand/denali.c b/drivers/mtd/nand/denali.c > index 3badb1d..1706975 100644 > --- a/drivers/mtd/nand/denali.c > +++ b/drivers/mtd/nand/denali.c > @@ -1495,7 +1495,6 @@ int denali_init(struct denali_nand_info *denali) > > /* now that our ISR is registered, we can enable interrupts */ > denali_set_intr_modes(denali, true); > - mtd->name = "denali-nand"; Are you sure this is safe to do that? When mtd->name is NULL, the core takes the parent name, and in the denali_dt case it's not "denali-nand", which means you're breaking mtdparts compat. > nand_set_flash_node(chip, denali->dev->of_node); > > /* register the driver with the NAND core subsystem */ ______________________________________________________ Linux MTD discussion mailing list http://lists.infradead.org/mailman/listinfo/linux-mtd/
diff --git a/drivers/mtd/nand/denali.c b/drivers/mtd/nand/denali.c index 3badb1d..1706975 100644 --- a/drivers/mtd/nand/denali.c +++ b/drivers/mtd/nand/denali.c @@ -1495,7 +1495,6 @@ int denali_init(struct denali_nand_info *denali) /* now that our ISR is registered, we can enable interrupts */ denali_set_intr_modes(denali, true); - mtd->name = "denali-nand"; nand_set_flash_node(chip, denali->dev->of_node); /* register the driver with the NAND core subsystem */
This will be filled by nand_scan_ident() later. Signed-off-by: Masahiro Yamada <yamada.masahiro@socionext.com> --- Changes in v2: None drivers/mtd/nand/denali.c | 1 - 1 file changed, 1 deletion(-) -- 2.7.4 ______________________________________________________ Linux MTD discussion mailing list http://lists.infradead.org/mailman/listinfo/linux-mtd/