| Message ID | 20170227152119.29595-2-maxim.uvarov@linaro.org |
|---|---|
| State | New |
| Headers | show |
| Series | [1/2] linux-gen: ipc_pktio: fix conversion from hdr to pkt | expand |
Please review this 2/2 patch as stand alone patch. It removes configure option. Maxim. On 02/27/17 18:21, Maxim Uvarov wrote: > Options becomes stable and not need any entry in main > configure for platform specific pktio. > > Signed-off-by: Maxim Uvarov <maxim.uvarov@linaro.org> > --- > configure.ac | 1 - > platform/linux-generic/Makefile.am | 1 + > platform/linux-generic/m4/configure.m4 | 1 - > platform/linux-generic/m4/odp_ipc.m4 | 9 --------- > test/linux-generic/Makefile.am | 3 --- > 5 files changed, 1 insertion(+), 14 deletions(-) > delete mode 100644 platform/linux-generic/m4/odp_ipc.m4 > > diff --git a/configure.ac b/configure.ac > index d344e6ad..f4af6604 100644 > --- a/configure.ac > +++ b/configure.ac > @@ -209,7 +209,6 @@ AC_SUBST([testdir]) > # Set conditionals as computed within platform specific files > ########################################################################## > AM_CONDITIONAL([netmap_support], [test x$netmap_support = xyes ]) > -AM_CONDITIONAL([PKTIO_IPC], [test x$pktio_ipc_support = xyes]) > AM_CONDITIONAL([PKTIO_DPDK], [test x$pktio_dpdk_support = xyes ]) > AM_CONDITIONAL([HAVE_PCAP], [test $have_pcap = yes]) > AM_CONDITIONAL([SDK_INSTALL_PATH_], [test "x${SDK_INSTALL_PATH_}" = "x1"]) > diff --git a/platform/linux-generic/Makefile.am b/platform/linux-generic/Makefile.am > index 32b5aab6..39d2921f 100644 > --- a/platform/linux-generic/Makefile.am > +++ b/platform/linux-generic/Makefile.am > @@ -9,6 +9,7 @@ AM_CFLAGS += -I$(top_srcdir)/include > AM_CFLAGS += -I$(top_srcdir)/include/odp/arch/@ARCH_ABI@ > AM_CFLAGS += -I$(top_builddir)/include > AM_CFLAGS += -Iinclude > +AM_CFLAGS += -D_ODP_PKTIO_IPC > > include_HEADERS = \ > $(top_srcdir)/include/odp.h \ > diff --git a/platform/linux-generic/m4/configure.m4 b/platform/linux-generic/m4/configure.m4 > index d3e5528c..a2a25408 100644 > --- a/platform/linux-generic/m4/configure.m4 > +++ b/platform/linux-generic/m4/configure.m4 > @@ -33,7 +33,6 @@ m4_include([platform/linux-generic/m4/odp_openssl.m4]) > m4_include([platform/linux-generic/m4/odp_pcap.m4]) > m4_include([platform/linux-generic/m4/odp_netmap.m4]) > m4_include([platform/linux-generic/m4/odp_dpdk.m4]) > -m4_include([platform/linux-generic/m4/odp_ipc.m4]) > m4_include([platform/linux-generic/m4/odp_schedule.m4]) > > AC_CONFIG_FILES([platform/linux-generic/Makefile > diff --git a/platform/linux-generic/m4/odp_ipc.m4 b/platform/linux-generic/m4/odp_ipc.m4 > deleted file mode 100644 > index 78217e22..00000000 > --- a/platform/linux-generic/m4/odp_ipc.m4 > +++ /dev/null > @@ -1,9 +0,0 @@ > -########################################################################## > -# Enable IPC pktio support > -########################################################################## > -AC_ARG_ENABLE([pktio_ipc_support], > - [ --enable-pktio_ipc-support include ipc IO support], > - [if test x$enableval = xyes; then > - pktio_ipc_support=yes > - ODP_CFLAGS="$ODP_CFLAGS -D_ODP_PKTIO_IPC" > - fi]) > diff --git a/test/linux-generic/Makefile.am b/test/linux-generic/Makefile.am > index 998ee561..0522550a 100644 > --- a/test/linux-generic/Makefile.am > +++ b/test/linux-generic/Makefile.am > @@ -53,11 +53,8 @@ endif > if PKTIO_DPDK > TESTS += validation/api/pktio/pktio_run_dpdk.sh > endif > - > -if PKTIO_IPC > TESTS += pktio_ipc/pktio_ipc_run.sh > SUBDIRS += pktio_ipc > -endif > else > #performance tests refer to pktio_env > if test_perf >
ping. Please review this patch as stand alone patch. Maxim. On 02/27/17 18:21, Maxim Uvarov wrote: > Options becomes stable and not need any entry in main > configure for platform specific pktio. > > Signed-off-by: Maxim Uvarov <maxim.uvarov@linaro.org> > --- > configure.ac | 1 - > platform/linux-generic/Makefile.am | 1 + > platform/linux-generic/m4/configure.m4 | 1 - > platform/linux-generic/m4/odp_ipc.m4 | 9 --------- > test/linux-generic/Makefile.am | 3 --- > 5 files changed, 1 insertion(+), 14 deletions(-) > delete mode 100644 platform/linux-generic/m4/odp_ipc.m4 > > diff --git a/configure.ac b/configure.ac > index d344e6ad..f4af6604 100644 > --- a/configure.ac > +++ b/configure.ac > @@ -209,7 +209,6 @@ AC_SUBST([testdir]) > # Set conditionals as computed within platform specific files > ########################################################################## > AM_CONDITIONAL([netmap_support], [test x$netmap_support = xyes ]) > -AM_CONDITIONAL([PKTIO_IPC], [test x$pktio_ipc_support = xyes]) > AM_CONDITIONAL([PKTIO_DPDK], [test x$pktio_dpdk_support = xyes ]) > AM_CONDITIONAL([HAVE_PCAP], [test $have_pcap = yes]) > AM_CONDITIONAL([SDK_INSTALL_PATH_], [test "x${SDK_INSTALL_PATH_}" = "x1"]) > diff --git a/platform/linux-generic/Makefile.am b/platform/linux-generic/Makefile.am > index 32b5aab6..39d2921f 100644 > --- a/platform/linux-generic/Makefile.am > +++ b/platform/linux-generic/Makefile.am > @@ -9,6 +9,7 @@ AM_CFLAGS += -I$(top_srcdir)/include > AM_CFLAGS += -I$(top_srcdir)/include/odp/arch/@ARCH_ABI@ > AM_CFLAGS += -I$(top_builddir)/include > AM_CFLAGS += -Iinclude > +AM_CFLAGS += -D_ODP_PKTIO_IPC > > include_HEADERS = \ > $(top_srcdir)/include/odp.h \ > diff --git a/platform/linux-generic/m4/configure.m4 b/platform/linux-generic/m4/configure.m4 > index d3e5528c..a2a25408 100644 > --- a/platform/linux-generic/m4/configure.m4 > +++ b/platform/linux-generic/m4/configure.m4 > @@ -33,7 +33,6 @@ m4_include([platform/linux-generic/m4/odp_openssl.m4]) > m4_include([platform/linux-generic/m4/odp_pcap.m4]) > m4_include([platform/linux-generic/m4/odp_netmap.m4]) > m4_include([platform/linux-generic/m4/odp_dpdk.m4]) > -m4_include([platform/linux-generic/m4/odp_ipc.m4]) > m4_include([platform/linux-generic/m4/odp_schedule.m4]) > > AC_CONFIG_FILES([platform/linux-generic/Makefile > diff --git a/platform/linux-generic/m4/odp_ipc.m4 b/platform/linux-generic/m4/odp_ipc.m4 > deleted file mode 100644 > index 78217e22..00000000 > --- a/platform/linux-generic/m4/odp_ipc.m4 > +++ /dev/null > @@ -1,9 +0,0 @@ > -########################################################################## > -# Enable IPC pktio support > -########################################################################## > -AC_ARG_ENABLE([pktio_ipc_support], > - [ --enable-pktio_ipc-support include ipc IO support], > - [if test x$enableval = xyes; then > - pktio_ipc_support=yes > - ODP_CFLAGS="$ODP_CFLAGS -D_ODP_PKTIO_IPC" > - fi]) > diff --git a/test/linux-generic/Makefile.am b/test/linux-generic/Makefile.am > index 998ee561..0522550a 100644 > --- a/test/linux-generic/Makefile.am > +++ b/test/linux-generic/Makefile.am > @@ -53,11 +53,8 @@ endif > if PKTIO_DPDK > TESTS += validation/api/pktio/pktio_run_dpdk.sh > endif > - > -if PKTIO_IPC > TESTS += pktio_ipc/pktio_ipc_run.sh > SUBDIRS += pktio_ipc > -endif > else > #performance tests refer to pktio_env > if test_perf >
On Mon, Feb 27, 2017 at 9:21 AM, Maxim Uvarov <maxim.uvarov@linaro.org> wrote: > Options becomes stable and not need any entry in main > configure for platform specific pktio. > > Signed-off-by: Maxim Uvarov <maxim.uvarov@linaro.org> > Reviewed-by: Bill Fischofer <bill.fischofer@linaro.org> > --- > configure.ac | 1 - > platform/linux-generic/Makefile.am | 1 + > platform/linux-generic/m4/configure.m4 | 1 - > platform/linux-generic/m4/odp_ipc.m4 | 9 --------- > test/linux-generic/Makefile.am | 3 --- > 5 files changed, 1 insertion(+), 14 deletions(-) > delete mode 100644 platform/linux-generic/m4/odp_ipc.m4 > > diff --git a/configure.ac b/configure.ac > index d344e6ad..f4af6604 100644 > --- a/configure.ac > +++ b/configure.ac > @@ -209,7 +209,6 @@ AC_SUBST([testdir]) > # Set conditionals as computed within platform specific files > ############################################################ > ############## > AM_CONDITIONAL([netmap_support], [test x$netmap_support = xyes ]) > -AM_CONDITIONAL([PKTIO_IPC], [test x$pktio_ipc_support = xyes]) > AM_CONDITIONAL([PKTIO_DPDK], [test x$pktio_dpdk_support = xyes ]) > AM_CONDITIONAL([HAVE_PCAP], [test $have_pcap = yes]) > AM_CONDITIONAL([SDK_INSTALL_PATH_], [test "x${SDK_INSTALL_PATH_}" = > "x1"]) > diff --git a/platform/linux-generic/Makefile.am b/platform/linux-generic/ > Makefile.am > index 32b5aab6..39d2921f 100644 > --- a/platform/linux-generic/Makefile.am > +++ b/platform/linux-generic/Makefile.am > @@ -9,6 +9,7 @@ AM_CFLAGS += -I$(top_srcdir)/include > AM_CFLAGS += -I$(top_srcdir)/include/odp/arch/@ARCH_ABI@ > AM_CFLAGS += -I$(top_builddir)/include > AM_CFLAGS += -Iinclude > +AM_CFLAGS += -D_ODP_PKTIO_IPC > > include_HEADERS = \ > $(top_srcdir)/include/odp.h \ > diff --git a/platform/linux-generic/m4/configure.m4 > b/platform/linux-generic/m4/configure.m4 > index d3e5528c..a2a25408 100644 > --- a/platform/linux-generic/m4/configure.m4 > +++ b/platform/linux-generic/m4/configure.m4 > @@ -33,7 +33,6 @@ m4_include([platform/linux-generic/m4/odp_openssl.m4]) > m4_include([platform/linux-generic/m4/odp_pcap.m4]) > m4_include([platform/linux-generic/m4/odp_netmap.m4]) > m4_include([platform/linux-generic/m4/odp_dpdk.m4]) > -m4_include([platform/linux-generic/m4/odp_ipc.m4]) > m4_include([platform/linux-generic/m4/odp_schedule.m4]) > > AC_CONFIG_FILES([platform/linux-generic/Makefile > diff --git a/platform/linux-generic/m4/odp_ipc.m4 > b/platform/linux-generic/m4/odp_ipc.m4 > deleted file mode 100644 > index 78217e22..00000000 > --- a/platform/linux-generic/m4/odp_ipc.m4 > +++ /dev/null > @@ -1,9 +0,0 @@ > -########################################################### > ############### > -# Enable IPC pktio support > -########################################################### > ############### > -AC_ARG_ENABLE([pktio_ipc_support], > - [ --enable-pktio_ipc-support include ipc IO support], > - [if test x$enableval = xyes; then > - pktio_ipc_support=yes > - ODP_CFLAGS="$ODP_CFLAGS -D_ODP_PKTIO_IPC" > - fi]) > diff --git a/test/linux-generic/Makefile.am b/test/linux-generic/Makefile. > am > index 998ee561..0522550a 100644 > --- a/test/linux-generic/Makefile.am > +++ b/test/linux-generic/Makefile.am > @@ -53,11 +53,8 @@ endif > if PKTIO_DPDK > TESTS += validation/api/pktio/pktio_run_dpdk.sh > endif > - > -if PKTIO_IPC > TESTS += pktio_ipc/pktio_ipc_run.sh > SUBDIRS += pktio_ipc > -endif > else > #performance tests refer to pktio_env > if test_perf > -- > 2.11.0.295.gd7dffce > >
diff --git a/configure.ac b/configure.ac index d344e6ad..f4af6604 100644 --- a/configure.ac +++ b/configure.ac @@ -209,7 +209,6 @@ AC_SUBST([testdir]) # Set conditionals as computed within platform specific files ########################################################################## AM_CONDITIONAL([netmap_support], [test x$netmap_support = xyes ]) -AM_CONDITIONAL([PKTIO_IPC], [test x$pktio_ipc_support = xyes]) AM_CONDITIONAL([PKTIO_DPDK], [test x$pktio_dpdk_support = xyes ]) AM_CONDITIONAL([HAVE_PCAP], [test $have_pcap = yes]) AM_CONDITIONAL([SDK_INSTALL_PATH_], [test "x${SDK_INSTALL_PATH_}" = "x1"]) diff --git a/platform/linux-generic/Makefile.am b/platform/linux-generic/Makefile.am index 32b5aab6..39d2921f 100644 --- a/platform/linux-generic/Makefile.am +++ b/platform/linux-generic/Makefile.am @@ -9,6 +9,7 @@ AM_CFLAGS += -I$(top_srcdir)/include AM_CFLAGS += -I$(top_srcdir)/include/odp/arch/@ARCH_ABI@ AM_CFLAGS += -I$(top_builddir)/include AM_CFLAGS += -Iinclude +AM_CFLAGS += -D_ODP_PKTIO_IPC include_HEADERS = \ $(top_srcdir)/include/odp.h \ diff --git a/platform/linux-generic/m4/configure.m4 b/platform/linux-generic/m4/configure.m4 index d3e5528c..a2a25408 100644 --- a/platform/linux-generic/m4/configure.m4 +++ b/platform/linux-generic/m4/configure.m4 @@ -33,7 +33,6 @@ m4_include([platform/linux-generic/m4/odp_openssl.m4]) m4_include([platform/linux-generic/m4/odp_pcap.m4]) m4_include([platform/linux-generic/m4/odp_netmap.m4]) m4_include([platform/linux-generic/m4/odp_dpdk.m4]) -m4_include([platform/linux-generic/m4/odp_ipc.m4]) m4_include([platform/linux-generic/m4/odp_schedule.m4]) AC_CONFIG_FILES([platform/linux-generic/Makefile diff --git a/platform/linux-generic/m4/odp_ipc.m4 b/platform/linux-generic/m4/odp_ipc.m4 deleted file mode 100644 index 78217e22..00000000 --- a/platform/linux-generic/m4/odp_ipc.m4 +++ /dev/null @@ -1,9 +0,0 @@ -########################################################################## -# Enable IPC pktio support -########################################################################## -AC_ARG_ENABLE([pktio_ipc_support], - [ --enable-pktio_ipc-support include ipc IO support], - [if test x$enableval = xyes; then - pktio_ipc_support=yes - ODP_CFLAGS="$ODP_CFLAGS -D_ODP_PKTIO_IPC" - fi]) diff --git a/test/linux-generic/Makefile.am b/test/linux-generic/Makefile.am index 998ee561..0522550a 100644 --- a/test/linux-generic/Makefile.am +++ b/test/linux-generic/Makefile.am @@ -53,11 +53,8 @@ endif if PKTIO_DPDK TESTS += validation/api/pktio/pktio_run_dpdk.sh endif - -if PKTIO_IPC TESTS += pktio_ipc/pktio_ipc_run.sh SUBDIRS += pktio_ipc -endif else #performance tests refer to pktio_env if test_perf
Options becomes stable and not need any entry in main configure for platform specific pktio. Signed-off-by: Maxim Uvarov <maxim.uvarov@linaro.org> --- configure.ac | 1 - platform/linux-generic/Makefile.am | 1 + platform/linux-generic/m4/configure.m4 | 1 - platform/linux-generic/m4/odp_ipc.m4 | 9 --------- test/linux-generic/Makefile.am | 3 --- 5 files changed, 1 insertion(+), 14 deletions(-) delete mode 100644 platform/linux-generic/m4/odp_ipc.m4 -- 2.11.0.295.gd7dffce