| Message ID | 20170214203202.13342-6-maxim.uvarov@linaro.org |
|---|---|
| State | New |
| Headers | show |
| Series | various travis updates | expand |
On 14 February 2017 at 15:32, Maxim Uvarov <maxim.uvarov@linaro.org> wrote: > Signed-off-by: Maxim Uvarov <maxim.uvarov@linaro.org> > --- > .travis.yml | 5 +++++ > 1 file changed, 5 insertions(+) > > diff --git a/.travis.yml b/.travis.yml > index ef9c3283..d7f4c66e 100644 > --- a/.travis.yml > +++ b/.travis.yml > @@ -100,6 +100,9 @@ before_install: > - make > /dev/null > - sudo insmod ./netmap.ko > - popd > +# Download tool to check odp contibutor agreement > + - git clone https://git.linaro.org/people/ > maxim.uvarov/odp-agreement.git Should this just be in odp/scripts and thus self contained ? If not should it be in an official Linaro repo rather than a private one ? I vote in odp/scripts becasue the .travis itself is already tailored to this reference implimentation of the ODP API, and this is an extension of that > > + > > script: > - echo $TRAVIS_COMMIT_RANGE > @@ -112,9 +115,11 @@ script: > if [ $? -ne 0 ]; then > git format-patch HEAD^; > perl ./scripts/checkpatch.pl *.patch; > + ./odp-agreement/check_patchlist.sh *.patch; > fi; > else > perl ./scripts/checkpatch.pl *.patch; > + ./odp-agreement/check_patchlist.sh *.patch; > fi > > - ./bootstrap > -- > 2.11.0.295.gd7dffce > > -- Mike Holmes Program Manager - Linaro Networking Group Linaro.org <http://www.linaro.org/> *│ *Open source software for ARM SoCs "Work should be fun and collaborative, the rest follows"
On 02/15/17 20:49, Mike Holmes wrote: > > > On 14 February 2017 at 15:32, Maxim Uvarov <maxim.uvarov@linaro.org > <mailto:maxim.uvarov@linaro.org>> wrote: > > Signed-off-by: Maxim Uvarov <maxim.uvarov@linaro.org > <mailto:maxim.uvarov@linaro.org>> > --- > .travis.yml | 5 +++++ > 1 file changed, 5 insertions(+) > > diff --git a/.travis.yml b/.travis.yml > index ef9c3283..d7f4c66e 100644 > --- a/.travis.yml > +++ b/.travis.yml > @@ -100,6 +100,9 @@ before_install: > - make > /dev/null > - sudo insmod ./netmap.ko > - popd > +# Download tool to check odp contibutor agreement > + - git clone > https://git.linaro.org/people/maxim.uvarov/odp-agreement.git > <https://git.linaro.org/people/maxim.uvarov/odp-agreement.git> > > > Should this just be in odp/scripts and thus self contained ? If not > should it be in an official Linaro repo rather than a private one ? > > I vote in odp/scripts becasue the .travis itself is already tailored to > this reference implimentation of the ODP API, and this is an extension > of that > Well.. there is database of users which accepted agreement. And we can not put that DB to main git. That is why it can not be in scripts. The right place is github web hook integration. The same way as SAP did for their projects. But it will take some time to understand web code setup and do required changes. After set up it has to look like this: https://github.com/muvarov/odp/pull/1 Maxim. > > > + > > script: > - echo $TRAVIS_COMMIT_RANGE > @@ -112,9 +115,11 @@ script: > if [ $? -ne 0 ]; then > git format-patch HEAD^; > perl ./scripts/checkpatch.pl <http://checkpatch.pl> > *.patch; > + ./odp-agreement/check_patchlist.sh *.patch; > fi; > else > perl ./scripts/checkpatch.pl <http://checkpatch.pl> > *.patch; > + ./odp-agreement/check_patchlist.sh *.patch; > fi > > - ./bootstrap > -- > 2.11.0.295.gd7dffce > > > > > -- > Mike Holmes > Program Manager - Linaro Networking Group > Linaro.org <http://www.linaro.org/>* **│ *Open source software for ARM SoCs > "Work should be fun and collaborative, the rest follows" > > __ > >
On 15 February 2017 at 14:19, Maxim Uvarov <maxim.uvarov@linaro.org> wrote: > On 02/15/17 20:49, Mike Holmes wrote: > > > > > > On 14 February 2017 at 15:32, Maxim Uvarov <maxim.uvarov@linaro.org > > <mailto:maxim.uvarov@linaro.org>> wrote: > > > > Signed-off-by: Maxim Uvarov <maxim.uvarov@linaro.org > > <mailto:maxim.uvarov@linaro.org>> > > --- > > .travis.yml | 5 +++++ > > 1 file changed, 5 insertions(+) > > > > diff --git a/.travis.yml b/.travis.yml > > index ef9c3283..d7f4c66e 100644 > > --- a/.travis.yml > > +++ b/.travis.yml > > @@ -100,6 +100,9 @@ before_install: > > - make > /dev/null > > - sudo insmod ./netmap.ko > > - popd > > +# Download tool to check odp contibutor agreement > > + - git clone > > https://git.linaro.org/people/maxim.uvarov/odp-agreement.git > > <https://git.linaro.org/people/maxim.uvarov/odp-agreement.git> > > > > > > Should this just be in odp/scripts and thus self contained ? If not > > should it be in an official Linaro repo rather than a private one ? > > > > I vote in odp/scripts becasue the .travis itself is already tailored to > > this reference implimentation of the ODP API, and this is an extension > > of that > > > > Well.. there is database of users which accepted agreement. And we can > not put that DB to main git. That is why it can not be in scripts. > > The right place is github web hook integration. The same way as SAP did > for their projects. But it will take some time to understand web code > setup and do required changes. After set up it has to look like this: > > https://github.com/muvarov/odp/pull/1 > > Maxim. > If pointing at a private repo is temporary that sounds ok, but one last question, should we just wait for the proper mechanism then ? > > > > > > > + > > > > script: > > - echo $TRAVIS_COMMIT_RANGE > > @@ -112,9 +115,11 @@ script: > > if [ $? -ne 0 ]; then > > git format-patch HEAD^; > > perl ./scripts/checkpatch.pl <http://checkpatch.pl> > > *.patch; > > + ./odp-agreement/check_patchlist.sh *.patch; > > fi; > > else > > perl ./scripts/checkpatch.pl <http://checkpatch.pl> > > *.patch; > > + ./odp-agreement/check_patchlist.sh *.patch; > > fi > > > > - ./bootstrap > > -- > > 2.11.0.295.gd7dffce > > > > > > > > > > -- > > Mike Holmes > > Program Manager - Linaro Networking Group > > Linaro.org <http://www.linaro.org/>* **│ *Open source software for ARM > SoCs > > "Work should be fun and collaborative, the rest follows" > > > > __ > > > > > > -- Mike Holmes Program Manager - Linaro Networking Group Linaro.org <http://www.linaro.org/> *│ *Open source software for ARM SoCs "Work should be fun and collaborative, the rest follows"
On 16 February 2017 at 15:49, Mike Holmes <mike.holmes@linaro.org> wrote: > > > On 15 February 2017 at 14:19, Maxim Uvarov <maxim.uvarov@linaro.org> > wrote: > >> On 02/15/17 20:49, Mike Holmes wrote: >> > >> > >> > On 14 February 2017 at 15:32, Maxim Uvarov <maxim.uvarov@linaro.org >> > <mailto:maxim.uvarov@linaro.org>> wrote: >> > >> > Signed-off-by: Maxim Uvarov <maxim.uvarov@linaro.org >> > <mailto:maxim.uvarov@linaro.org>> >> > --- >> > .travis.yml | 5 +++++ >> > 1 file changed, 5 insertions(+) >> > >> > diff --git a/.travis.yml b/.travis.yml >> > index ef9c3283..d7f4c66e 100644 >> > --- a/.travis.yml >> > +++ b/.travis.yml >> > @@ -100,6 +100,9 @@ before_install: >> > - make > /dev/null >> > - sudo insmod ./netmap.ko >> > - popd >> > +# Download tool to check odp contibutor agreement >> > + - git clone >> > https://git.linaro.org/people/maxim.uvarov/odp-agreement.git >> > <https://git.linaro.org/people/maxim.uvarov/odp-agreement.git> >> > >> > >> > Should this just be in odp/scripts and thus self contained ? If not >> > should it be in an official Linaro repo rather than a private one ? >> > >> > I vote in odp/scripts becasue the .travis itself is already tailored to >> > this reference implimentation of the ODP API, and this is an extension >> > of that >> > >> >> Well.. there is database of users which accepted agreement. And we can >> not put that DB to main git. That is why it can not be in scripts. >> >> The right place is github web hook integration. The same way as SAP did >> for their projects. But it will take some time to understand web code >> setup and do required changes. After set up it has to look like this: >> >> https://github.com/muvarov/odp/pull/1 >> >> Maxim. >> > > If pointing at a private repo is temporary that sounds ok, but one last > question, should we just wait for the proper mechanism then ? > > We do not have a lot of external contribution at this time. So we can skip this patch for now. > >> >> > >> > >> > + >> > >> > script: >> > - echo $TRAVIS_COMMIT_RANGE >> > @@ -112,9 +115,11 @@ script: >> > if [ $? -ne 0 ]; then >> > git format-patch HEAD^; >> > perl ./scripts/checkpatch.pl <http://checkpatch.pl> >> > *.patch; >> > + ./odp-agreement/check_patchlist.sh *.patch; >> > fi; >> > else >> > perl ./scripts/checkpatch.pl <http://checkpatch.pl> >> > *.patch; >> > + ./odp-agreement/check_patchlist.sh *.patch; >> > fi >> > >> > - ./bootstrap >> > -- >> > 2.11.0.295.gd7dffce >> > >> > >> > >> > >> > -- >> > Mike Holmes >> > Program Manager - Linaro Networking Group >> > Linaro.org <http://www.linaro.org/>* **│ *Open source software for ARM >> SoCs >> > "Work should be fun and collaborative, the rest follows" >> > >> > __ >> > >> > >> >> > > > -- > Mike Holmes > Program Manager - Linaro Networking Group > Linaro.org <http://www.linaro.org/> *│ *Open source software for ARM SoCs > "Work should be fun and collaborative, the rest follows" > > >
diff --git a/.travis.yml b/.travis.yml index ef9c3283..d7f4c66e 100644 --- a/.travis.yml +++ b/.travis.yml @@ -100,6 +100,9 @@ before_install: - make > /dev/null - sudo insmod ./netmap.ko - popd +# Download tool to check odp contibutor agreement + - git clone https://git.linaro.org/people/maxim.uvarov/odp-agreement.git + script: - echo $TRAVIS_COMMIT_RANGE @@ -112,9 +115,11 @@ script: if [ $? -ne 0 ]; then git format-patch HEAD^; perl ./scripts/checkpatch.pl *.patch; + ./odp-agreement/check_patchlist.sh *.patch; fi; else perl ./scripts/checkpatch.pl *.patch; + ./odp-agreement/check_patchlist.sh *.patch; fi - ./bootstrap
Signed-off-by: Maxim Uvarov <maxim.uvarov@linaro.org> --- .travis.yml | 5 +++++ 1 file changed, 5 insertions(+) -- 2.11.0.295.gd7dffce