diff mbox

ata: pata_of_platform: using of_property_read_u32() helper

Message ID 1485259709-16487-1-git-send-email-wangkefeng.wang@huawei.com
State Accepted
Commit 73b2951414f661e22dc4b88e4e6590c9406cf822
Headers show

Commit Message

Kefeng Wang Jan. 24, 2017, 12:08 p.m. UTC 
Using better of_property_read_u32() than generic of_get_property().

Cc: Bartlomiej Zolnierkiewicz <b.zolnierkie@samsung.com> 
Cc: Hans de Goede <hdegoede@redhat.com>
Cc: Tejun Heo <tj@kernel.org>
Signed-off-by: Kefeng Wang <wangkefeng.wang@huawei.com>

---
 drivers/ata/pata_of_platform.c | 9 ++-------
 1 file changed, 2 insertions(+), 7 deletions(-)

-- 
1.7.12.4

Comments

Tejun Heo Jan. 24, 2017, 4:15 p.m. UTC | #1 
On Tue, Jan 24, 2017 at 08:08:29PM +0800, Kefeng Wang wrote:
> Using better of_property_read_u32() than generic of_get_property().

> 

> Cc: Bartlomiej Zolnierkiewicz <b.zolnierkie@samsung.com> 

> Cc: Hans de Goede <hdegoede@redhat.com>

> Cc: Tejun Heo <tj@kernel.org>

> Signed-off-by: Kefeng Wang <wangkefeng.wang@huawei.com>


Applied to libata/for-4.11.

Thanks.

-- 
tejun
diff mbox

Patch

diff --git a/drivers/ata/pata_of_platform.c b/drivers/ata/pata_of_platform.c
index b6b7af8..201a32d 100644
--- a/drivers/ata/pata_of_platform.c
+++ b/drivers/ata/pata_of_platform.c
@@ -32,7 +32,6 @@  static int pata_of_platform_probe(struct platform_device *ofdev)
 	unsigned int reg_shift = 0;
 	int pio_mode = 0;
 	int pio_mask;
-	const u32 *prop;
 
 	ret = of_address_to_resource(dn, 0, &io_res);
 	if (ret) {
@@ -50,13 +49,9 @@  static int pata_of_platform_probe(struct platform_device *ofdev)
 
 	irq_res = platform_get_resource(ofdev, IORESOURCE_IRQ, 0);
 
-	prop = of_get_property(dn, "reg-shift", NULL);
-	if (prop)
-		reg_shift = be32_to_cpup(prop);
+	of_property_read_u32(dn, "reg-shift", &reg_shift);
 
-	prop = of_get_property(dn, "pio-mode", NULL);
-	if (prop) {
-		pio_mode = be32_to_cpup(prop);
+	if (!of_property_read_u32(dn, "pio-mode", &pio_mode)) {
 		if (pio_mode > 6) {
 			dev_err(&ofdev->dev, "invalid pio-mode\n");
 			return -EINVAL;