| Message ID | 20170118220137.6817-2-mike.holmes@linaro.org |
|---|---|
| State | Superseded |
| Headers | show |
| Series | remove Linux specifics and dependence on test dir | expand |
On 01/19/17 01:01, Mike Holmes wrote: > Don't keep helper data in the main configure, split it to an m4 just > like the other sub dirs > > Signed-off-by: Mike Holmes <mike.holmes@linaro.org> > --- > configure.ac | 2 -- > helper/m4/configure.m4 | 3 +++ > 2 files changed, 3 insertions(+), 2 deletions(-) > > diff --git a/configure.ac b/configure.ac > index 3a20959..a5b519f 100644 > --- a/configure.ac > +++ b/configure.ac > @@ -294,8 +294,6 @@ AM_CFLAGS="$AM_CFLAGS $ODP_CFLAGS" > AM_CXXFLAGS="-std=c++11" > > AC_CONFIG_FILES([Makefile > - helper/Makefile > - helper/test/Makefile > pkgconfig/libodp-linux.pc > pkgconfig/libodphelper-linux.pc > ]) > diff --git a/helper/m4/configure.m4 b/helper/m4/configure.m4 > index 480f79b..b8a21f7 100644 > --- a/helper/m4/configure.m4 > +++ b/helper/m4/configure.m4 > @@ -7,3 +7,6 @@ AC_ARG_ENABLE([test-helper], > [if test "x$enableval" = "xyes"; then > test_helper=yes > fi]) > + > +AC_CONFIG_FILES([helper/Makefile > + helper/test/Makefile]) > indent is very strange here. Maxim.
will fix, looks like 4 vs 8 space tabs, have taken two tabs out On 19 January 2017 at 09:40, Maxim Uvarov <maxim.uvarov@linaro.org> wrote: > On 01/19/17 01:01, Mike Holmes wrote: >> Don't keep helper data in the main configure, split it to an m4 just >> like the other sub dirs >> >> Signed-off-by: Mike Holmes <mike.holmes@linaro.org> >> --- >> configure.ac | 2 -- >> helper/m4/configure.m4 | 3 +++ >> 2 files changed, 3 insertions(+), 2 deletions(-) >> >> diff --git a/configure.ac b/configure.ac >> index 3a20959..a5b519f 100644 >> --- a/configure.ac >> +++ b/configure.ac >> @@ -294,8 +294,6 @@ AM_CFLAGS="$AM_CFLAGS $ODP_CFLAGS" >> AM_CXXFLAGS="-std=c++11" >> >> AC_CONFIG_FILES([Makefile >> - helper/Makefile >> - helper/test/Makefile >> pkgconfig/libodp-linux.pc >> pkgconfig/libodphelper-linux.pc >> ]) >> diff --git a/helper/m4/configure.m4 b/helper/m4/configure.m4 >> index 480f79b..b8a21f7 100644 >> --- a/helper/m4/configure.m4 >> +++ b/helper/m4/configure.m4 >> @@ -7,3 +7,6 @@ AC_ARG_ENABLE([test-helper], >> [if test "x$enableval" = "xyes"; then >> test_helper=yes >> fi]) >> + >> +AC_CONFIG_FILES([helper/Makefile >> + helper/test/Makefile]) >> > > indent is very strange here. > > Maxim. -- Mike Holmes Program Manager - Linaro Networking Group Linaro.org │ Open source software for ARM SoCs "Work should be fun and collaborative, the rest follows"
diff --git a/configure.ac b/configure.ac index 3a20959..a5b519f 100644 --- a/configure.ac +++ b/configure.ac @@ -294,8 +294,6 @@ AM_CFLAGS="$AM_CFLAGS $ODP_CFLAGS" AM_CXXFLAGS="-std=c++11" AC_CONFIG_FILES([Makefile - helper/Makefile - helper/test/Makefile pkgconfig/libodp-linux.pc pkgconfig/libodphelper-linux.pc ]) diff --git a/helper/m4/configure.m4 b/helper/m4/configure.m4 index 480f79b..b8a21f7 100644 --- a/helper/m4/configure.m4 +++ b/helper/m4/configure.m4 @@ -7,3 +7,6 @@ AC_ARG_ENABLE([test-helper], [if test "x$enableval" = "xyes"; then test_helper=yes fi]) + +AC_CONFIG_FILES([helper/Makefile + helper/test/Makefile])
Don't keep helper data in the main configure, split it to an m4 just like the other sub dirs Signed-off-by: Mike Holmes <mike.holmes@linaro.org> --- configure.ac | 2 -- helper/m4/configure.m4 | 3 +++ 2 files changed, 3 insertions(+), 2 deletions(-) -- 2.9.3