| Message ID | 20170116170247.9862-1-abailon@baylibre.com |
|---|---|
| State | New |
| Headers | show |
Hello! On 01/16/2017 08:02 PM, Alexandre Bailon wrote: > DA8xx driver is registering and using the CPPI DMA controller but actually, > the DA8xx has a CPPI 4.1 DMA controller. > Update the driver to register and use the CPPI 4.1 DMA controller. > > Signed-off-by: Alexandre Bailon <abailon@baylibre.com> I have already expressed my opinion about this patch: I would like to see the CPPI 3.0 quirk/methods fixed first (backporting this to -stable). Then we can consider CPPI 4.1 DMA support. MNR, Sergei -- To unsubscribe from this list: send the line "unsubscribe linux-omap" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
On 01/16/2017 06:09 PM, Sergei Shtylyov wrote: > Hello! > > On 01/16/2017 08:02 PM, Alexandre Bailon wrote: > >> DA8xx driver is registering and using the CPPI DMA controller but >> actually, >> the DA8xx has a CPPI 4.1 DMA controller. >> Update the driver to register and use the CPPI 4.1 DMA controller. >> >> Signed-off-by: Alexandre Bailon <abailon@baylibre.com> > > I have already expressed my opinion about this patch: I would like to > see the CPPI 3.0 quirk/methods fixed first (backporting this to > -stable). Then we can consider CPPI 4.1 DMA support. I guess I have misunderstood you. I though you asked to send this patch alone (separated from the series that adds CPPI 4.1 support to DA8xx). I still not sure to understand what you want me to do. Best Regards, Alexandre > > MNR, Sergei > -- To unsubscribe from this list: send the line "unsubscribe linux-omap" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
On 01/16/2017 08:26 PM, Alexandre Bailon wrote: >>> DA8xx driver is registering and using the CPPI DMA controller but >>> actually, >>> the DA8xx has a CPPI 4.1 DMA controller. >>> Update the driver to register and use the CPPI 4.1 DMA controller. >>> >>> Signed-off-by: Alexandre Bailon <abailon@baylibre.com> >> >> I have already expressed my opinion about this patch: I would like to >> see the CPPI 3.0 quirk/methods fixed first (backporting this to >> -stable). Then we can consider CPPI 4.1 DMA support. > I guess I have misunderstood you. > I though you asked to send this patch alone (separated from the series > that adds CPPI 4.1 support to DA8xx). No, it wasn't what I wanted... > I still not sure to understand what you want me to do. I want the patch removing the CPPI (3.0) quirk and the corresponding method initializers. Then please do the patch enabling CPPI 4.1 support atop of that fix. > Best Regards, > Alexandre MBR, Sergei -- To unsubscribe from this list: send the line "unsubscribe linux-omap" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
On 01/16/2017 06:29 PM, Sergei Shtylyov wrote: > On 01/16/2017 08:26 PM, Alexandre Bailon wrote: > >>>> DA8xx driver is registering and using the CPPI DMA controller but >>>> actually, >>>> the DA8xx has a CPPI 4.1 DMA controller. >>>> Update the driver to register and use the CPPI 4.1 DMA controller. >>>> >>>> Signed-off-by: Alexandre Bailon <abailon@baylibre.com> >>> >>> I have already expressed my opinion about this patch: I would like to >>> see the CPPI 3.0 quirk/methods fixed first (backporting this to >>> -stable). Then we can consider CPPI 4.1 DMA support. > >> I guess I have misunderstood you. >> I though you asked to send this patch alone (separated from the series >> that adds CPPI 4.1 support to DA8xx). > > No, it wasn't what I wanted... > >> I still not sure to understand what you want me to do. > > I want the patch removing the CPPI (3.0) quirk and the corresponding > method initializers. Then please do the patch enabling CPPI 4.1 support > atop of that fix. Understood. I will do it. > >> Best Regards, >> Alexandre > > MBR, Sergei > -- To unsubscribe from this list: send the line "unsubscribe linux-omap" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
diff --git a/drivers/usb/musb/da8xx.c b/drivers/usb/musb/da8xx.c index e89708d..74dcc07 100644 --- a/drivers/usb/musb/da8xx.c +++ b/drivers/usb/musb/da8xx.c @@ -458,14 +458,14 @@ static inline u8 get_vbus_power(struct device *dev) } static const struct musb_platform_ops da8xx_ops = { - .quirks = MUSB_DMA_CPPI | MUSB_INDEXED_EP, + .quirks = MUSB_DMA_CPPI41 | MUSB_INDEXED_EP, .init = da8xx_musb_init, .exit = da8xx_musb_exit, .fifo_mode = 2, -#ifdef CONFIG_USB_TI_CPPI_DMA - .dma_init = cppi_dma_controller_create, - .dma_exit = cppi_dma_controller_destroy, +#ifdef CONFIG_USB_TI_CPPI41_DMA + .dma_init = cppi41_dma_controller_create, + .dma_exit = cppi41_dma_controller_destroy, #endif .enable = da8xx_musb_enable, .disable = da8xx_musb_disable,
DA8xx driver is registering and using the CPPI DMA controller but actually, the DA8xx has a CPPI 4.1 DMA controller. Update the driver to register and use the CPPI 4.1 DMA controller. Signed-off-by: Alexandre Bailon <abailon@baylibre.com> --- drivers/usb/musb/da8xx.c | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) -- 2.10.2 -- To unsubscribe from this list: send the line "unsubscribe linux-omap" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html