diff mbox

[2/3,media] s5p-fimc: Fix compiler warning in fimc-capture.c file

Message ID 1337927380-4435-2-git-send-email-sachin.kamat@linaro.org
State Not Applicable
Headers show

Commit Message

Sachin Kamat May 25, 2012, 6:29 a.m. UTC 
drivers/media/video/s5p-fimc/fimc-capture.c: In function ‘fimc_cap_streamon’:
drivers/media/video/s5p-fimc/fimc-capture.c:1053:29: warning: ignoring return
value of ‘media_entity_pipeline_start’, declared with attribute warn_unused_result [-Wunused-result]

Signed-off-by: Sachin Kamat <sachin.kamat@linaro.org>
---
 drivers/media/video/s5p-fimc/fimc-capture.c |    4 +++-
 1 files changed, 3 insertions(+), 1 deletions(-)

Comments

Sylwester Nawrocki/Kernel \(PLT\) /SRPOL/Staff Engineer/Samsung Electronics May 25, 2012, 10:28 a.m. UTC | #1 
Hi Sachin,

On 05/25/2012 08:29 AM, Sachin Kamat wrote:
> drivers/media/video/s5p-fimc/fimc-capture.c: In function ‘fimc_cap_streamon’:
> drivers/media/video/s5p-fimc/fimc-capture.c:1053:29: warning: ignoring return
> value of ‘media_entity_pipeline_start’, declared with attribute warn_unused_result [-Wunused-result]
> 
> Signed-off-by: Sachin Kamat <sachin.kamat@linaro.org>

Thanks for the patch. Sakari submitted a similar one
(http://patchwork.linuxtv.org/patch/10799) so I'd like to
apply that instead.

Regards,
Sylwester
Sylwester Nawrocki/Kernel \(PLT\) /SRPOL/Staff Engineer/Samsung Electronics May 25, 2012, 10:28 a.m. UTC | #2 
On 05/25/2012 08:29 AM, Sachin Kamat wrote:
> drivers/media/video/s5p-fimc/fimc-capture.c: In function ‘fimc_cap_streamon’:
> drivers/media/video/s5p-fimc/fimc-capture.c:1053:29: warning: ignoring return
> value of ‘media_entity_pipeline_start’, declared with attribute warn_unused_result [-Wunused-result]
> 
> Signed-off-by: Sachin Kamat <sachin.kamat@linaro.org>

Thanks, I've applied that one, with slightly extended commit message.

Regards,
Sylwester
diff mbox

Patch

diff --git a/drivers/media/video/s5p-fimc/fimc-capture.c b/drivers/media/video/s5p-fimc/fimc-capture.c
index 3545745..587d087 100644
--- a/drivers/media/video/s5p-fimc/fimc-capture.c
+++ b/drivers/media/video/s5p-fimc/fimc-capture.c
@@ -1050,8 +1050,10 @@  static int fimc_cap_streamon(struct file *file, void *priv,
 	if (fimc_capture_active(fimc))
 		return -EBUSY;
 
-	media_entity_pipeline_start(&p->subdevs[IDX_SENSOR]->entity,
+	ret = media_entity_pipeline_start(&p->subdevs[IDX_SENSOR]->entity,
 				    p->m_pipeline);
+	if (ret)
+		return ret;
 
 	if (fimc->vid_cap.user_subdev_api) {
 		ret = fimc_pipeline_validate(fimc);