| Message ID | 20250610105948.384540-3-tzimmermann@suse.de |
|---|---|
| State | New |
| Headers | show |
| Series | fbdev: Fix warnings related to including <linux/export.h> | expand |
On 6/10/25 12:56, Thomas Zimmermann wrote: > Fix the compile-time warnings > > drivers/video/fbdev/core/cfbcopyarea.c: warning: EXPORT_SYMBOL() is used, but #include <linux/export.h> is missing > drivers/video/fbdev/core/cfbfillrect.c: warning: EXPORT_SYMBOL() is used, but #include <linux/export.h> is missing > drivers/video/fbdev/core/cfbimgblt.c: warning: EXPORT_SYMBOL() is used, but #include <linux/export.h> is missing > drivers/video/fbdev/core/fb_ddc.c: warning: EXPORT_SYMBOL() is used, but #include <linux/export.h> is missing > drivers/video/fbdev/core/fb_defio.c: warning: EXPORT_SYMBOL() is used, but #include <linux/export.h> is missing > drivers/video/fbdev/core/fb_io_fops.c: warning: EXPORT_SYMBOL() is used, but #include <linux/export.h> is missing > drivers/video/fbdev/core/fb_sys_fops.c: warning: EXPORT_SYMBOL() is used, but #include <linux/export.h> is missing > drivers/video/fbdev/core/fbcmap.c: warning: EXPORT_SYMBOL() is used, but #include <linux/export.h> is missing > drivers/video/fbdev/core/fbcon.c: warning: EXPORT_SYMBOL() is used, but #include <linux/export.h> is missing > drivers/video/fbdev/core/fbmon.c: warning: EXPORT_SYMBOL() is used, but #include <linux/export.h> is missing > drivers/video/fbdev/core/modedb.c: warning: EXPORT_SYMBOL() is used, but #include <linux/export.h> is missing > drivers/video/fbdev/core/svgalib.c: warning: EXPORT_SYMBOL() is used, but #include <linux/export.h> is missing > drivers/video/fbdev/core/syscopyarea.c: warning: EXPORT_SYMBOL() is used, but #include <linux/export.h> is missing > drivers/video/fbdev/core/sysfillrect.c: warning: EXPORT_SYMBOL() is used, but #include <linux/export.h> is missing > drivers/video/fbdev/core/sysimgblt.c: warning: EXPORT_SYMBOL() is used, but #include <linux/export.h> is missing > drivers/video/fbdev/macmodes.c: warning: EXPORT_SYMBOL() is used, but #include <linux/export.h> is missing > drivers/video/fbdev/sbuslib.c: warning: EXPORT_SYMBOL() is used, but #include <linux/export.h> is missing > drivers/video/fbdev/wmt_ge_rops.c: warning: EXPORT_SYMBOL() is used, but #include <linux/export.h> is missing > > Signed-off-by: Thomas Zimmermann <tzimmermann@suse.de> > --- > drivers/video/fbdev/core/cfbcopyarea.c | 2 ++ > drivers/video/fbdev/core/cfbfillrect.c | 2 ++ > drivers/video/fbdev/core/cfbimgblt.c | 2 ++ > drivers/video/fbdev/core/fb_ddc.c | 1 + > drivers/video/fbdev/core/fb_defio.c | 1 + > drivers/video/fbdev/core/fb_io_fops.c | 1 + > drivers/video/fbdev/core/fb_sys_fops.c | 2 ++ > drivers/video/fbdev/core/fbcmap.c | 1 + > drivers/video/fbdev/core/fbcon.c | 1 + > drivers/video/fbdev/core/fbmon.c | 2 ++ > drivers/video/fbdev/core/modedb.c | 1 + > drivers/video/fbdev/core/svgalib.c | 1 + > drivers/video/fbdev/core/syscopyarea.c | 2 ++ > drivers/video/fbdev/core/sysfillrect.c | 2 ++ > drivers/video/fbdev/core/sysimgblt.c | 2 ++ > drivers/video/fbdev/macmodes.c | 1 + > drivers/video/fbdev/sbuslib.c | 1 + > drivers/video/fbdev/wmt_ge_rops.c | 1 + > 18 files changed, 26 insertions(+) Reviewed-by: Helge Deller <deller@gmx.de> I wonder why this shows up for you but not for me... Helge
Hi Am 10.06.25 um 21:58 schrieb Helge Deller: > On 6/10/25 12:56, Thomas Zimmermann wrote: >> Fix the compile-time warnings >> >> drivers/video/fbdev/core/cfbcopyarea.c: warning: EXPORT_SYMBOL() >> is used, but #include <linux/export.h> is missing >> drivers/video/fbdev/core/cfbfillrect.c: warning: EXPORT_SYMBOL() >> is used, but #include <linux/export.h> is missing >> drivers/video/fbdev/core/cfbimgblt.c: warning: EXPORT_SYMBOL() is >> used, but #include <linux/export.h> is missing >> drivers/video/fbdev/core/fb_ddc.c: warning: EXPORT_SYMBOL() is >> used, but #include <linux/export.h> is missing >> drivers/video/fbdev/core/fb_defio.c: warning: EXPORT_SYMBOL() is >> used, but #include <linux/export.h> is missing >> drivers/video/fbdev/core/fb_io_fops.c: warning: EXPORT_SYMBOL() is >> used, but #include <linux/export.h> is missing >> drivers/video/fbdev/core/fb_sys_fops.c: warning: EXPORT_SYMBOL() >> is used, but #include <linux/export.h> is missing >> drivers/video/fbdev/core/fbcmap.c: warning: EXPORT_SYMBOL() is >> used, but #include <linux/export.h> is missing >> drivers/video/fbdev/core/fbcon.c: warning: EXPORT_SYMBOL() is >> used, but #include <linux/export.h> is missing >> drivers/video/fbdev/core/fbmon.c: warning: EXPORT_SYMBOL() is >> used, but #include <linux/export.h> is missing >> drivers/video/fbdev/core/modedb.c: warning: EXPORT_SYMBOL() is >> used, but #include <linux/export.h> is missing >> drivers/video/fbdev/core/svgalib.c: warning: EXPORT_SYMBOL() is >> used, but #include <linux/export.h> is missing >> drivers/video/fbdev/core/syscopyarea.c: warning: EXPORT_SYMBOL() >> is used, but #include <linux/export.h> is missing >> drivers/video/fbdev/core/sysfillrect.c: warning: EXPORT_SYMBOL() >> is used, but #include <linux/export.h> is missing >> drivers/video/fbdev/core/sysimgblt.c: warning: EXPORT_SYMBOL() is >> used, but #include <linux/export.h> is missing >> drivers/video/fbdev/macmodes.c: warning: EXPORT_SYMBOL() is used, >> but #include <linux/export.h> is missing >> drivers/video/fbdev/sbuslib.c: warning: EXPORT_SYMBOL() is used, >> but #include <linux/export.h> is missing >> drivers/video/fbdev/wmt_ge_rops.c: warning: EXPORT_SYMBOL() is >> used, but #include <linux/export.h> is missing >> >> Signed-off-by: Thomas Zimmermann <tzimmermann@suse.de> >> --- >> drivers/video/fbdev/core/cfbcopyarea.c | 2 ++ >> drivers/video/fbdev/core/cfbfillrect.c | 2 ++ >> drivers/video/fbdev/core/cfbimgblt.c | 2 ++ >> drivers/video/fbdev/core/fb_ddc.c | 1 + >> drivers/video/fbdev/core/fb_defio.c | 1 + >> drivers/video/fbdev/core/fb_io_fops.c | 1 + >> drivers/video/fbdev/core/fb_sys_fops.c | 2 ++ >> drivers/video/fbdev/core/fbcmap.c | 1 + >> drivers/video/fbdev/core/fbcon.c | 1 + >> drivers/video/fbdev/core/fbmon.c | 2 ++ >> drivers/video/fbdev/core/modedb.c | 1 + >> drivers/video/fbdev/core/svgalib.c | 1 + >> drivers/video/fbdev/core/syscopyarea.c | 2 ++ >> drivers/video/fbdev/core/sysfillrect.c | 2 ++ >> drivers/video/fbdev/core/sysimgblt.c | 2 ++ >> drivers/video/fbdev/macmodes.c | 1 + >> drivers/video/fbdev/sbuslib.c | 1 + >> drivers/video/fbdev/wmt_ge_rops.c | 1 + >> 18 files changed, 26 insertions(+) > > Reviewed-by: Helge Deller <deller@gmx.de> > > I wonder why this shows up for you but not for me... They show up with v6.16-rc1 when I build with W=1. IDK if there's an additional config option involved. It's not just fbdev, the kernel is full of them. Best regards Thomas > > Helge
diff --git a/drivers/video/fbdev/core/cfbcopyarea.c b/drivers/video/fbdev/core/cfbcopyarea.c index 23fbf3a8df7c..ce2e6807be60 100644 --- a/drivers/video/fbdev/core/cfbcopyarea.c +++ b/drivers/video/fbdev/core/cfbcopyarea.c @@ -2,6 +2,8 @@ /* * Copyright (C) 2025 Zsolt Kajtar (soci@c64.rulez.org) */ + +#include <linux/export.h> #include <linux/module.h> #include <linux/fb.h> #include <linux/bitrev.h> diff --git a/drivers/video/fbdev/core/cfbfillrect.c b/drivers/video/fbdev/core/cfbfillrect.c index 615de89256d5..bd2fbbda10c6 100644 --- a/drivers/video/fbdev/core/cfbfillrect.c +++ b/drivers/video/fbdev/core/cfbfillrect.c @@ -2,6 +2,8 @@ /* * Copyright (C) 2025 Zsolt Kajtar (soci@c64.rulez.org) */ + +#include <linux/export.h> #include <linux/module.h> #include <linux/fb.h> #include <linux/bitrev.h> diff --git a/drivers/video/fbdev/core/cfbimgblt.c b/drivers/video/fbdev/core/cfbimgblt.c index bcec4e32c0e7..e116cd1d8a39 100644 --- a/drivers/video/fbdev/core/cfbimgblt.c +++ b/drivers/video/fbdev/core/cfbimgblt.c @@ -2,6 +2,8 @@ /* * Copyright (C) 2025 Zsolt Kajtar (soci@c64.rulez.org) */ + +#include <linux/export.h> #include <linux/module.h> #include <linux/fb.h> #include <linux/bitrev.h> diff --git a/drivers/video/fbdev/core/fb_ddc.c b/drivers/video/fbdev/core/fb_ddc.c index e25143219862..824796361367 100644 --- a/drivers/video/fbdev/core/fb_ddc.c +++ b/drivers/video/fbdev/core/fb_ddc.c @@ -10,6 +10,7 @@ #include <linux/delay.h> #include <linux/device.h> +#include <linux/export.h> #include <linux/module.h> #include <linux/fb.h> #include <linux/i2c-algo-bit.h> diff --git a/drivers/video/fbdev/core/fb_defio.c b/drivers/video/fbdev/core/fb_defio.c index 4fc93f253e06..8df2e51e3390 100644 --- a/drivers/video/fbdev/core/fb_defio.c +++ b/drivers/video/fbdev/core/fb_defio.c @@ -11,6 +11,7 @@ #include <linux/module.h> #include <linux/kernel.h> #include <linux/errno.h> +#include <linux/export.h> #include <linux/string.h> #include <linux/mm.h> #include <linux/vmalloc.h> diff --git a/drivers/video/fbdev/core/fb_io_fops.c b/drivers/video/fbdev/core/fb_io_fops.c index 3408ff1b2b7a..6ab60fcd0050 100644 --- a/drivers/video/fbdev/core/fb_io_fops.c +++ b/drivers/video/fbdev/core/fb_io_fops.c @@ -1,5 +1,6 @@ // SPDX-License-Identifier: GPL-2.0 +#include <linux/export.h> #include <linux/fb.h> #include <linux/module.h> #include <linux/uaccess.h> diff --git a/drivers/video/fbdev/core/fb_sys_fops.c b/drivers/video/fbdev/core/fb_sys_fops.c index a9aa6519a5b3..be96b3b3942e 100644 --- a/drivers/video/fbdev/core/fb_sys_fops.c +++ b/drivers/video/fbdev/core/fb_sys_fops.c @@ -9,6 +9,8 @@ * for more details. * */ + +#include <linux/export.h> #include <linux/fb.h> #include <linux/module.h> #include <linux/uaccess.h> diff --git a/drivers/video/fbdev/core/fbcmap.c b/drivers/video/fbdev/core/fbcmap.c index ff09e57f3c38..9cc3e87da14b 100644 --- a/drivers/video/fbdev/core/fbcmap.c +++ b/drivers/video/fbdev/core/fbcmap.c @@ -11,6 +11,7 @@ * more details. */ +#include <linux/export.h> #include <linux/string.h> #include <linux/module.h> #include <linux/fb.h> diff --git a/drivers/video/fbdev/core/fbcon.c b/drivers/video/fbdev/core/fbcon.c index 2df48037688d..25684f5d6523 100644 --- a/drivers/video/fbdev/core/fbcon.c +++ b/drivers/video/fbdev/core/fbcon.c @@ -56,6 +56,7 @@ * more details. */ +#include <linux/export.h> #include <linux/module.h> #include <linux/types.h> #include <linux/fs.h> diff --git a/drivers/video/fbdev/core/fbmon.c b/drivers/video/fbdev/core/fbmon.c index 0a26399dbc89..023caaea682e 100644 --- a/drivers/video/fbdev/core/fbmon.c +++ b/drivers/video/fbdev/core/fbmon.c @@ -26,6 +26,8 @@ * for more details. * */ + +#include <linux/export.h> #include <linux/fb.h> #include <linux/module.h> #include <linux/pci.h> diff --git a/drivers/video/fbdev/core/modedb.c b/drivers/video/fbdev/core/modedb.c index 7196b055f2bd..53a610948c4a 100644 --- a/drivers/video/fbdev/core/modedb.c +++ b/drivers/video/fbdev/core/modedb.c @@ -11,6 +11,7 @@ * more details. */ +#include <linux/export.h> #include <linux/module.h> #include <linux/slab.h> #include <linux/fb.h> diff --git a/drivers/video/fbdev/core/svgalib.c b/drivers/video/fbdev/core/svgalib.c index 821b89a0a645..d6053af749f6 100644 --- a/drivers/video/fbdev/core/svgalib.c +++ b/drivers/video/fbdev/core/svgalib.c @@ -10,6 +10,7 @@ * Some parts are based on David Boucher's viafb (http://davesdomain.org.uk/viafb/) */ +#include <linux/export.h> #include <linux/module.h> #include <linux/kernel.h> #include <linux/string.h> diff --git a/drivers/video/fbdev/core/syscopyarea.c b/drivers/video/fbdev/core/syscopyarea.c index b634e2d21208..773569bce67c 100644 --- a/drivers/video/fbdev/core/syscopyarea.c +++ b/drivers/video/fbdev/core/syscopyarea.c @@ -2,6 +2,8 @@ /* * Copyright (C) 2025 Zsolt Kajtar (soci@c64.rulez.org) */ + +#include <linux/export.h> #include <linux/module.h> #include <linux/fb.h> #include <linux/bitrev.h> diff --git a/drivers/video/fbdev/core/sysfillrect.c b/drivers/video/fbdev/core/sysfillrect.c index 372ca6a324c2..12eea3e424bb 100644 --- a/drivers/video/fbdev/core/sysfillrect.c +++ b/drivers/video/fbdev/core/sysfillrect.c @@ -2,6 +2,8 @@ /* * Copyright (C) 2025 Zsolt Kajtar (soci@c64.rulez.org) */ + +#include <linux/export.h> #include <linux/module.h> #include <linux/fb.h> #include <linux/bitrev.h> diff --git a/drivers/video/fbdev/core/sysimgblt.c b/drivers/video/fbdev/core/sysimgblt.c index c756cc658b7d..0a5bfd8ad095 100644 --- a/drivers/video/fbdev/core/sysimgblt.c +++ b/drivers/video/fbdev/core/sysimgblt.c @@ -2,6 +2,8 @@ /* * Copyright (C) 2025 Zsolt Kajtar (soci@c64.rulez.org) */ + +#include <linux/export.h> #include <linux/module.h> #include <linux/fb.h> #include <linux/bitrev.h> diff --git a/drivers/video/fbdev/macmodes.c b/drivers/video/fbdev/macmodes.c index cd689161f561..b16a9d9bef98 100644 --- a/drivers/video/fbdev/macmodes.c +++ b/drivers/video/fbdev/macmodes.c @@ -16,6 +16,7 @@ */ #include <linux/errno.h> +#include <linux/export.h> #include <linux/fb.h> #include <linux/string.h> #include <linux/module.h> diff --git a/drivers/video/fbdev/sbuslib.c b/drivers/video/fbdev/sbuslib.c index 4c79654bda30..dd2002d0810f 100644 --- a/drivers/video/fbdev/sbuslib.c +++ b/drivers/video/fbdev/sbuslib.c @@ -5,6 +5,7 @@ */ #include <linux/compat.h> +#include <linux/export.h> #include <linux/kernel.h> #include <linux/module.h> #include <linux/string.h> diff --git a/drivers/video/fbdev/wmt_ge_rops.c b/drivers/video/fbdev/wmt_ge_rops.c index 92fbb3f3a0d3..2bd26bfb2b46 100644 --- a/drivers/video/fbdev/wmt_ge_rops.c +++ b/drivers/video/fbdev/wmt_ge_rops.c @@ -7,6 +7,7 @@ * Copyright (C) 2010 Alexey Charkov <alchark@gmail.com> */ +#include <linux/export.h> #include <linux/module.h> #include <linux/fb.h> #include <linux/io.h>
Fix the compile-time warnings drivers/video/fbdev/core/cfbcopyarea.c: warning: EXPORT_SYMBOL() is used, but #include <linux/export.h> is missing drivers/video/fbdev/core/cfbfillrect.c: warning: EXPORT_SYMBOL() is used, but #include <linux/export.h> is missing drivers/video/fbdev/core/cfbimgblt.c: warning: EXPORT_SYMBOL() is used, but #include <linux/export.h> is missing drivers/video/fbdev/core/fb_ddc.c: warning: EXPORT_SYMBOL() is used, but #include <linux/export.h> is missing drivers/video/fbdev/core/fb_defio.c: warning: EXPORT_SYMBOL() is used, but #include <linux/export.h> is missing drivers/video/fbdev/core/fb_io_fops.c: warning: EXPORT_SYMBOL() is used, but #include <linux/export.h> is missing drivers/video/fbdev/core/fb_sys_fops.c: warning: EXPORT_SYMBOL() is used, but #include <linux/export.h> is missing drivers/video/fbdev/core/fbcmap.c: warning: EXPORT_SYMBOL() is used, but #include <linux/export.h> is missing drivers/video/fbdev/core/fbcon.c: warning: EXPORT_SYMBOL() is used, but #include <linux/export.h> is missing drivers/video/fbdev/core/fbmon.c: warning: EXPORT_SYMBOL() is used, but #include <linux/export.h> is missing drivers/video/fbdev/core/modedb.c: warning: EXPORT_SYMBOL() is used, but #include <linux/export.h> is missing drivers/video/fbdev/core/svgalib.c: warning: EXPORT_SYMBOL() is used, but #include <linux/export.h> is missing drivers/video/fbdev/core/syscopyarea.c: warning: EXPORT_SYMBOL() is used, but #include <linux/export.h> is missing drivers/video/fbdev/core/sysfillrect.c: warning: EXPORT_SYMBOL() is used, but #include <linux/export.h> is missing drivers/video/fbdev/core/sysimgblt.c: warning: EXPORT_SYMBOL() is used, but #include <linux/export.h> is missing drivers/video/fbdev/macmodes.c: warning: EXPORT_SYMBOL() is used, but #include <linux/export.h> is missing drivers/video/fbdev/sbuslib.c: warning: EXPORT_SYMBOL() is used, but #include <linux/export.h> is missing drivers/video/fbdev/wmt_ge_rops.c: warning: EXPORT_SYMBOL() is used, but #include <linux/export.h> is missing Signed-off-by: Thomas Zimmermann <tzimmermann@suse.de> --- drivers/video/fbdev/core/cfbcopyarea.c | 2 ++ drivers/video/fbdev/core/cfbfillrect.c | 2 ++ drivers/video/fbdev/core/cfbimgblt.c | 2 ++ drivers/video/fbdev/core/fb_ddc.c | 1 + drivers/video/fbdev/core/fb_defio.c | 1 + drivers/video/fbdev/core/fb_io_fops.c | 1 + drivers/video/fbdev/core/fb_sys_fops.c | 2 ++ drivers/video/fbdev/core/fbcmap.c | 1 + drivers/video/fbdev/core/fbcon.c | 1 + drivers/video/fbdev/core/fbmon.c | 2 ++ drivers/video/fbdev/core/modedb.c | 1 + drivers/video/fbdev/core/svgalib.c | 1 + drivers/video/fbdev/core/syscopyarea.c | 2 ++ drivers/video/fbdev/core/sysfillrect.c | 2 ++ drivers/video/fbdev/core/sysimgblt.c | 2 ++ drivers/video/fbdev/macmodes.c | 1 + drivers/video/fbdev/sbuslib.c | 1 + drivers/video/fbdev/wmt_ge_rops.c | 1 + 18 files changed, 26 insertions(+)