diff mbox series

[v2,4/5] dt-bindings: thermal: Document Airoha AN7583 support

Message ID 20250527215241.25767-5-ansuelsmth@gmail.com
State New
Headers show
Series thermal/drivers: airoha: Add support for AN7583 | expand

Commit Message

Christian Marangi May 27, 2025, 9:52 p.m. UTC
Document support for Airoha AN7583 thermal driver.

Airoha AN7583 follow the same logic of Airoha EN7581 to read the
temperature but lack all the support for the PTP_THERMAL used to monitor
and react when trip point are triggered.

Also the Airoha AN7583 lives entirely under the Chip SCU SoC register
space hence a dedicated schema is introduced.

Signed-off-by: Christian Marangi <ansuelsmth@gmail.com>
---
 .../thermal/airoha,an7583-thermal.yaml        | 31 +++++++++++++++++++
 1 file changed, 31 insertions(+)
 create mode 100644 Documentation/devicetree/bindings/thermal/airoha,an7583-thermal.yaml

Comments

Krzysztof Kozlowski May 28, 2025, 7:28 a.m. UTC | #1
On 27/05/2025 23:52, Christian Marangi wrote:
> Document support for Airoha AN7583 thermal driver.
> 
> Airoha AN7583 follow the same logic of Airoha EN7581 to read the
> temperature but lack all the support for the PTP_THERMAL used to monitor
> and react when trip point are triggered.
> 
> Also the Airoha AN7583 lives entirely under the Chip SCU SoC register
> space hence a dedicated schema is introduced.


That's wrong argumentation. If this is part of SCU, it does not mean you
need separate schema. Quite opposite. No resources here, so this should
be folded into parent node.

Best regards,
Krzysztof
diff mbox series

Patch

diff --git a/Documentation/devicetree/bindings/thermal/airoha,an7583-thermal.yaml b/Documentation/devicetree/bindings/thermal/airoha,an7583-thermal.yaml
new file mode 100644
index 000000000000..cfd37e33c541
--- /dev/null
+++ b/Documentation/devicetree/bindings/thermal/airoha,an7583-thermal.yaml
@@ -0,0 +1,31 @@ 
+# SPDX-License-Identifier: (GPL-2.0 OR BSD-2-Clause)
+%YAML 1.2
+---
+$id: http://devicetree.org/schemas/thermal/airoha,an7583-thermal.yaml#
+$schema: http://devicetree.org/meta-schemas/core.yaml#
+
+title: Airoha Thermal Sensor and Monitor
+
+maintainers:
+  - Christian Marangi <ansuelsmth@gmail.com>
+
+properties:
+  compatible:
+    const: airoha,an7583-thermal
+
+  '#thermal-sensor-cells':
+    const: 0
+
+required:
+  - compatible
+  - '#thermal-sensor-cells'
+
+additionalProperties: false
+
+examples:
+  - |
+    thermal-sensor {
+        compatible = "airoha,an7583-thermal";
+
+        #thermal-sensor-cells = <0>;
+    };