diff mbox series

interconnect: qcom: sm8650: remove regmap config for mc_virt & clk_virt

Message ID 20250519-topic-sm8650-upstream-icc-qos-fix-v1-1-6ace779250aa@linaro.org
State New
Headers show
Series interconnect: qcom: sm8650: remove regmap config for mc_virt & clk_virt | expand

Commit Message

Neil Armstrong May 19, 2025, 1:57 p.m. UTC 
The mc_virt & clk_virt nodes are virtual and doesn't have associated registers,
thus the regmap config will fail with:
qnoc-sm8650 interconnect-0: error -EINVAL: invalid resource (null)

Remove the regmap config since QoS will never be applied to those virtual
nodes.

Reported-by: Pengyu Luo <mitltlatltl@gmail.com>
Fixes: 40ef9b6b778f ("interconnect: qcom: sm8650: enable QoS configuration")
Signed-off-by: Neil Armstrong <neil.armstrong@linaro.org>
---
 drivers/interconnect/qcom/sm8650.c | 2 --
 1 file changed, 2 deletions(-)


---
base-commit: 8566fc3b96539e3235909d6bdda198e1282beaed
change-id: 20250519-topic-sm8650-upstream-icc-qos-fix-17cbb5e7c6c4

Best regards,
diff mbox series

Patch

diff --git a/drivers/interconnect/qcom/sm8650.c b/drivers/interconnect/qcom/sm8650.c
index 1eb2cc3bea672a01f88bfcf24fd82395a07ea36f..b7c321f4e4b51cbcb138e906e561325393e3e14e 100644
--- a/drivers/interconnect/qcom/sm8650.c
+++ b/drivers/interconnect/qcom/sm8650.c
@@ -1701,7 +1701,6 @@  static struct qcom_icc_node * const clk_virt_nodes[] = {
 };
 
 static const struct qcom_icc_desc sm8650_clk_virt = {
-	.config = &icc_regmap_config,
 	.nodes = clk_virt_nodes,
 	.num_nodes = ARRAY_SIZE(clk_virt_nodes),
 	.bcms = clk_virt_bcms,
@@ -1881,7 +1880,6 @@  static struct qcom_icc_node * const mc_virt_nodes[] = {
 };
 
 static const struct qcom_icc_desc sm8650_mc_virt = {
-	.config = &icc_regmap_config,
 	.nodes = mc_virt_nodes,
 	.num_nodes = ARRAY_SIZE(mc_virt_nodes),
 	.bcms = mc_virt_bcms,