| Message ID | 20250518-selftests-anon-inode-build-v1-1-71eff8183168@kernel.org |
|---|---|
| State | Superseded |
| Headers | show |
| Series | selftests/filesystems: Fix build of anon_inode_test | expand |
On Sun, May 18, 2025 at 03:01:34PM +0100, Mark Brown wrote: > The anon_inode_test test fails to build due to attempting to include > a nonexisting overlayfs/wrapper.h: > > anon_inode_test.c:10:10: fatal error: overlayfs/wrappers.h: No such file or directory > 10 | #include "overlayfs/wrappers.h" > | ^~~~~~~~~~~~~~~~~~~~~~ This build failure, first reported against -next and which should be fixed by this patch, is now present in mainline. > This is due to 0bd92b9fe538 ("selftests/filesystems: move wrapper.h out > of overlayfs subdir") which was added in the vfs-6.16.selftests branch > which was based on -rc5 and does not contain the newly added test so > once things were merged into vfs.all in the build started failing - both > parent commits are fine. > > Fixes: feaa00dbff45a ("Merge branch 'vfs-6.16.selftests' into vfs.all") I see that the two branches get sent separately to Linus so the merge that triggers things is now: 3e406741b19890 ("Merge tag 'vfs-6.16-rc1.selftests' of git://git.kernel.org/pub/scm/linux/kernel/git/vfs/vfs") I'll resend with that updated. > Signed-off-by: Mark Brown <broonie@kernel.org> > --- > tools/testing/selftests/filesystems/anon_inode_test.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/tools/testing/selftests/filesystems/anon_inode_test.c b/tools/testing/selftests/filesystems/anon_inode_test.c > index e8e0ef1460d2..73e0a4d4fb2f 100644 > --- a/tools/testing/selftests/filesystems/anon_inode_test.c > +++ b/tools/testing/selftests/filesystems/anon_inode_test.c > @@ -7,7 +7,7 @@ > #include <sys/stat.h> > > #include "../kselftest_harness.h" > -#include "overlayfs/wrappers.h" > +#include "wrappers.h" > > TEST(anon_inode_no_chown) > { > > --- > base-commit: feaa00dbff45ad9a0dcd04a92f88c745bf880f55 > change-id: 20250516-selftests-anon-inode-build-007e206e8422 > > Best regards, > -- > Mark Brown <broonie@kernel.org> >
diff --git a/tools/testing/selftests/filesystems/anon_inode_test.c b/tools/testing/selftests/filesystems/anon_inode_test.c index e8e0ef1460d2..73e0a4d4fb2f 100644 --- a/tools/testing/selftests/filesystems/anon_inode_test.c +++ b/tools/testing/selftests/filesystems/anon_inode_test.c @@ -7,7 +7,7 @@ #include <sys/stat.h> #include "../kselftest_harness.h" -#include "overlayfs/wrappers.h" +#include "wrappers.h" TEST(anon_inode_no_chown) {
The anon_inode_test test fails to build due to attempting to include a nonexisting overlayfs/wrapper.h: anon_inode_test.c:10:10: fatal error: overlayfs/wrappers.h: No such file or directory 10 | #include "overlayfs/wrappers.h" | ^~~~~~~~~~~~~~~~~~~~~~ This is due to 0bd92b9fe538 ("selftests/filesystems: move wrapper.h out of overlayfs subdir") which was added in the vfs-6.16.selftests branch which was based on -rc5 and does not contain the newly added test so once things were merged into vfs.all in the build started failing - both parent commits are fine. Fixes: feaa00dbff45a ("Merge branch 'vfs-6.16.selftests' into vfs.all") Signed-off-by: Mark Brown <broonie@kernel.org> --- tools/testing/selftests/filesystems/anon_inode_test.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) --- base-commit: feaa00dbff45ad9a0dcd04a92f88c745bf880f55 change-id: 20250516-selftests-anon-inode-build-007e206e8422 Best regards,