| Message ID | 97fcc39f3e63f465c49e8725d10f7c43fd35cd85.1747605658.git.ericflorin@google.com |
|---|---|
| State | New |
| Headers | show |
| Series | staging: sm750fb: style cleanup in `lynx_accel` | expand |
On Sun, May 18, 2025 at 03:09:47PM -0700, Eric Florin wrote: > Rename `dpPortBase` to `dp_port_base` to conform with kernel style > guidelines as reported by checkpatch.pl > > CHECK: Avoid CamelCase: <dpPortBase> > > Signed-off-by: Eric Florin <ericflorin@google.com> > --- > drivers/staging/sm750fb/sm750.h | 2 +- > drivers/staging/sm750fb/sm750_accel.c | 2 +- > drivers/staging/sm750fb/sm750_hw.c | 2 +- > 3 files changed, 3 insertions(+), 3 deletions(-) > > diff --git a/drivers/staging/sm750fb/sm750.h b/drivers/staging/sm750fb/sm750.h > index a2342c69a65a..0ed1e18611ba 100644 > --- a/drivers/staging/sm750fb/sm750.h > +++ b/drivers/staging/sm750fb/sm750.h > @@ -52,7 +52,7 @@ struct lynx_accel { > /* base virtual address of DPR registers */ > volatile unsigned char __iomem *dpr_base; > /* base virtual address of de data port */ > - volatile unsigned char __iomem *dpPortBase; > + volatile unsigned char __iomem *dp_port_base; Same here, are you sure this doesn't come directly from the hardware spec? thanks, greg k-h
diff --git a/drivers/staging/sm750fb/sm750.h b/drivers/staging/sm750fb/sm750.h index a2342c69a65a..0ed1e18611ba 100644 --- a/drivers/staging/sm750fb/sm750.h +++ b/drivers/staging/sm750fb/sm750.h @@ -52,7 +52,7 @@ struct lynx_accel { /* base virtual address of DPR registers */ volatile unsigned char __iomem *dpr_base; /* base virtual address of de data port */ - volatile unsigned char __iomem *dpPortBase; + volatile unsigned char __iomem *dp_port_base; /* function pointers */ void (*de_init)(struct lynx_accel *accel); diff --git a/drivers/staging/sm750fb/sm750_accel.c b/drivers/staging/sm750fb/sm750_accel.c index 97791f1b0123..7ac2e7b6ea0f 100644 --- a/drivers/staging/sm750fb/sm750_accel.c +++ b/drivers/staging/sm750fb/sm750_accel.c @@ -29,7 +29,7 @@ static inline u32 read_dpr(struct lynx_accel *accel, int offset) static inline void write_dpPort(struct lynx_accel *accel, u32 data) { - writel(data, accel->dpPortBase); + writel(data, accel->dp_port_base); } void sm750_hw_de_init(struct lynx_accel *accel) diff --git a/drivers/staging/sm750fb/sm750_hw.c b/drivers/staging/sm750fb/sm750_hw.c index 159a5ad621f2..75ceb594fcb1 100644 --- a/drivers/staging/sm750fb/sm750_hw.c +++ b/drivers/staging/sm750fb/sm750_hw.c @@ -59,7 +59,7 @@ int hw_sm750_map(struct sm750_dev *sm750_dev, struct pci_dev *pdev) pr_info("mmio virtual addr = %p\n", sm750_dev->pvReg); sm750_dev->accel.dpr_base = sm750_dev->pvReg + DE_BASE_ADDR_TYPE1; - sm750_dev->accel.dpPortBase = sm750_dev->pvReg + DE_PORT_ADDR_TYPE1; + sm750_dev->accel.dp_port_base = sm750_dev->pvReg + DE_PORT_ADDR_TYPE1; mmio750 = sm750_dev->pvReg; sm750_set_chip_type(sm750_dev->devid, sm750_dev->revid);
Rename `dpPortBase` to `dp_port_base` to conform with kernel style guidelines as reported by checkpatch.pl CHECK: Avoid CamelCase: <dpPortBase> Signed-off-by: Eric Florin <ericflorin@google.com> --- drivers/staging/sm750fb/sm750.h | 2 +- drivers/staging/sm750fb/sm750_accel.c | 2 +- drivers/staging/sm750fb/sm750_hw.c | 2 +- 3 files changed, 3 insertions(+), 3 deletions(-)