| Message ID | 20250512212832.3674722-11-demonsingur@gmail.com |
|---|---|
| State | New |
| Headers | show |
| Series | media: i2c: add Maxim GMSL2/3 serializer and deserializer drivers | expand |
On Tue, May 13, 2025 at 12:28:19AM +0300, Cosmin Tanislav wrote: > The MAX96712 actually has a GPIO named PWDNB, which will put the chip > in reset state when held low. Esentially, it works as an enable GPIO, > but the naming is different. > > Deprecate the enable-gpios property, and add powerdown-gpios as the > rest of the GMSL chips. > > Change the example to use powerdown-gpios. I don't know that this is worth changing because then we have to maintain both forever. > Signed-off-by: Cosmin Tanislav <demonsingur@gmail.com> > --- > .../devicetree/bindings/media/i2c/maxim,max96712.yaml | 10 ++++++++-- > 1 file changed, 8 insertions(+), 2 deletions(-) > > diff --git a/Documentation/devicetree/bindings/media/i2c/maxim,max96712.yaml b/Documentation/devicetree/bindings/media/i2c/maxim,max96712.yaml > index b345305acc4c..e38213209973 100644 > --- a/Documentation/devicetree/bindings/media/i2c/maxim,max96712.yaml > +++ b/Documentation/devicetree/bindings/media/i2c/maxim,max96712.yaml > @@ -35,7 +35,13 @@ properties: > description: I2C device address > maxItems: 1 > > - enable-gpios: true > + enable-gpios: > + maxItems: 1 > + deprecated: true > + > + powerdown-gpios: > + maxItems: 1 > + description: Specifier for the GPIO connected to the PWDNB pin. > > i2c-alias-pool: > maxItems: 4 > @@ -128,7 +134,7 @@ examples: > gmsl0: gmsl-deserializer@49 { > compatible = "maxim,max96712"; > reg = <0x49>; > - enable-gpios = <&pca9654_a 0 GPIO_ACTIVE_HIGH>; > + powerdown-gpios = <&pca9654_a 0 GPIO_ACTIVE_LOW>; > > ports { > #address-cells = <1>; > -- > 2.49.0 >
diff --git a/Documentation/devicetree/bindings/media/i2c/maxim,max96712.yaml b/Documentation/devicetree/bindings/media/i2c/maxim,max96712.yaml index b345305acc4c..e38213209973 100644 --- a/Documentation/devicetree/bindings/media/i2c/maxim,max96712.yaml +++ b/Documentation/devicetree/bindings/media/i2c/maxim,max96712.yaml @@ -35,7 +35,13 @@ properties: description: I2C device address maxItems: 1 - enable-gpios: true + enable-gpios: + maxItems: 1 + deprecated: true + + powerdown-gpios: + maxItems: 1 + description: Specifier for the GPIO connected to the PWDNB pin. i2c-alias-pool: maxItems: 4 @@ -128,7 +134,7 @@ examples: gmsl0: gmsl-deserializer@49 { compatible = "maxim,max96712"; reg = <0x49>; - enable-gpios = <&pca9654_a 0 GPIO_ACTIVE_HIGH>; + powerdown-gpios = <&pca9654_a 0 GPIO_ACTIVE_LOW>; ports { #address-cells = <1>;
The MAX96712 actually has a GPIO named PWDNB, which will put the chip in reset state when held low. Esentially, it works as an enable GPIO, but the naming is different. Deprecate the enable-gpios property, and add powerdown-gpios as the rest of the GMSL chips. Change the example to use powerdown-gpios. Signed-off-by: Cosmin Tanislav <demonsingur@gmail.com> --- .../devicetree/bindings/media/i2c/maxim,max96712.yaml | 10 ++++++++-- 1 file changed, 8 insertions(+), 2 deletions(-)