Message ID | 4FBC5BDE.6020304@linaro.org |
---|---|
State | New |
Headers | show |
On 05/23/2012 05:39 AM, Michael Hope wrote: > On 21/05/12 21:14, Paolo Carlini wrote: >> On 05/21/2012 01:45 AM, Michael Hope wrote: >>> The testsuite for PR52796 uses the 'target c++11' selector which >>> doesn't exist in 4.6. >>> This patch backports the selector, clearing the 'ERROR: >>> g++.dg/cpp0x/variadic-value1.C: >>> syntax error in target selector "target c++11" for " dg-do 2 run { >>> target c++11 } "' >>> errors which have appeared in recent 4.6 builds. >>> >>> Tested on x86_64-linux-gnu with no regressions. Changes the ERROR to >>> UNSUPPORTED. >>> >>> OK for 4.6? >> To be honest, when I saw the issue I thought we wanted simply to not >> use the target selector at all in the branch and simply add a // { >> dg-options "-std=c++11" } I thought somebody would commit the change >> as obvious ;) > > Sure. The version below changes the selector for explicit flags that > match those passed by trunk. > > OK for 4.6? > > -- Michael (who's not keen enough to commit as obvious) I would say let's go ahead ;) But in the ChangeLog entry please use PR c++/52796. Paolo. Paolo.
On 24 May 2012 00:27, Paolo Carlini <paolo.carlini@oracle.com> wrote: > On 05/23/2012 05:39 AM, Michael Hope wrote: >> >> On 21/05/12 21:14, Paolo Carlini wrote: >>> >>> On 05/21/2012 01:45 AM, Michael Hope wrote: >>>> >>>> The testsuite for PR52796 uses the 'target c++11' selector which doesn't >>>> exist in 4.6. >>>> This patch backports the selector, clearing the 'ERROR: >>>> g++.dg/cpp0x/variadic-value1.C: >>>> syntax error in target selector "target c++11" for " dg-do 2 run { >>>> target c++11 } "' >>>> errors which have appeared in recent 4.6 builds. >>>> >>>> Tested on x86_64-linux-gnu with no regressions. Changes the ERROR to >>>> UNSUPPORTED. >>>> >>>> OK for 4.6? >>> >>> To be honest, when I saw the issue I thought we wanted simply to not use >>> the target selector at all in the branch and simply add a // { dg-options >>> "-std=c++11" } I thought somebody would commit the change as obvious ;) >> >> >> Sure. The version below changes the selector for explicit flags that >> match those passed by trunk. >> >> OK for 4.6? >> >> -- Michael (who's not keen enough to commit as obvious) > > I would say let's go ahead ;) But in the ChangeLog entry please use PR > c++/52796. Done as per http://gcc.gnu.org/ml/gcc-cvs/2012-05/msg00810.html and the typo fix in http://gcc.gnu.org/ml/gcc-cvs/2012-05/msg00813.html. -- Michael
diff --git a/gcc/testsuite/g++.dg/cpp0x/variadic-value1.C b/gcc/testsuite/g++.dg/cpp0x/variadic-value1.C index 179919a..301bd54 100644 --- a/gcc/testsuite/g++.dg/cpp0x/variadic-value1.C +++ b/gcc/testsuite/g++.dg/cpp0x/variadic-value1.C @@ -1,5 +1,5 @@ // PR c++/52796 -// { dg-do run { target c++11 } } +// { dg-options "-std=c++0x -pedantic-errors" } inline void *operator new(__SIZE_TYPE__ s, void *p) { return p; }