| Message ID | m3plgi9pwu.fsf@t19.piap.pl |
|---|---|
| State | New |
| Headers | show |
| Series | i.MX8 ISI crossbar: simplify a couple of error messages | expand |
Hi Krzysztof, On Fri, May 09, 2025 at 09:58:09AM +0200, Krzysztof Hałasa wrote: > I guess these messages were split from a single function. Or was it > for saving memory? :-) The goal was indeed to save memory. > Signed-off-by: Krzysztof Hałasa <khalasa@piap.pl> > > diff --git a/drivers/media/platform/nxp/imx8-isi/imx8-isi-crossbar.c b/drivers/media/platform/nxp/imx8-isi/imx8-isi-crossbar.c > index 93a55c97cd17..b6c7f114f9ed 100644 > --- a/drivers/media/platform/nxp/imx8-isi/imx8-isi-crossbar.c > +++ b/drivers/media/platform/nxp/imx8-isi/imx8-isi-crossbar.c > @@ -352,9 +352,8 @@ static int mxc_isi_crossbar_enable_streams(struct v4l2_subdev *sd, > sink_streams); > if (ret) { > dev_err(xbar->isi->dev, > - "failed to %s streams 0x%llx on '%s':%u: %d\n", > - "enable", sink_streams, remote_sd->name, > - remote_pad, ret); > + "failed to enable streams 0x%llx on '%s':%u: %d\n", > + sink_streams, remote_sd->name, remote_pad, ret); > mxc_isi_crossbar_gasket_disable(xbar, sink_pad); > return ret; > } > @@ -392,9 +391,8 @@ static int mxc_isi_crossbar_disable_streams(struct v4l2_subdev *sd, > sink_streams); > if (ret) > dev_err(xbar->isi->dev, > - "failed to %s streams 0x%llx on '%s':%u: %d\n", > - "disable", sink_streams, remote_sd->name, > - remote_pad, ret); > + "failed to disable streams 0x%llx on '%s':%u: %d\n", > + sink_streams, remote_sd->name, remote_pad, ret); > > mxc_isi_crossbar_gasket_disable(xbar, sink_pad); > }
diff --git a/drivers/media/platform/nxp/imx8-isi/imx8-isi-crossbar.c b/drivers/media/platform/nxp/imx8-isi/imx8-isi-crossbar.c index 93a55c97cd17..b6c7f114f9ed 100644 --- a/drivers/media/platform/nxp/imx8-isi/imx8-isi-crossbar.c +++ b/drivers/media/platform/nxp/imx8-isi/imx8-isi-crossbar.c @@ -352,9 +352,8 @@ static int mxc_isi_crossbar_enable_streams(struct v4l2_subdev *sd, sink_streams); if (ret) { dev_err(xbar->isi->dev, - "failed to %s streams 0x%llx on '%s':%u: %d\n", - "enable", sink_streams, remote_sd->name, - remote_pad, ret); + "failed to enable streams 0x%llx on '%s':%u: %d\n", + sink_streams, remote_sd->name, remote_pad, ret); mxc_isi_crossbar_gasket_disable(xbar, sink_pad); return ret; } @@ -392,9 +391,8 @@ static int mxc_isi_crossbar_disable_streams(struct v4l2_subdev *sd, sink_streams); if (ret) dev_err(xbar->isi->dev, - "failed to %s streams 0x%llx on '%s':%u: %d\n", - "disable", sink_streams, remote_sd->name, - remote_pad, ret); + "failed to disable streams 0x%llx on '%s':%u: %d\n", + sink_streams, remote_sd->name, remote_pad, ret); mxc_isi_crossbar_gasket_disable(xbar, sink_pad); }
I guess these messages were split from a single function. Or was it for saving memory? :-) Signed-off-by: Krzysztof Hałasa <khalasa@piap.pl>