| Message ID | 20250508-a623-gpu-support-v3-1-3cb31799d44e@quicinc.com |
|---|---|
| State | New |
| Headers | show |
| Series | Support for Adreno 623 GPU | expand |
On 08/05/2025 18:19, Akhil P Oommen wrote: > From: Jie Zhang <quic_jiezh@quicinc.com> > > Document Adreno 623 GMU in the dt-binding specification. > > Signed-off-by: Jie Zhang <quic_jiezh@quicinc.com> > Signed-off-by: Akhil P Oommen <quic_akhilpo@quicinc.com> > Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> Drop. You changed patch significantly, like 90%! > --- > .../devicetree/bindings/display/msm/gmu.yaml | 34 ++++++++++++++++++++++ > 1 file changed, 34 insertions(+) > > diff --git a/Documentation/devicetree/bindings/display/msm/gmu.yaml b/Documentation/devicetree/bindings/display/msm/gmu.yaml > index 4392aa7a4ffe2492d69a21e067be1f42e00016d8..afc1879357440c137cadeb2d9a74ae8459570a25 100644 > --- a/Documentation/devicetree/bindings/display/msm/gmu.yaml > +++ b/Documentation/devicetree/bindings/display/msm/gmu.yaml > @@ -124,6 +124,40 @@ allOf: > contains: > enum: > - qcom,adreno-gmu-623.0 I don't understand. 623 is already here, you document nothing new. This makes no sense, I never, absolutely never reviewed code like this. NAK Best regards, Krzysztof
On 5/9/2025 11:12 AM, Krzysztof Kozlowski wrote: > On 08/05/2025 18:19, Akhil P Oommen wrote: >> From: Jie Zhang <quic_jiezh@quicinc.com> >> >> Document Adreno 623 GMU in the dt-binding specification. >> >> Signed-off-by: Jie Zhang <quic_jiezh@quicinc.com> >> Signed-off-by: Akhil P Oommen <quic_akhilpo@quicinc.com> >> Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> > > Drop. You changed patch significantly, like 90%! Aah! my bad. This is actually a new patch which I mentioned in the cover letter: "Update dt-bindings yaml with a new patch#1" I will update the subject and drop the R-b tag. > >> --- >> .../devicetree/bindings/display/msm/gmu.yaml | 34 ++++++++++++++++++++++ >> 1 file changed, 34 insertions(+) >> >> diff --git a/Documentation/devicetree/bindings/display/msm/gmu.yaml b/Documentation/devicetree/bindings/display/msm/gmu.yaml >> index 4392aa7a4ffe2492d69a21e067be1f42e00016d8..afc1879357440c137cadeb2d9a74ae8459570a25 100644 >> --- a/Documentation/devicetree/bindings/display/msm/gmu.yaml >> +++ b/Documentation/devicetree/bindings/display/msm/gmu.yaml >> @@ -124,6 +124,40 @@ allOf: >> contains: >> enum: >> - qcom,adreno-gmu-623.0 > > I don't understand. 623 is already here, you document nothing new. This > makes no sense, I never, absolutely never reviewed code like this. The clock list is different for 623. We are removing smmu_clk for 623. -Akhil > > NAK > > > Best regards, > Krzysztof
diff --git a/Documentation/devicetree/bindings/display/msm/gmu.yaml b/Documentation/devicetree/bindings/display/msm/gmu.yaml index 4392aa7a4ffe2492d69a21e067be1f42e00016d8..afc1879357440c137cadeb2d9a74ae8459570a25 100644 --- a/Documentation/devicetree/bindings/display/msm/gmu.yaml +++ b/Documentation/devicetree/bindings/display/msm/gmu.yaml @@ -124,6 +124,40 @@ allOf: contains: enum: - qcom,adreno-gmu-623.0 + then: + properties: + reg: + items: + - description: Core GMU registers + - description: Resource controller registers + - description: GMU PDC registers + reg-names: + items: + - const: gmu + - const: rscc + - const: gmu_pdc + clocks: + items: + - description: GMU clock + - description: GPU CX clock + - description: GPU AXI clock + - description: GPU MEMNOC clock + - description: GPU AHB clock + - description: GPU HUB CX clock + clock-names: + items: + - const: gmu + - const: cxo + - const: axi + - const: memnoc + - const: ahb + - const: hub + + - if: + properties: + compatible: + contains: + enum: - qcom,adreno-gmu-635.0 - qcom,adreno-gmu-660.1 - qcom,adreno-gmu-663.0