diff mbox series

[V2,1/3] scsi: ufs: dt-bindings: Document UFS Disable LPM property

Message ID 20250506163705.31518-2-quic_nitirawa@quicinc.com
State New
Headers show
Series Add support to disable UFS LPM | expand

Commit Message

Nitin Rawat May 6, 2025, 4:37 p.m. UTC
Disable UFS low power mode on emulation FPGA platforms or other platforms
where it is either unsupported or power efficiency is not a critical
requirement.

Document the UFS Disable LPM property for such platforms.

Signed-off-by: Nitin Rawat <quic_nitirawa@quicinc.com>
---
 Documentation/devicetree/bindings/ufs/ufs-common.yaml | 5 +++++
 1 file changed, 5 insertions(+)

Comments

Krzysztof Kozlowski May 6, 2025, 6:16 p.m. UTC | #1
On 06/05/2025 18:37, Nitin Rawat wrote:
> Disable UFS low power mode on emulation FPGA platforms or other platforms

Why wouldn't you like to test LPM also on FPGA designs? I do not see
here correlation.

> where it is either unsupported or power efficiency is not a critical
> requirement.

That's a policy, not hardware, thus not suitable for DT.

Best regards,
Krzysztof
Nitin Rawat May 7, 2025, 3:04 p.m. UTC | #2
On 5/6/2025 11:46 PM, Krzysztof Kozlowski wrote:
> On 06/05/2025 18:37, Nitin Rawat wrote:
>> Disable UFS low power mode on emulation FPGA platforms or other platforms
> 
> Why wouldn't you like to test LPM also on FPGA designs? I do not see
> here correlation.

Hi Krzysztof,

Since the FPGA platform doesn't support UFS Low Power Modes (such as the 
AutoHibern8 feature specified in the UFS specification), I have included 
this information in the hardware description (i.e dts).

Thanks,
Nitin

> 
>> where it is either unsupported or power efficiency is not a critical
>> requirement.
> 
> That's a policy, not hardware, thus not suitable for DT.
> 
> Best regards,
> Krzysztof
diff mbox series

Patch

diff --git a/Documentation/devicetree/bindings/ufs/ufs-common.yaml b/Documentation/devicetree/bindings/ufs/ufs-common.yaml
index 31fe7f30ff5b..eab28beb0e76 100644
--- a/Documentation/devicetree/bindings/ufs/ufs-common.yaml
+++ b/Documentation/devicetree/bindings/ufs/ufs-common.yaml
@@ -89,6 +89,11 @@  properties:
 
   msi-parent: true
 
+  disable-lpm:
+    type: boolean
+    description:
+      Disable UFS LPM features.
+
 dependencies:
   freq-table-hz: [ clocks ]
   operating-points-v2: [ clocks, clock-names ]