| Message ID | 20250426062305.work.819-kees@kernel.org |
|---|---|
| State | New |
| Headers | show |
| Series | video: fbdev: arkfb: Cast ics5342_init() allocation type | expand |
diff --git a/drivers/video/fbdev/arkfb.c b/drivers/video/fbdev/arkfb.c index 082501feceb9..7d131e3d159a 100644 --- a/drivers/video/fbdev/arkfb.c +++ b/drivers/video/fbdev/arkfb.c @@ -431,7 +431,7 @@ static struct dac_ops ics5342_ops = { static struct dac_info * ics5342_init(dac_read_regs_t drr, dac_write_regs_t dwr, void *data) { - struct dac_info *info = kzalloc(sizeof(struct ics5342_info), GFP_KERNEL); + struct dac_info *info = (struct dac_info *)kzalloc(sizeof(struct ics5342_info), GFP_KERNEL); if (! info) return NULL;
In preparation for making the kmalloc family of allocators type aware, we need to make sure that the returned type from the allocation matches the type of the variable being assigned. (Before, the allocator would always return "void *", which can be implicitly cast to any pointer type.) The assigned type is "struct dac_info *" but the returned type will be "struct ics5342_info *", which has a larger allocation size. This is by design, as struct ics5342_info contains struct dac_info as its first member. Cast the allocation type to match the assignment. Signed-off-by: Kees Cook <kees@kernel.org> --- Cc: Helge Deller <deller@gmx.de> Cc: Javier Martinez Canillas <javierm@redhat.com> Cc: Thomas Zimmermann <tzimmermann@suse.de> Cc: Zheyu Ma <zheyuma97@gmail.com> Cc: Samuel Thibault <samuel.thibault@ens-lyon.org> Cc: Jiapeng Chong <jiapeng.chong@linux.alibaba.com> Cc: <linux-fbdev@vger.kernel.org> Cc: <dri-devel@lists.freedesktop.org> --- drivers/video/fbdev/arkfb.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)