diff mbox series

[v5,2/5] i2c: piix4: Depends on X86

Message ID 20250422234830.2840784-3-superm1@kernel.org
State New
Headers show
Series [tip:,x86/platform] i2c: piix4: Make CONFIG_I2C_PIIX4 dependent on CONFIG_X86 | expand

Commit Message

Mario Limonciello April 22, 2025, 11:48 p.m. UTC 
From: Mario Limonciello <mario.limonciello@amd.com>

PIIX4 and compatible controllers are only for X86. As some headers are
being moved into x86 specific headers PIIX4 won't compile on non-x86.

Suggested-by: Ingo Molnar <mingo@kernel.org>
Signed-off-by: Mario Limonciello <mario.limonciello@amd.com>
---
v5:
 * Drop unnecessary tags
---
 drivers/i2c/busses/Kconfig | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Andi Shyti April 28, 2025, 6:18 p.m. UTC | #1 
On Sat, Apr 26, 2025 at 11:42:21AM +0200, Ingo Molnar wrote:
> * Andi Shyti <andi.shyti@kernel.org> wrote:
> > On Tue, Apr 22, 2025 at 06:48:27PM -0500, Mario Limonciello wrote:
> > > From: Mario Limonciello <mario.limonciello@amd.com>
> > > 
> > > PIIX4 and compatible controllers are only for X86. As some headers are
> > > being moved into x86 specific headers PIIX4 won't compile on non-x86.
> > > 
> > > Suggested-by: Ingo Molnar <mingo@kernel.org>
> > > Signed-off-by: Mario Limonciello <mario.limonciello@amd.com>
> > 
> > OK, so these are going through x86, at the end.
> 
> Yeah, if you don't mind. There's a later x86 patch (5/5) that depends 
> on the new header.

sure!

> > Acked-by: Andi Shyti <andi.shyti@kernel.org>
> 
> Thanks! I've added your acks to the commits.

Thanks!
Andi
diff mbox series

Patch

diff --git a/drivers/i2c/busses/Kconfig b/drivers/i2c/busses/Kconfig
index 83c88c79afe20..bbbd6240fa6ed 100644
--- a/drivers/i2c/busses/Kconfig
+++ b/drivers/i2c/busses/Kconfig
@@ -200,7 +200,7 @@  config I2C_ISMT
 
 config I2C_PIIX4
 	tristate "Intel PIIX4 and compatible (ATI/AMD/Serverworks/Broadcom/SMSC)"
-	depends on PCI && HAS_IOPORT
+	depends on PCI && HAS_IOPORT && X86
 	select I2C_SMBUS
 	help
 	  If you say yes to this option, support will be included for the Intel