| Message ID | 20250426061526.work.106-kees@kernel.org |
|---|---|
| State | New |
| Headers | show |
| Series | media: iris: Cast iris_hfi_gen2_get_instance() allocation type | expand |
diff --git a/drivers/media/platform/qcom/iris/iris_hfi_gen2_command.c b/drivers/media/platform/qcom/iris/iris_hfi_gen2_command.c index a908b41e2868..351820deb893 100644 --- a/drivers/media/platform/qcom/iris/iris_hfi_gen2_command.c +++ b/drivers/media/platform/qcom/iris/iris_hfi_gen2_command.c @@ -953,5 +953,5 @@ void iris_hfi_gen2_command_ops_init(struct iris_core *core) struct iris_inst *iris_hfi_gen2_get_instance(void) { - return kzalloc(sizeof(struct iris_inst_hfi_gen2), GFP_KERNEL); + return (struct iris_inst *)kzalloc(sizeof(struct iris_inst_hfi_gen2), GFP_KERNEL); }
In preparation for making the kmalloc family of allocators type aware, we need to make sure that the returned type from the allocation matches the type of the variable being assigned. (Before, the allocator would always return "void *", which can be implicitly cast to any pointer type.) The assigned type is "struct iris_inst *", but the returned type is "struct iris_inst_hfi_gen2 *". The allocation is intentionally larger as the first member of struct iris_inst_hfi_gen2 is struct iris_inst, so this is by design. Cast the allocation type to match the assignment. Signed-off-by: Kees Cook <kees@kernel.org> --- Cc: Vikash Garodia <quic_vgarodia@quicinc.com> Cc: Dikshita Agarwal <quic_dikshita@quicinc.com> Cc: Abhinav Kumar <quic_abhinavk@quicinc.com> Cc: Mauro Carvalho Chehab <mchehab@kernel.org> Cc: <linux-media@vger.kernel.org> Cc: <linux-arm-msm@vger.kernel.org> --- drivers/media/platform/qcom/iris/iris_hfi_gen2_command.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)