| Message ID | 20250425-b4-media-committers-25-04-25-camss-supplies-v2-2-8c12450b2934@linaro.org |
|---|---|
| State | Superseded |
| Headers | show |
| Series | media: qcom: camss: x1e80100: Add support for individual CSIPHY supplies | expand |
On Fri, Apr 25, 2025 at 04:17:34PM +0100, Bryan O'Donoghue wrote: > Amend the names of the csiphy supplies to be specific to each CSIPHY thus > allowing for the case where PHYs have individual or shared rails. > > Signed-off-by: Bryan O'Donoghue <bryan.odonoghue@linaro.org> > --- > drivers/media/platform/qcom/camss/camss.c | 16 ++++++++-------- > 1 file changed, 8 insertions(+), 8 deletions(-) > > diff --git a/drivers/media/platform/qcom/camss/camss.c b/drivers/media/platform/qcom/camss/camss.c > index 06f42875702f02f9d8d83d06ddaa972eacb593f8..d63bc7dc951690132e07ee0fb8df7cef9b66927d 100644 > --- a/drivers/media/platform/qcom/camss/camss.c > +++ b/drivers/media/platform/qcom/camss/camss.c > @@ -2486,8 +2486,8 @@ static const struct resources_icc icc_res_sm8550[] = { > static const struct camss_subdev_resources csiphy_res_x1e80100[] = { > /* CSIPHY0 */ > { > - .regulators = { "vdd-csiphy-0p8-supply", > - "vdd-csiphy-1p2-supply" }, > + .regulators = { "vdd-csiphy0-0p8", > + "vdd-csiphy0-1p2" }, This is an ABI break. Please mention in the cover message why we are allowing it. > .clock = { "csiphy0", "csiphy0_timer" }, > .clock_rate = { { 300000000, 400000000, 480000000 }, > { 266666667, 400000000 } },
On 25/04/2025 18:27, Dmitry Baryshkov wrote: >> static const struct camss_subdev_resources csiphy_res_x1e80100[] = { >> /* CSIPHY0 */ >> { >> - .regulators = { "vdd-csiphy-0p8-supply", >> - "vdd-csiphy-1p2-supply" }, >> + .regulators = { "vdd-csiphy0-0p8", >> + "vdd-csiphy0-1p2" }, > This is an ABI break. Please mention in the cover message why we are > allowing it. Not an ABI break as we have no upstream consumer of this just yet. I'll V3 this to make clear though. --- bod
diff --git a/drivers/media/platform/qcom/camss/camss.c b/drivers/media/platform/qcom/camss/camss.c index 06f42875702f02f9d8d83d06ddaa972eacb593f8..d63bc7dc951690132e07ee0fb8df7cef9b66927d 100644 --- a/drivers/media/platform/qcom/camss/camss.c +++ b/drivers/media/platform/qcom/camss/camss.c @@ -2486,8 +2486,8 @@ static const struct resources_icc icc_res_sm8550[] = { static const struct camss_subdev_resources csiphy_res_x1e80100[] = { /* CSIPHY0 */ { - .regulators = { "vdd-csiphy-0p8-supply", - "vdd-csiphy-1p2-supply" }, + .regulators = { "vdd-csiphy0-0p8", + "vdd-csiphy0-1p2" }, .clock = { "csiphy0", "csiphy0_timer" }, .clock_rate = { { 300000000, 400000000, 480000000 }, { 266666667, 400000000 } }, @@ -2501,8 +2501,8 @@ static const struct camss_subdev_resources csiphy_res_x1e80100[] = { }, /* CSIPHY1 */ { - .regulators = { "vdd-csiphy-0p8-supply", - "vdd-csiphy-1p2-supply" }, + .regulators = { "vdd-csiphy1-0p8", + "vdd-csiphy1-1p2" }, .clock = { "csiphy1", "csiphy1_timer" }, .clock_rate = { { 300000000, 400000000, 480000000 }, { 266666667, 400000000 } }, @@ -2516,8 +2516,8 @@ static const struct camss_subdev_resources csiphy_res_x1e80100[] = { }, /* CSIPHY2 */ { - .regulators = { "vdd-csiphy-0p8-supply", - "vdd-csiphy-1p2-supply" }, + .regulators = { "vdd-csiphy2-0p8", + "vdd-csiphy2-1p2" }, .clock = { "csiphy2", "csiphy2_timer" }, .clock_rate = { { 300000000, 400000000, 480000000 }, { 266666667, 400000000 } }, @@ -2531,8 +2531,8 @@ static const struct camss_subdev_resources csiphy_res_x1e80100[] = { }, /* CSIPHY4 */ { - .regulators = { "vdd-csiphy-0p8-supply", - "vdd-csiphy-1p2-supply" }, + .regulators = { "vdd-csiphy4-0p8", + "vdd-csiphy4-1p2" }, .clock = { "csiphy4", "csiphy4_timer" }, .clock_rate = { { 300000000, 400000000, 480000000 }, { 266666667, 400000000 } },
Amend the names of the csiphy supplies to be specific to each CSIPHY thus allowing for the case where PHYs have individual or shared rails. Signed-off-by: Bryan O'Donoghue <bryan.odonoghue@linaro.org> --- drivers/media/platform/qcom/camss/camss.c | 16 ++++++++-------- 1 file changed, 8 insertions(+), 8 deletions(-)