| Message ID | 1482143465-14584-3-git-send-email-yamada.masahiro@socionext.com |
|---|---|
| State | New |
| Headers | show |
On Mon, Dec 19, 2016 at 8:31 AM, Masahiro Yamada <yamada.masahiro@socionext.com> wrote: > CONFIG_USE_ARCH_MEMSET controls nothing about SPL. (it is effective > only on U-Boot proper building of ARM). > > Signed-off-by: Masahiro Yamada <yamada.masahiro@socionext.com> Reviewed-by: Fabio Estevam <fabio.estevam@nxp.com> _______________________________________________ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
On Mon, Dec 19, 2016 at 07:31:03PM +0900, Masahiro Yamada wrote: > CONFIG_USE_ARCH_MEMSET controls nothing about SPL. (it is effective > only on U-Boot proper building of ARM). That's not true. We have these functions available to SPL and use them there by default now (as it's a speed win and we want out of SPL ASAP). -- Tom _______________________________________________ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
Hi Tom. 2016-12-20 7:02 GMT+09:00 Tom Rini <trini@konsulko.com>: > On Mon, Dec 19, 2016 at 07:31:03PM +0900, Masahiro Yamada wrote: > >> CONFIG_USE_ARCH_MEMSET controls nothing about SPL. (it is effective >> only on U-Boot proper building of ARM). > > That's not true. We have these functions available to SPL and use them > there by default now (as it's a speed win and we want out of SPL ASAP). > This is not clear to me. How can you make the optimized memset available to SPL? As far as see arch/arm/lib/Makefile, memset.o is only compiled (if CONFIG_USE_ARCH_MEMSET is defined) for the U-Boot full image. ifndef CONFIG_SPL_BUILD ifdef CONFIG_ARM64 obj-y += relocate_64.o else obj-y += relocate.o endif obj-$(CONFIG_CPU_V7M) += cmd_boot.o obj-$(CONFIG_OF_LIBFDT) += bootm-fdt.o obj-$(CONFIG_CMD_BOOTI) += bootm.o obj-$(CONFIG_CMD_BOOTM) += bootm.o obj-$(CONFIG_CMD_BOOTZ) += bootm.o zimage.o obj-$(CONFIG_SYS_L2_PL310) += cache-pl310.o obj-$(CONFIG_USE_ARCH_MEMSET) += memset.o obj-$(CONFIG_USE_ARCH_MEMCPY) += memcpy.o else obj-$(CONFIG_SPL_FRAMEWORK) += spl.o obj-$(CONFIG_SPL_FRAMEWORK) += zimage.o endif -- Best Regards Masahiro Yamada _______________________________________________ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
diff --git a/common/init/board_init.c b/common/init/board_init.c index ef01a9a..a2edb4e 100644 --- a/common/init/board_init.c +++ b/common/init/board_init.c @@ -15,9 +15,7 @@ DECLARE_GLOBAL_DATA_PTR; * It isn't trivial to figure out whether memcpy() exists. The arch-specific * memcpy() is not normally available in SPL due to code size. */ -#if !defined(CONFIG_SPL_BUILD) || \ - (defined(CONFIG_SPL_LIBGENERIC_SUPPORT) && \ - !defined(CONFIG_USE_ARCH_MEMSET)) +#if !defined(CONFIG_SPL_BUILD) || defined(CONFIG_SPL_LIBGENERIC_SUPPORT) #define _USE_MEMCPY #endif
CONFIG_USE_ARCH_MEMSET controls nothing about SPL. (it is effective only on U-Boot proper building of ARM). Signed-off-by: Masahiro Yamada <yamada.masahiro@socionext.com> --- common/init/board_init.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) -- 2.7.4 _______________________________________________ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot