| Message ID | 20250422091056.972734-1-zhangzihuan@kylinos.cn |
|---|---|
| State | New |
| Headers | show |
| Series | [v1] ACPI: battery: Reduce unnecessary calls to acpi_battery_update() | expand |
diff --git a/drivers/acpi/battery.c b/drivers/acpi/battery.c index 6760330a8af5..9446c57b77e7 100644 --- a/drivers/acpi/battery.c +++ b/drivers/acpi/battery.c @@ -1083,7 +1083,8 @@ static void acpi_battery_notify(acpi_handle handle, u32 event, void *data) msleep(battery_notification_delay_ms); if (event == ACPI_BATTERY_NOTIFY_INFO) acpi_battery_refresh(battery); - acpi_battery_update(battery, false); + if (event == ACPI_BATTERY_NOTIFY_STATUS) + acpi_battery_update(battery, false); acpi_bus_generate_netlink_event(device->pnp.device_class, dev_name(&device->dev), event, acpi_battery_present(battery));
When entering the acpi_mattery_notify function, no matter what the event is, acpi_mattery_update will definitely be called. Use the acpi_listen command to listen, sometimes the log looks like this: battery xxx:00 00000081 00000001 battery xxx:00 00000000 00000001 battery xxx:00 00000080 00000001 Firmware manufacturers will customize some events like 0x0, so non-matching events will be ignored. Signed-off-by: zhangzihuan <zhangzihuan@kylinos.cn> --- drivers/acpi/battery.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-)