| Message ID | 20250421-sm8750_usb_master-v5-10-25c79ed01d02@oss.qualcomm.com |
|---|---|
| State | New |
| Headers | show |
| Series | phy: qcom: Introduce USB support for SM8750 | expand |
On 22/04/2025 00:00, Melody Olvera wrote: > The SM8750 SoCs use an eUSB2 PHY driver different from the Qualcomm SM8750 That's a defconfig for all vendors. > already existing M31 USB driver because it requires a connection > to an eUSB2 repeater. Thus, for USB to probe and work properly on > SM8750, enable the additional driver. Commit msg should mention which board uses it. Best regards, Krzysztof
On 4/24/2025 6:16 AM, Krzysztof Kozlowski wrote: > On 22/04/2025 00:00, Melody Olvera wrote: >> The SM8750 SoCs use an eUSB2 PHY driver different from the > Qualcomm SM8750 > > That's a defconfig for all vendors. And...? Apologies, I understand what is actionable about this comment. Please be clear what you want done about this. > >> already existing M31 USB driver because it requires a connection >> to an eUSB2 repeater. Thus, for USB to probe and work properly on >> SM8750, enable the additional driver. > Commit msg should mention which board uses it. Sure thing. Thanks, Melody
On 24/04/2025 19:13, Melody Olvera wrote: > > > On 4/24/2025 6:16 AM, Krzysztof Kozlowski wrote: >> On 22/04/2025 00:00, Melody Olvera wrote: >>> The SM8750 SoCs use an eUSB2 PHY driver different from the >> Qualcomm SM8750 >> >> That's a defconfig for all vendors. > > And...? Apologies, I understand what is actionable about this comment. > Please be clear what you want done about this. s/SM8750/Qualcomm SM8750/ because otherwise how anyone non-qcom would know what this commit is about? Best regards, Krzysztof
diff --git a/arch/arm64/configs/defconfig b/arch/arm64/configs/defconfig index 9e16b494ab0e258908811be082f678099ed2cf4c..f0ab5ba8df045bbcbab16ab736342f3d261f4297 100644 --- a/arch/arm64/configs/defconfig +++ b/arch/arm64/configs/defconfig @@ -1575,6 +1575,7 @@ CONFIG_PHY_QCOM_QUSB2=m CONFIG_PHY_QCOM_SNPS_EUSB2=m CONFIG_PHY_QCOM_EUSB2_REPEATER=m CONFIG_PHY_QCOM_M31_USB=m +CONFIG_PHY_QCOM_M31_EUSB=m CONFIG_PHY_QCOM_USB_HS=m CONFIG_PHY_QCOM_USB_SNPS_FEMTO_V2=m CONFIG_PHY_QCOM_USB_HS_28NM=m
The SM8750 SoCs use an eUSB2 PHY driver different from the already existing M31 USB driver because it requires a connection to an eUSB2 repeater. Thus, for USB to probe and work properly on SM8750, enable the additional driver. Signed-off-by: Melody Olvera <melody.olvera@oss.qualcomm.com> --- arch/arm64/configs/defconfig | 1 + 1 file changed, 1 insertion(+)