| Message ID | 20250411003827.782544-7-iuncuim@gmail.com |
|---|---|
| State | New |
| Headers | show |
| Series | Add support for A523 Thermal system | expand |
On Fri, 11 Apr 2025 08:38:26 +0800, iuncuim wrote: > From: Mikhail Kalashnikov <iuncuim@gmail.com> > > Add dt-bindings description of the thermal sensors in the A523 processor. > > Signed-off-by: Mikhail Kalashnikov <iuncuim@gmail.com> > --- > .../bindings/thermal/allwinner,sun8i-a83t-ths.yaml | 5 +++++ > 1 file changed, 5 insertions(+) > My bot found errors running 'make dt_binding_check' on your patch: yamllint warnings/errors: dtschema/dtc warnings/errors: /builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/thermal/allwinner,sun8i-a83t-ths.example.dtb: thermal-sensor@1c25000 (allwinner,sun8i-h3-ths): clock-names:1: 'gpadc' was expected from schema $id: http://devicetree.org/schemas/thermal/allwinner,sun8i-a83t-ths.yaml# doc reference errors (make refcheckdocs): See https://patchwork.ozlabs.org/project/devicetree-bindings/patch/20250411003827.782544-7-iuncuim@gmail.com The base for the series is generally the latest rc1. A different dependency should be noted in *this* patch. If you already ran 'make dt_binding_check' and didn't see the above error(s), then make sure 'yamllint' is installed and dt-schema is up to date: pip3 install dtschema --upgrade Please check and re-submit after running the above command yourself. Note that DT_SCHEMA_FILES can be set to your schema file to speed up checking your schema. However, it must be unset to test all examples with your schema.
On 4/11/25 04:21, Rob Herring (Arm) wrote: > On Fri, 11 Apr 2025 08:38:26 +0800, iuncuim wrote: >> From: Mikhail Kalashnikov <iuncuim@gmail.com> >> >> Add dt-bindings description of the thermal sensors in the A523 processor. >> >> Signed-off-by: Mikhail Kalashnikov <iuncuim@gmail.com> >> --- >> .../bindings/thermal/allwinner,sun8i-a83t-ths.yaml | 5 +++++ >> 1 file changed, 5 insertions(+) >> > My bot found errors running 'make dt_binding_check' on your patch: > > yamllint warnings/errors: > > dtschema/dtc warnings/errors: > /builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/thermal/allwinner,sun8i-a83t-ths.example.dtb: thermal-sensor@1c25000 (allwinner,sun8i-h3-ths): clock-names:1: 'gpadc' was expected > from schema $id: http://devicetree.org/schemas/thermal/allwinner,sun8i-a83t-ths.yaml# Thanks for the reply, I didn't know about this tool, I will use it in v2. > > doc reference errors (make refcheckdocs): > > See https://patchwork.ozlabs.org/project/devicetree-bindings/patch/20250411003827.782544-7-iuncuim@gmail.com > > The base for the series is generally the latest rc1. A different dependency > should be noted in *this* patch. Yes, I forgot to point out that the patches are based on 6.15-rc1 using dts patches from that series that didn't make it into the latest rc: https://lore.kernel.org/linux-sunxi/20250307005712.16828-1-andre.przywara@arm.com/T/#t I'll add that information to the cover letter. > > If you already ran 'make dt_binding_check' and didn't see the above > error(s), then make sure 'yamllint' is installed and dt-schema is up to > date: > > pip3 install dtschema --upgrade > > Please check and re-submit after running the above command yourself. Note > that DT_SCHEMA_FILES can be set to your schema file to speed up checking > your schema. However, it must be unset to test all examples with your schema. >
diff --git a/Documentation/devicetree/bindings/thermal/allwinner,sun8i-a83t-ths.yaml b/Documentation/devicetree/bindings/thermal/allwinner,sun8i-a83t-ths.yaml index 3e61689f6..70ac395ef 100644 --- a/Documentation/devicetree/bindings/thermal/allwinner,sun8i-a83t-ths.yaml +++ b/Documentation/devicetree/bindings/thermal/allwinner,sun8i-a83t-ths.yaml @@ -24,17 +24,21 @@ properties: - allwinner,sun50i-h5-ths - allwinner,sun50i-h6-ths - allwinner,sun50i-h616-ths + - allwinner,sun55i-a523-ths0 + - allwinner,sun55i-a523-ths1 clocks: minItems: 1 items: - description: Bus Clock + - description: GPADC Clock - description: Module Clock clock-names: minItems: 1 items: - const: bus + - const: gpadc - const: mod reg: @@ -107,6 +111,7 @@ allOf: enum: - allwinner,sun8i-h3-ths - allwinner,sun20i-d1-ths + - allwinner,sun55i-a523-ths0 then: properties: