| Message ID | 20250410154217.1849977-3-zhen.xin@nokia-sbell.com |
|---|---|
| State | New |
| Headers | show |
| Series | wifi: rtw88: sdio: Enable tx status for management frames | expand |
On Thu, Apr 10, 2025 at 5:46 PM Zhen XIN <zhen.xin@nokia-sbell.com> wrote: > > Rtw88-sdio do not work in AP mode due to the lack of tx status report for Ping-Ke, in case you want to keep the spelling of rtw88 consistent: can you update it while applying the patch (or do we need a v3)? Same question for the other patch in this series. > management frames. > > Map the management frames to queue TX_DESC_QSEL_MGMT, which enables the > chip to generate TX reports for these frames > > Tested-on: rtl8723ds > > Fixes: 65371a3f14e7 ("wifi: rtw88: sdio: Add HCI implementation for SDIO based chipsets") > Signed-off-by: Zhen XIN <zhen.xin@nokia-sbell.com> Reviewed-by: Martin Blumenstingl <martin.blumenstingl@googlemail.com>
Martin Blumenstingl <martin.blumenstingl@googlemail.com> wrote: > > On Thu, Apr 10, 2025 at 5:46 PM Zhen XIN <zhen.xin@nokia-sbell.com> wrote: > > > > Rtw88-sdio do not work in AP mode due to the lack of tx status report for > Ping-Ke, in case you want to keep the spelling of rtw88 consistent: > can you update it while applying the patch (or do we need a v3)? > Same question for the other patch in this series. I can update commit messages while applying patches. But not sure what you mentioned. Did you mean to change 'Rtw88-sdio' to 'rtw88-sdio'?
On Wed, Apr 16, 2025 at 2:33 AM Ping-Ke Shih <pkshih@realtek.com> wrote: > > Martin Blumenstingl <martin.blumenstingl@googlemail.com> wrote: > > > > On Thu, Apr 10, 2025 at 5:46 PM Zhen XIN <zhen.xin@nokia-sbell.com> wrote: > > > > > > Rtw88-sdio do not work in AP mode due to the lack of tx status report for > > Ping-Ke, in case you want to keep the spelling of rtw88 consistent: > > can you update it while applying the patch (or do we need a v3)? > > Same question for the other patch in this series. > > I can update commit messages while applying patches. But not sure what you > mentioned. Did you mean to change 'Rtw88-sdio' to 'rtw88-sdio'? Indeed, I meant changing Rtw88-sdio to rtw88-sdio Thank you!
diff --git a/drivers/net/wireless/realtek/rtw88/sdio.c b/drivers/net/wireless/realtek/rtw88/sdio.c index ef51128a4b44..4311eb7cffef 100644 --- a/drivers/net/wireless/realtek/rtw88/sdio.c +++ b/drivers/net/wireless/realtek/rtw88/sdio.c @@ -718,10 +718,7 @@ static u8 rtw_sdio_get_tx_qsel(struct rtw_dev *rtwdev, struct sk_buff *skb, case RTW_TX_QUEUE_H2C: return TX_DESC_QSEL_H2C; case RTW_TX_QUEUE_MGMT: - if (rtw_chip_wcpu_11n(rtwdev)) - return TX_DESC_QSEL_HIGH; - else - return TX_DESC_QSEL_MGMT; + return TX_DESC_QSEL_MGMT; case RTW_TX_QUEUE_HI0: return TX_DESC_QSEL_HIGH; default:
Rtw88-sdio do not work in AP mode due to the lack of tx status report for management frames. Map the management frames to queue TX_DESC_QSEL_MGMT, which enables the chip to generate TX reports for these frames Tested-on: rtl8723ds Fixes: 65371a3f14e7 ("wifi: rtw88: sdio: Add HCI implementation for SDIO based chipsets") Signed-off-by: Zhen XIN <zhen.xin@nokia-sbell.com> --- drivers/net/wireless/realtek/rtw88/sdio.c | 5 +---- 1 file changed, 1 insertion(+), 4 deletions(-)